Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82380/?format=api
{ "id": 82380, "url": "http://patches.dpdk.org/api/patches/82380/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-16-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027210115.2529025-16-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027210115.2529025-16-thomas@monjalon.net", "date": "2020-10-27T21:01:15", "name": "[v3,15/15] mbuf: remove userdata field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f810ff9d649265fa6130fd137c9830c970227d97", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-16-thomas@monjalon.net/mbox/", "series": [ { "id": 13393, "url": "http://patches.dpdk.org/api/series/13393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13393", "date": "2020-10-27T21:01:00", "name": "remove mbuf userdata", "version": 3, "mbox": "http://patches.dpdk.org/series/13393/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82380/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/82380/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA41AA04B5;\n\tTue, 27 Oct 2020 22:06:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A51695A8C;\n\tTue, 27 Oct 2020 22:02:30 +0100 (CET)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CB7F72BDB\n for <dev@dpdk.org>; Tue, 27 Oct 2020 22:02:24 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 678C65C00B4;\n Tue, 27 Oct 2020 17:02:23 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 27 Oct 2020 17:02:23 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 311D2328005D;\n Tue, 27 Oct 2020 17:02:21 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=cAs1fn75z12U/\n eGvLRzSn5M1GqqkZv38pdTsyTdaF+k=; b=sTBHQoVjfqkc4GoJYtV5Vw8foWOgd\n 24b9K2NbsdHld6z5/dCQ7YFksGA+7bIEAi1ET4N225ZkFNTdZar1rHmFoJI3XOuU\n VN/QVIHGekF2v+WbG1fjFB9io0cKz8/G1u0ivUSaFOMWN5VLrZYVU3Rldkm3U/OC\n evPopukL0cxqvCtFosIVxWyqTQNePDeTszjTncBpZ7VXDzzauh0aOaNBr0m88EcC\n Klc9yYIpDYyvSEcxOMZEEw7K8inKFFxGE/ooqrbBZ20R920zBsqabRyhfxq7wRRV\n u+jRlArxP/9TekIdVXpX0ySwTquTRenxOhtGADpEQ9D8Z0412gwPjlOTA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=cAs1fn75z12U/eGvLRzSn5M1GqqkZv38pdTsyTdaF+k=; b=sBOA6dJ9\n W1SmfZoRVLvbXJtXV2F8aelEikuC0Nu1WXwGX4FJ8PMQCXuub/zG6zyEwBB7Gxw/\n OSeR4EpC4QEE20oit5ci3Y09hR+ldJPzvLYsU8+2fRrHPw0FNbwFw2v90//6sZmT\n jw39mOw9OcKPDMSUJUbXJuzWiIuSMvDfVWbR6rbjHXXT5uUZ4eWUaUnESZfPIaN6\n njNsC5wxHEugssHqsnKCz7MGpNC6Km72+ybrV8jsVnkldNiXYCxE4+MyZ+2ln02M\n +s1Ag0EoXwYKwNMpYVG4YVvmaI3eZOvNo7b5kQ35sBemHE6Zd76Sybxpfc20pgcK\n hr3xxYbKMrEUQg==" ], "X-ME-Sender": "<xms:3oqYX4gh2ApQRyY3lCTfv7AWfBGSW_0UlRlU0KssEcJhE3lK0kYwAg>\n <xme:3oqYXxCTfO1VR6X2cPGqVZydn_lOSoLYtk_b_nDsY01lS5U3kWB2FCfWE06SLOc9o\n MDCFa_qUpvNz9eSFA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrkeelgddugeegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeduvdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:3oqYXwFWS3TyneNGo80500kUKo8ojsxXhDxUbXFwsKHMaibeXKUKPQ>\n <xmx:3oqYX5TwJ5_adeoZmM09T7zFYquqX4_-IbbS3ccUgzobgoZDzdse8A>\n <xmx:3oqYX1wr2gJfRRKjstvBEdDEMX-ZsWc0aU9WzMGNBKRrOxT-mK17wQ>\n <xmx:34qYX8n4ME5xgyzJALGL86leKORCmB_Lykvh0g6pygfFRrBhM4TElg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>", "Date": "Tue, 27 Oct 2020 22:01:15 +0100", "Message-Id": "<20201027210115.2529025-16-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201027210115.2529025-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>\n <20201027210115.2529025-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 15/15] mbuf: remove userdata field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As announced in the deprecation note, the field userdata / udata64\nis removed to give more space to the dynamic fields.\n\nThis is how the mbuf layout looks like (pahole-style):\n\nword type name byte size\n 0 void * buf_addr; /* 0 + 8 */\n 1 rte_iova_t buf_iova /* 8 + 8 */\n /* --- RTE_MARKER64 rearm_data; */\n 2 uint16_t data_off; /* 16 + 2 */\n uint16_t refcnt; /* 18 + 2 */\n uint16_t nb_segs; /* 20 + 2 */\n uint16_t port; /* 22 + 2 */\n 3 uint64_t ol_flags; /* 24 + 8 */\n /* --- RTE_MARKER rx_descriptor_fields1; */\n 4 uint32_t union packet_type; /* 32 + 4 */\n uint32_t pkt_len; /* 36 + 4 */\n 5 uint16_t data_len; /* 40 + 2 */\n uint16_t vlan_tci; /* 42 + 2 */\n 5.5 uint64_t union hash; /* 44 + 8 */\n 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */\n uint16_t buf_len; /* 54 + 2 */\n 7 uint64_t timestamp; /* 56 + 8 */\n /* --- RTE_MARKER cacheline1; */\n 8 struct rte_mempool * pool; /* 64 + 8 */\n 9 struct rte_mbuf * next; /* 72 + 8 */\n10 uint64_t union tx_offload; /* 80 + 8 */\n11 uint16_t priv_size; /* 88 + 2 */\n uint16_t timesync; /* 90 + 2 */\n uint32_t seqn; /* 92 + 4 */\n12 struct rte_mbuf_ext_shared_info * shinfo; /* 96 + 8 */\n13 uint64_t dynfield1[3]; /* 104 + 24 */\n16 /* --- END 128 */\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n doc/guides/rel_notes/deprecation.rst | 1 -\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n lib/librte_kni/rte_kni_common.h | 3 +--\n lib/librte_mbuf/rte_mbuf_core.h | 8 +-------\n 4 files changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 2e082499b8..0f6f1df12a 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -87,7 +87,6 @@ Deprecation Notices\n The following static fields will be moved as dynamic:\n \n - ``timestamp``\n- - ``userdata`` / ``udata64``\n - ``seqn``\n \n As a consequence, the layout of the ``struct rte_mbuf`` will be re-arranged,\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex d8ac359e51..3cec526b6a 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -426,6 +426,9 @@ API Changes\n the structures ``rte_mbuf`` and ``rte_mbuf_ext_shared_info``.\n The field ``refcnt`` is remaining from the old unions.\n \n+* mbuf: Removed the unioned fields ``userdata`` and ``udata64``\n+ from the structure ``rte_mbuf``. It is replaced with dynamic fields.\n+\n * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and\n replaced with a private enum in the PCI subsystem.\n \ndiff --git a/lib/librte_kni/rte_kni_common.h b/lib/librte_kni/rte_kni_common.h\nindex 21b477f0aa..0db45e6a24 100644\n--- a/lib/librte_kni/rte_kni_common.h\n+++ b/lib/librte_kni/rte_kni_common.h\n@@ -86,8 +86,7 @@ struct rte_kni_mbuf {\n \tuint16_t data_len; /**< Amount of data in segment buffer. */\n \n \t/* fields on second cache line */\n-\tchar pad3[8] __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE)));\n-\tvoid *pool;\n+\tvoid *pool __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE)));\n \tvoid *next; /**< Physical address of next mbuf in kernel. */\n };\n \ndiff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h\nindex 065d87d28a..a65eaaf692 100644\n--- a/lib/librte_mbuf/rte_mbuf_core.h\n+++ b/lib/librte_mbuf/rte_mbuf_core.h\n@@ -599,12 +599,6 @@ struct rte_mbuf {\n \t/* second cache line - fields only used in slow path or on TX */\n \tRTE_MARKER cacheline1 __rte_cache_min_aligned;\n \n-\tRTE_STD_C11\n-\tunion {\n-\t\tvoid *userdata; /**< Can be used for external metadata */\n-\t\tuint64_t udata64; /**< Allow 8-byte userdata on 32-bit */\n-\t};\n-\n \tstruct rte_mempool *pool; /**< Pool from which mbuf was allocated. */\n \tstruct rte_mbuf *next; /**< Next segment of scattered packet. */\n \n@@ -662,7 +656,7 @@ struct rte_mbuf {\n \t */\n \tstruct rte_mbuf_ext_shared_info *shinfo;\n \n-\tuint64_t dynfield1[2]; /**< Reserved for dynamic fields. */\n+\tuint64_t dynfield1[3]; /**< Reserved for dynamic fields. */\n } __rte_cache_aligned;\n \n /**\n", "prefixes": [ "v3", "15/15" ] }