Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82375/?format=api
{ "id": 82375, "url": "http://patches.dpdk.org/api/patches/82375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-11-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027210115.2529025-11-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027210115.2529025-11-thomas@monjalon.net", "date": "2020-10-27T21:01:10", "name": "[v3,10/15] test/distributor: switch sequence to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "62e362222f73b7908f2a25b6e7d8de7918691ffd", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-11-thomas@monjalon.net/mbox/", "series": [ { "id": 13393, "url": "http://patches.dpdk.org/api/series/13393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13393", "date": "2020-10-27T21:01:00", "name": "remove mbuf userdata", "version": 3, "mbox": "http://patches.dpdk.org/series/13393/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82375/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/82375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 02EE1A04B5;\n\tTue, 27 Oct 2020 22:04:58 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D91156A3;\n\tTue, 27 Oct 2020 22:02:15 +0100 (CET)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A99064CA7\n for <dev@dpdk.org>; Tue, 27 Oct 2020 22:02:08 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 181405C00CC;\n Tue, 27 Oct 2020 17:02:08 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 27 Oct 2020 17:02:08 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 8DD0B328005D;\n Tue, 27 Oct 2020 17:02:06 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=AKn3SixaXOpxs\n GduMvsitiEjbrkJq1l4ZUlqKp6x8vo=; b=Ox5OKvRhOZ/+sW6o3M2vUogAwxZOS\n vnEnBESPWimodB1e/CjxcGFTkrn2hArkg2gjuUDUilr9xK4Tw8DFTLHI0FTniMuF\n cHjsgntIKh97tsXO2Uc8N5ixDLAtHvvFK4xOK3Q4C07qb20EmMFT+dNQXhUGb3Bp\n 9od5b7SQVRlQWLr2ya58myaVq25ihcJK/ETkk6VHR0pT3eA/JmWPI6AV6wFxzIj6\n vpaygWN01bQK+Cv5doKrU+OCKI2YaskMaaT/YHywPcCR4hqjsYkyCDVDgMz99Can\n lmY+WOMGdUPSveirWdBtGJzMmr5TKzTDYtS+xXffKVzRw9AeLPqg5Puqg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=AKn3SixaXOpxsGduMvsitiEjbrkJq1l4ZUlqKp6x8vo=; b=l+b6kygS\n GdFEZmelMuKoLfl2kZVZrVv5Nhu+tEfBbW8qU0KdPVt2pN+9YSaaAdXgPQBcFZ2W\n 8hJEKUSXKXNGy0oMcdrqjcdQKFilQHZoyk27Vb7BgvQmguZ5r25JeOtL6GnStlgM\n ZkmNPyX/XRWarf+h4zKbatSq6vbNl7CxoReaCLGbTfKgvgrJLcX/AB6/+06PB6Sg\n aHa6zDKYmNEYUlQBf74a4omtF9RqRrkx6Jb4lZ9BN8JYYG8ZrtjiDThbAEVyjwk/\n SwhAEUa91QRbp9YPS3nnXbSYOz2aC1vPezrvQ2ZZBvYQKw0IQhWEd4VfdTfO1FR5\n MghAOeCP9RDVWw==" ], "X-ME-Sender": "<xms:z4qYX31mUkdb-U8_6ITqpJP_MsxQpHmxzaA3wZ04fYyw5Gagktwd1g>\n <xme:z4qYX2ENXI9_AIgR1-hvYYfD1KVW40ufRK4o_Q_bsFckgsqaevlVa7dY8_NHzxlfg\n _igNoC_bvPpxEjSGQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrkeelgddugeegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:z4qYX34wAynedEAtJ0A78TpNXCTptQpyWPnOjJXLSpl0Ivq5V4Sn6Q>\n <xmx:z4qYX81F-JBaBJgAJfeytPR3Zj47slRrWMi8N1glDBM7NfGIa_Zdkw>\n <xmx:z4qYX6GqqyNizE3-Zr0KeEEgkP6oUfEiqZHGsavytx3IGdGI6KTbTQ>\n <xmx:0IqYX_5kyrzmdW0ljNaCBtyyW5vhVFKZA8q77LBwsM8a9vZyJ_lOfA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,\n David Hunt <david.hunt@intel.com>", "Date": "Tue, 27 Oct 2020 22:01:10 +0100", "Message-Id": "<20201027210115.2529025-11-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201027210115.2529025-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>\n <20201027210115.2529025-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 10/15] test/distributor: switch sequence to\n\tdynamic mbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The test used the deprecated mbuf field udata64.\nIt is moved to a dynamic field in order to allow removal of udata64.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nTested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_distributor.c | 28 +++++++++++++++++++++++-----\n 1 file changed, 23 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex eb889b91d1..24ee824eef 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -10,6 +10,7 @@\n #include <rte_errno.h>\n #include <rte_mempool.h>\n #include <rte_mbuf.h>\n+#include <rte_mbuf_dyn.h>\n #include <rte_distributor.h>\n #include <rte_string_fns.h>\n \n@@ -17,6 +18,11 @@\n #define BURST 32\n #define BIG_BATCH 1024\n \n+typedef uint32_t seq_dynfield_t;\n+static int seq_dynfield_offset = -1;\n+#define SEQ_FIELD(mbuf) (*RTE_MBUF_DYNFIELD(mbuf, \\\n+\t\tseq_dynfield_offset, seq_dynfield_t *))\n+\n struct worker_params {\n \tchar name[64];\n \tstruct rte_distributor *dist;\n@@ -578,7 +584,7 @@ handle_and_mark_work(void *arg)\n \t\t__atomic_fetch_add(&worker_stats[id].handled_packets, num,\n \t\t\t\t__ATOMIC_RELAXED);\n \t\tfor (i = 0; i < num; i++)\n-\t\t\tbuf[i]->udata64 += id + 1;\n+\t\t\tSEQ_FIELD(buf[i]) += id + 1;\n \t\tnum = rte_distributor_get_pkt(db, id,\n \t\t\t\tbuf, buf, num);\n \t}\n@@ -631,10 +637,10 @@ sanity_mark_test(struct worker_params *wp, struct rte_mempool *p)\n \t\t\t<< shift;\n \t}\n \t/* Assign a sequence number to each packet. The sequence is shifted,\n-\t * so that lower bits of the udate64 will hold mark from worker.\n+\t * so that lower bits will hold mark from worker.\n \t */\n \tfor (i = 0; i < buf_count; i++)\n-\t\tbufs[i]->udata64 = i << seq_shift;\n+\t\tSEQ_FIELD(bufs[i]) = i << seq_shift;\n \n \tcount = 0;\n \tfor (i = 0; i < buf_count/burst; i++) {\n@@ -660,8 +666,8 @@ sanity_mark_test(struct worker_params *wp, struct rte_mempool *p)\n \n \t/* Sort returned packets by sent order (sequence numbers). */\n \tfor (i = 0; i < buf_count; i++) {\n-\t\tseq = returns[i]->udata64 >> seq_shift;\n-\t\tid = returns[i]->udata64 - (seq << seq_shift);\n+\t\tseq = SEQ_FIELD(returns[i]) >> seq_shift;\n+\t\tid = SEQ_FIELD(returns[i]) - (seq << seq_shift);\n \t\tsorted[seq] = id;\n \t}\n \n@@ -805,6 +811,18 @@ test_distributor(void)\n \tstatic struct rte_mempool *p;\n \tint i;\n \n+\tstatic const struct rte_mbuf_dynfield seq_dynfield_desc = {\n+\t\t.name = \"test_distributor_dynfield_seq\",\n+\t\t.size = sizeof(seq_dynfield_t),\n+\t\t.align = __alignof__(seq_dynfield_t),\n+\t};\n+\tseq_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&seq_dynfield_desc);\n+\tif (seq_dynfield_offset < 0) {\n+\t\tprintf(\"Error registering mbuf field\\n\");\n+\t\treturn TEST_FAILED;\n+\t}\n+\n \tif (rte_lcore_count() < 2) {\n \t\tprintf(\"Not enough cores for distributor_autotest, expecting at least 2\\n\");\n \t\treturn TEST_SKIPPED;\n", "prefixes": [ "v3", "10/15" ] }