Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82374/?format=api
{ "id": 82374, "url": "http://patches.dpdk.org/api/patches/82374/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-10-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027210115.2529025-10-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027210115.2529025-10-thomas@monjalon.net", "date": "2020-10-27T21:01:09", "name": "[v3,09/15] net/vmxnet3: switch MSS hint to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f1ea6bbd9c433f2970c1b5e963753d172b6c360c", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201027210115.2529025-10-thomas@monjalon.net/mbox/", "series": [ { "id": 13393, "url": "http://patches.dpdk.org/api/series/13393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13393", "date": "2020-10-27T21:01:00", "name": "remove mbuf userdata", "version": 3, "mbox": "http://patches.dpdk.org/series/13393/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82374/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/82374/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9899A04B5;\n\tTue, 27 Oct 2020 22:04:35 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 004C24F96;\n\tTue, 27 Oct 2020 22:02:10 +0100 (CET)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 217352BF4\n for <dev@dpdk.org>; Tue, 27 Oct 2020 22:02:06 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id C1BAE5C00E2;\n Tue, 27 Oct 2020 17:02:05 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 27 Oct 2020 17:02:05 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id A4CFD3280059;\n Tue, 27 Oct 2020 17:02:04 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=d1fFCseucXepU\n XOo5x5zp3KAoUipq++IKlig9YGnDR0=; b=KgJ4mkdd1yai3UpXmFRhwUzZ3RXvy\n lk/S4RYF/v+lu1kFrnphOQZknQ+sW+QdwhwiwzBXuNV96pgCNmYDK1QEVD2suzYA\n ZrLq0tmU3tq1pz5sD9fA4m9N6jSbFgmxRdPhFAB1qTXi74KjJ29xHyfCtR+V7ilW\n 174tpazC1UQRXHH3wX9iolPptuhDyYicQ4AFSvySgedfYRTay0IMZyMeEVUe1Pnj\n ZTflVQPpybV1eX6jE6xl7WCnSvp4yTDTJ7gmSxZ5vnzbKB4GytEmhXoJleJpStGK\n Xr44EPe9cKoBKFsG+i2WYq/jAY31/IfhRmgKclZWeOW+EjhgYe9TYzTNQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=d1fFCseucXepUXOo5x5zp3KAoUipq++IKlig9YGnDR0=; b=NIE/kkvQ\n UsM6c0dhD/otgm7n5HZ9o19DXkRbZ2uZpRRlcnqjJCbjgHbNet5eYHDci1Mn7Rzi\n /c5B+ii+p923Kq7f3QrxknWuRglWV18XxMwsUaY/T9EZtVh0Xavz3SNwSPe6X2js\n psv54lCVm9MQpwRZlWlsWKGIEHoU4l6C0r4tlNyi6KOhchM+uoK+m+eSybHuuuHb\n njFBt2M57X/qSOTVVjVCYNf3qOxLIUVHfNv0gUzKXsMeDk3SSb3SUzdNpbhJchaL\n nQVz3EJnJodRtHT2LgcC82l9pjqdAdjJIZ5aqGpov/RzI/uiuhbjcbu42rrlt0rm\n o2gPqYG8XA/FXg==" ], "X-ME-Sender": "<xms:zYqYX8TA_zH0obtnF5FeL8LaoDnWP6xrrK9l9ebS4wChOk5moJgS5Q>\n <xme:zYqYX5xHuwX5ED7OG7kMJ06TVE00hqxJm51ulnYbBRlRqM2HjihfmexmCT67sBSpL\n xgDfhsUPePUK6T5xQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrkeelgddugeegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:zYqYX539Q_Zgq2ytSD3DE-zS1LxE-zxBuLxRmqaWiO9fITl_d4_crQ>\n <xmx:zYqYXwB2bSjYgdCgTHbY8gXA0YAIozUlTQgYULwS5RO7TV1UMca1Mg>\n <xmx:zYqYX1gC45KK4jjUBoROHYhjX_ismK6MbrrMlqiv5tlga868asnx8g>\n <xmx:zYqYXzYHa3ZW1LskIltY_CWLRLPVGcWNLkBkizH9Mz7Tx-3TrF9v4w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Yong Wang <yongwang@vmware.com>", "Date": "Tue, 27 Oct 2020 22:01:09 +0100", "Message-Id": "<20201027210115.2529025-10-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201027210115.2529025-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>\n <20201027210115.2529025-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 09/15] net/vmxnet3: switch MSS hint to dynamic\n\tmbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The segment count, used for MSS guess,\nwas stored in the deprecated mbuf field udata64.\nIt is moved to a dynamic field in order to allow removal of udata64.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 15 +++++++++++++++\n drivers/net/vmxnet3/vmxnet3_ethdev.h | 6 ++++++\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 9 +++++----\n 3 files changed, 26 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 6920ab568c..23a2ebbefa 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -59,6 +59,8 @@\n \t DEV_RX_OFFLOAD_JUMBO_FRAME | \\\n \t DEV_RX_OFFLOAD_RSS_HASH)\n \n+int vmxnet3_segs_dynfield_offset = -1;\n+\n static int eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev);\n static int eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev);\n static int vmxnet3_dev_configure(struct rte_eth_dev *dev);\n@@ -233,6 +235,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \tstruct vmxnet3_hw *hw = eth_dev->data->dev_private;\n \tuint32_t mac_hi, mac_lo, ver;\n \tstruct rte_eth_link link;\n+\tstatic const struct rte_mbuf_dynfield vmxnet3_segs_dynfield_desc = {\n+\t\t.name = VMXNET3_SEGS_DYNFIELD_NAME,\n+\t\t.size = sizeof(vmxnet3_segs_dynfield_t),\n+\t\t.align = __alignof__(vmxnet3_segs_dynfield_t),\n+\t};\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -242,6 +249,14 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \teth_dev->tx_pkt_prepare = vmxnet3_prep_pkts;\n \tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n+\t/* extra mbuf field is required to guess MSS */\n+\tvmxnet3_segs_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&vmxnet3_segs_dynfield_desc);\n+\tif (vmxnet3_segs_dynfield_offset < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Cannot register mbuf field.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n \t/*\n \t * for secondary processes, we don't initialize any further as primary\n \t * has already done this work.\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h\nindex dd685b02b7..e19718ce64 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h\n@@ -193,4 +193,10 @@ uint16_t vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n uint16_t vmxnet3_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tuint16_t nb_pkts);\n \n+#define VMXNET3_SEGS_DYNFIELD_NAME \"rte_net_vmxnet3_dynfield_segs\"\n+typedef uint8_t vmxnet3_segs_dynfield_t;\n+extern int vmxnet3_segs_dynfield_offset;\n+#define VMXNET3_SEGS_DYNFIELD(mbuf) (*RTE_MBUF_DYNFIELD(rxm, \\\n+\t\tvmxnet3_segs_dynfield_offset, vmxnet3_segs_dynfield_t *))\n+\n #endif /* _VMXNET3_ETHDEV_H_ */\ndiff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex e10f9ee870..2b0e2e6f19 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -674,6 +674,7 @@ vmxnet3_guess_mss(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \tstruct rte_ipv6_hdr *ipv6_hdr;\n \tstruct rte_tcp_hdr *tcp_hdr;\n \tchar *ptr;\n+\tuint8_t segs;\n \n \tRTE_ASSERT(rcd->tcp);\n \n@@ -710,9 +711,9 @@ vmxnet3_guess_mss(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \ttcp_hdr = (struct rte_tcp_hdr *)(ptr + hlen);\n \thlen += (tcp_hdr->data_off & 0xf0) >> 2;\n \n-\tif (rxm->udata64 > 1)\n-\t\treturn (rte_pktmbuf_pkt_len(rxm) - hlen +\n-\t\t\t\trxm->udata64 - 1) / rxm->udata64;\n+\tsegs = VMXNET3_SEGS_DYNFIELD(rxm);\n+\tif (segs > 1)\n+\t\treturn (rte_pktmbuf_pkt_len(rxm) - hlen + segs - 1) / segs;\n \telse\n \t\treturn hw->mtu - hlen + sizeof(struct rte_ether_hdr);\n }\n@@ -737,7 +738,7 @@ vmxnet3_rx_offload(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \t\t\t\t\t(const Vmxnet3_RxCompDescExt *)rcd;\n \n \t\t\trxm->tso_segsz = rcde->mss;\n-\t\t\trxm->udata64 = rcde->segCnt;\n+\t\t\tVMXNET3_SEGS_DYNFIELD(rxm) = rcde->segCnt;\n \t\t\tol_flags |= PKT_RX_LRO;\n \t\t}\n \t} else { /* Offloads set in eop */\n", "prefixes": [ "v3", "09/15" ] }