Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82160/?format=api
{ "id": 82160, "url": "http://patches.dpdk.org/api/patches/82160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201026052105.1561859-16-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201026052105.1561859-16-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201026052105.1561859-16-thomas@monjalon.net", "date": "2020-10-26T05:21:05", "name": "[15/15] mbuf: remove userdata field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f810ff9d649265fa6130fd137c9830c970227d97", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201026052105.1561859-16-thomas@monjalon.net/mbox/", "series": [ { "id": 13308, "url": "http://patches.dpdk.org/api/series/13308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13308", "date": "2020-10-26T05:20:50", "name": "remove mbuf userdata", "version": 1, "mbox": "http://patches.dpdk.org/series/13308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82160/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/82160/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2471EA04B5;\n\tMon, 26 Oct 2020 06:26:35 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D3225958;\n\tMon, 26 Oct 2020 06:22:03 +0100 (CET)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ED3E15592\n for <dev@dpdk.org>; Mon, 26 Oct 2020 06:21:54 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id A38635C0117;\n Mon, 26 Oct 2020 01:21:53 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 26 Oct 2020 01:21:53 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 857F13064674;\n Mon, 26 Oct 2020 01:21:52 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=I51xx7LZrN7pC\n A5ICPeW4Ghz81RXu1CKz3JMTdSTjag=; b=iN2gN88q12exL6ubSnrPf0aXJAVhr\n r22Q+e4AeK8YQ12jvreKL7rRTrRRefA53fOiN4WUGDpIdwVXTwW44xdb4YYQ4y7G\n 9zAuXe3VWVx0r32SqA4msEVKdzfTuUj4o6O7LdCp5LlBDiDjaaMNENK8AQqceWyF\n NA6Nz1XMd52CoBWmJ7EauJGQCKnozE8q06FMis21oPk22Y6NC0LtZ4qiPRSLZTQE\n CGfEHJH967m+50DV23YrNbjhgmedf636REAd7hGoecgFCZo2JRjXD2h0VTaH+1jS\n 3Ep/8mW5H6SHJe48utsiznOVhiYpIPv/ohdC8kop2IdPP5PoBwPwHnhrA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=I51xx7LZrN7pCA5ICPeW4Ghz81RXu1CKz3JMTdSTjag=; b=aTWtSk0g\n WUdmXd20JrG4WXZq2+GL8MWfPW4X4YCUHHuKfwmGwLRksd7ed8HW/pruIb+w5gWb\n qILkgJyqizBCs/2v0Dtur9dRrSy0HF2g1ZpLS7ZicUORR0EWh8yxRkhhx6pW0Hyr\n prDfvJJRG2eITEVK63v2l6irG0cy6Pj6eFnmO8FDIt31IwB/L173jjm31cEf3Rc8\n FlNj7BuTR6MWms8ze13Z+KWaueDRr0OwEdSZg55GFl/NimRYmc0NQ8WIKs7Apat9\n OlaVrJ3pWClrTEdbpmpneCpB7irHT1or/e2ziNJASfK/sXaeJLH8GirWq2m1vhr7\n 2oF6Pu0HUHXAvQ==" ], "X-ME-Sender": "<xms:8VyWX9LV1i80rlTkm3Jhs01LLQ0J_wSl2kFA6c_I8eWZHROWVW62uw>\n <xme:8VyWX5LSIeRVBkIDLyX5zhQfVVtrN0TloP4Kt8PI8UYValf2xbKrSmqQ0RXdvqdAZ\n HjHhEOr2CQhWOv4Iw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrkeehgdekgecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepuddvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:8VyWX1ssjjcZtaU5yqrsKxt2en-MwwTMexGO6o8VA71HKBB8d-u3XA>\n <xmx:8VyWX-YQKnbfFJmr1XnzcyQUuVN10VvB6Oa0yCfNlkhO8pNK53tEbQ>\n <xmx:8VyWX0aaY1_OMCcQrrrLtRVKQWzx2o3NnA2GrBV4WzRV421GXRWCiQ>\n <xmx:8VyWX5NTzSE99Ckn51uXKuNlaSPlcvmlH64rXx6tw4xs5HJrsMkGeQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>", "Date": "Mon, 26 Oct 2020 06:21:05 +0100", "Message-Id": "<20201026052105.1561859-16-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201026052105.1561859-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 15/15] mbuf: remove userdata field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As announced in the deprecation note, the field userdata / udata64\nis removed to give more space to the dynamic fields.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/rel_notes/deprecation.rst | 1 -\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n lib/librte_kni/rte_kni_common.h | 3 +--\n lib/librte_mbuf/rte_mbuf_core.h | 8 +-------\n 4 files changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 2e082499b8..0f6f1df12a 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -87,7 +87,6 @@ Deprecation Notices\n The following static fields will be moved as dynamic:\n \n - ``timestamp``\n- - ``userdata`` / ``udata64``\n - ``seqn``\n \n As a consequence, the layout of the ``struct rte_mbuf`` will be re-arranged,\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex d8ac359e51..3cec526b6a 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -426,6 +426,9 @@ API Changes\n the structures ``rte_mbuf`` and ``rte_mbuf_ext_shared_info``.\n The field ``refcnt`` is remaining from the old unions.\n \n+* mbuf: Removed the unioned fields ``userdata`` and ``udata64``\n+ from the structure ``rte_mbuf``. It is replaced with dynamic fields.\n+\n * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and\n replaced with a private enum in the PCI subsystem.\n \ndiff --git a/lib/librte_kni/rte_kni_common.h b/lib/librte_kni/rte_kni_common.h\nindex 21b477f0aa..0db45e6a24 100644\n--- a/lib/librte_kni/rte_kni_common.h\n+++ b/lib/librte_kni/rte_kni_common.h\n@@ -86,8 +86,7 @@ struct rte_kni_mbuf {\n \tuint16_t data_len; /**< Amount of data in segment buffer. */\n \n \t/* fields on second cache line */\n-\tchar pad3[8] __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE)));\n-\tvoid *pool;\n+\tvoid *pool __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE)));\n \tvoid *next; /**< Physical address of next mbuf in kernel. */\n };\n \ndiff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h\nindex 065d87d28a..a65eaaf692 100644\n--- a/lib/librte_mbuf/rte_mbuf_core.h\n+++ b/lib/librte_mbuf/rte_mbuf_core.h\n@@ -599,12 +599,6 @@ struct rte_mbuf {\n \t/* second cache line - fields only used in slow path or on TX */\n \tRTE_MARKER cacheline1 __rte_cache_min_aligned;\n \n-\tRTE_STD_C11\n-\tunion {\n-\t\tvoid *userdata; /**< Can be used for external metadata */\n-\t\tuint64_t udata64; /**< Allow 8-byte userdata on 32-bit */\n-\t};\n-\n \tstruct rte_mempool *pool; /**< Pool from which mbuf was allocated. */\n \tstruct rte_mbuf *next; /**< Next segment of scattered packet. */\n \n@@ -662,7 +656,7 @@ struct rte_mbuf {\n \t */\n \tstruct rte_mbuf_ext_shared_info *shinfo;\n \n-\tuint64_t dynfield1[2]; /**< Reserved for dynamic fields. */\n+\tuint64_t dynfield1[3]; /**< Reserved for dynamic fields. */\n } __rte_cache_aligned;\n \n /**\n", "prefixes": [ "15/15" ] }