Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82154/?format=api
{ "id": 82154, "url": "http://patches.dpdk.org/api/patches/82154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201026052105.1561859-10-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201026052105.1561859-10-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201026052105.1561859-10-thomas@monjalon.net", "date": "2020-10-26T05:20:59", "name": "[09/15] net/vmxnet3: switch MSS hint to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e95a6d88f969d1ff94dea4a3910cdef94d072cc7", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201026052105.1561859-10-thomas@monjalon.net/mbox/", "series": [ { "id": 13308, "url": "http://patches.dpdk.org/api/series/13308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13308", "date": "2020-10-26T05:20:50", "name": "remove mbuf userdata", "version": 1, "mbox": "http://patches.dpdk.org/series/13308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82154/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/82154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C7BAA04B5;\n\tMon, 26 Oct 2020 06:24:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CAB162E8F;\n\tMon, 26 Oct 2020 06:21:49 +0100 (CET)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 238313421\n for <dev@dpdk.org>; Mon, 26 Oct 2020 06:21:41 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id CA30F5C0100;\n Mon, 26 Oct 2020 01:21:40 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 26 Oct 2020 01:21:40 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id B65143064610;\n Mon, 26 Oct 2020 01:21:39 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=fzsKl0yln40TA\n ajsFvg+NAcG2zNL8nTOFrxFCvNpBJs=; b=kGRFOr4veqiV88O7lQ8uoRpPD+g6u\n wTOZtbTJaThFxOOCQsNUS5iGcIMwUpZbYekGltDWY/8bz6FfyjzzDQTSptOqogZi\n Qh4rkx1MSvRm0kolQpiVq4DfgT/f4Qg1ycpVwIW3eX2tbMYRhpZ35HtQPWDnOeN5\n wd4Ki2qtbhame2DAPekn2xeoLT0FplMDLdMjo5VmKUE/8wFG3iumw31jsCDhgYD3\n xF1bQ/eF4871BfNgZTUH7NbiUnowMASU8tyMcfUwXTJamSt6V2OxtRosAcBWRfLu\n Q9Fci2q43EIIufp3+HP62XhQg9gUvYIhUTjDFTQj8FmgTtQPdxfdtAu4A==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=fzsKl0yln40TAajsFvg+NAcG2zNL8nTOFrxFCvNpBJs=; b=JJkCYniV\n mThypwdt9wortS99+/glMdJ46VsN41W/+/cX+mEEVCnm6+LWEydJ5waNlLoPM9GF\n nhXyZ6zPDpcd7olE8+2UIZBW1gewF1giiRBi1QpHpC7VTyXUkrYuCURHl7GF2TnC\n d29+L+gGcTwV4Jpqp6dC3AI0/mxQivXOq9rNQ507WQFb/P23/Ih8xfxXDaQCAV0o\n oowTAaJBI5TwEmt24Ea5mpJr/zKQmH2IBoqnFxZo6tx8HhhFo6DZrmDj3yB1Iocm\n 95WDJ8ccMl70gdXElTkPxPVqR8VQIiPLVnJv/4P5QpG3nFI2nlwp3tlRcvT5mgtx\n gZ8oCP+ZWIeoFA==" ], "X-ME-Sender": "<xms:5FyWX8Id1v58O47ytM8ivSSATwAWiEpv5LGlVfhAMJyutHVsCN7FFQ>\n <xme:5FyWX8ITtdLkcnT755te-MkBcCde3EVLEK6GGOIyLBGQXksRRgYEUqnyRVpkAoiTT\n jVqw3rzV8FBYRCzLg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrkeehgdekgecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepjeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:5FyWX8sNEtHp7dBixTfcZULqO15o7AMaeW0z1zuSG5yU4GAxpB4SOA>\n <xmx:5FyWX5atG0NQhMeGviapBd9zmT8lORJOlrTTZSDaNiWEJCTZcYsfjQ>\n <xmx:5FyWXzZxSccgAoiqXUVSmH9dC6BAsYZjVbGXR6ltah9gsiJ5o_W_HA>\n <xmx:5FyWX-yKvRdEu4cxxkGaECcsaErjikRPfPyAaHUELlW4SOGNe6Q76w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Yong Wang <yongwang@vmware.com>", "Date": "Mon, 26 Oct 2020 06:20:59 +0100", "Message-Id": "<20201026052105.1561859-10-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201026052105.1561859-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 09/15] net/vmxnet3: switch MSS hint to dynamic\n\tmbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The segment count, used for MSS guess,\nwas stored in the deprecated mbuf field udata64.\nIt is moved to a dynamic field in order to allow removal of udata64.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 15 +++++++++++++++\n drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 10 ++++++----\n 3 files changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 6920ab568c..eeb1152b61 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -59,6 +59,8 @@\n \t DEV_RX_OFFLOAD_JUMBO_FRAME | \\\n \t DEV_RX_OFFLOAD_RSS_HASH)\n \n+int vmxnet3_segs_dynfield_offset;\n+\n static int eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev);\n static int eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev);\n static int vmxnet3_dev_configure(struct rte_eth_dev *dev);\n@@ -233,6 +235,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \tstruct vmxnet3_hw *hw = eth_dev->data->dev_private;\n \tuint32_t mac_hi, mac_lo, ver;\n \tstruct rte_eth_link link;\n+\tstatic const struct rte_mbuf_dynfield vmxnet3_segs_dynfield_desc = {\n+\t\t.name = \"rte_net_vmxnet3_dynfield_segs\",\n+\t\t.size = sizeof(uint8_t),\n+\t\t.align = __alignof__(uint8_t),\n+\t};\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -242,6 +249,14 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \teth_dev->tx_pkt_prepare = vmxnet3_prep_pkts;\n \tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n+\t/* extra mbuf field is required to guess MSS */\n+\tvmxnet3_segs_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&vmxnet3_segs_dynfield_desc);\n+\tif (vmxnet3_segs_dynfield_offset < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Cannot register mbuf field.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n \t/*\n \t * for secondary processes, we don't initialize any further as primary\n \t * has already done this work.\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h\nindex dd685b02b7..5730e94d50 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h\n@@ -193,4 +193,6 @@ uint16_t vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n uint16_t vmxnet3_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tuint16_t nb_pkts);\n \n+extern int vmxnet3_segs_dynfield_offset;\n+\n #endif /* _VMXNET3_ETHDEV_H_ */\ndiff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex e10f9ee870..6655622f94 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -674,6 +674,7 @@ vmxnet3_guess_mss(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \tstruct rte_ipv6_hdr *ipv6_hdr;\n \tstruct rte_tcp_hdr *tcp_hdr;\n \tchar *ptr;\n+\tuint8_t segs;\n \n \tRTE_ASSERT(rcd->tcp);\n \n@@ -710,9 +711,9 @@ vmxnet3_guess_mss(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \ttcp_hdr = (struct rte_tcp_hdr *)(ptr + hlen);\n \thlen += (tcp_hdr->data_off & 0xf0) >> 2;\n \n-\tif (rxm->udata64 > 1)\n-\t\treturn (rte_pktmbuf_pkt_len(rxm) - hlen +\n-\t\t\t\trxm->udata64 - 1) / rxm->udata64;\n+\tsegs = *RTE_MBUF_DYNFIELD(rxm, vmxnet3_segs_dynfield_offset, uint8_t *);\n+\tif (segs > 1)\n+\t\treturn (rte_pktmbuf_pkt_len(rxm) - hlen + segs - 1) / segs;\n \telse\n \t\treturn hw->mtu - hlen + sizeof(struct rte_ether_hdr);\n }\n@@ -737,7 +738,8 @@ vmxnet3_rx_offload(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,\n \t\t\t\t\t(const Vmxnet3_RxCompDescExt *)rcd;\n \n \t\t\trxm->tso_segsz = rcde->mss;\n-\t\t\trxm->udata64 = rcde->segCnt;\n+\t\t\t*RTE_MBUF_DYNFIELD(rxm, vmxnet3_segs_dynfield_offset,\n+\t\t\t\t\tuint8_t *) = rcde->segCnt;\n \t\t\tol_flags |= PKT_RX_LRO;\n \t\t}\n \t} else { /* Offloads set in eop */\n", "prefixes": [ "09/15" ] }