Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81623/?format=api
{ "id": 81623, "url": "http://patches.dpdk.org/api/patches/81623/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201020215538.59242-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201020215538.59242-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201020215538.59242-6-ajit.khaparde@broadcom.com", "date": "2020-10-20T21:55:32", "name": "[v2,05/11] net/bnxt: fix infinite loop in flow query count", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dca201ee42372785e184656f700aca3ffdecfb3d", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201020215538.59242-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 13155, "url": "http://patches.dpdk.org/api/series/13155/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13155", "date": "2020-10-20T21:55:27", "name": "bnxt fixes and enhancements to TRUFLOW support", "version": 2, "mbox": "http://patches.dpdk.org/series/13155/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81623/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81623/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FB72A04DD;\n\tTue, 20 Oct 2020 23:57:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0DECAACB3;\n\tTue, 20 Oct 2020 23:55:59 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 178C5AC99\n for <dev@dpdk.org>; Tue, 20 Oct 2020 23:55:51 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id y14so194906pfp.13\n for <dev@dpdk.org>; Tue, 20 Oct 2020 14:55:50 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id e6sm24113pfn.190.2020.10.20.14.55.47\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 20 Oct 2020 14:55:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=HGS6cSXcgx+V5pR7O2CipxpXsnZNFCQtRQx9oM6HtOc=;\n b=OvwGn/gOom+825WOz1wX8pvB0T24GYqhb5aYnKsJyMvavWWRvL11GkyJQokUahCv1M\n iP5VLRig4azGjXoJGqckudGdAfS/WeE9t+8fdOolrKQ2dc7JptOn4SZ8pl+sgDXrrka8\n MBzVTpcVfpBLkpiuBH2AmqkEA3CutpoQ1lTls=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=HGS6cSXcgx+V5pR7O2CipxpXsnZNFCQtRQx9oM6HtOc=;\n b=frVxzAxKgjXSwCK/cPUTeOIPpRSYosTFH/bCCOzUlgotWV58Zl15w9ltvoaG78keQb\n 44Gvf+/s/G4Fh743IwyVouEWD2tTdep8QqqyTBcsC5hVsCj+/RUVAiSjY6wrBqTHKiSP\n Oj4r7hGuMx4vXfnpA290JuRAA5hbqNeIYVzhcXW9BjghPIhNFl7la1B8bkxRGsL/c9qE\n SLg4xOgGM+7srbEg8ljGDguzKwCLC+UQjWTkwN1CgDYfcA2VLvkwk4Wz57NLcf+gDGZu\n tvTjcQtpeu055Sx8hPMv2FTlvF7wzA1lJ2xnMdrG1O2659hYBDx7/Nulwh+IZRI2xCni\n lxRg==", "X-Gm-Message-State": "AOAM5300wZph6VbFOuc9JEIBR5iLXlvzYHmK/5uG5KPemD7CdINvEz+0\n hCIinIlkl0OrWHFzSSm8bmHKg4bcoqmEXNy+/DSp9XDxoHMSRCBWXzWAQCfse8dWiEEhRey3RBQ\n BIEDCyN8YvxVcgtbdZHffCCsTmavlVUiHmC8i9V8HRqGuB118K5Mn3DoxHuRzA1TZVA==", "X-Google-Smtp-Source": "\n ABdhPJxKHPYOZVCVXebuGgKkoUo6JFX1KATe+MQl+vBpiQU5gdDw4KYltQ3dQsaY+ynjzXvKS4MuWg==", "X-Received": "by 2002:a63:e57:: with SMTP id 23mr308895pgo.278.1603230948681;\n Tue, 20 Oct 2020 14:55:48 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Tue, 20 Oct 2020 14:55:32 -0700", "Message-Id": "<20201020215538.59242-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201020215538.59242-1-ajit.khaparde@broadcom.com>", "References": "\n <1602916089-18576-1-git-send-email-venkatkumar.duvvuru@broadcom.com>\n <20201020215538.59242-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "Content-Transfer-Encoding": "8bit", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH v2 05/11] net/bnxt: fix infinite loop in flow\n\tquery count", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\n`nxt_resource_idx` could be zero in some cases which is invalid and\nshould be part of the while loop condition. Also synchronize access to\nthe flow db using the fdb_lock\n\nFixes: 306c2d28e247 (\"net/bnxt: support count action in flow query\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 51 +++++++++++++++-------------\n 1 file changed, 27 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\nindex 051ebac04..41736a80d 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n@@ -559,6 +559,9 @@ int ulp_fc_mgr_query_count_get(struct bnxt_ulp_context *ctxt,\n \tif (!ulp_fc_info)\n \t\treturn -ENODEV;\n \n+\tif (bnxt_ulp_cntxt_acquire_fdb_lock(ctxt))\n+\t\treturn -EIO;\n+\n \tdo {\n \t\trc = ulp_flow_db_resource_get(ctxt,\n \t\t\t\t\t BNXT_ULP_FDB_TYPE_REGULAR,\n@@ -575,35 +578,35 @@ int ulp_fc_mgr_query_count_get(struct bnxt_ulp_context *ctxt,\n \t\t\tbreak;\n \t\t}\n \n-\t} while (!rc);\n+\t} while (!rc && nxt_resource_index);\n+\n+\tbnxt_ulp_cntxt_release_fdb_lock(ctxt);\n \n-\tif (rc)\n+\tif (rc || !found_cntr_resource)\n \t\treturn rc;\n \n-\tif (found_cntr_resource) {\n-\t\tdir = params.direction;\n-\t\thw_cntr_id = params.resource_hndl;\n-\t\tsw_cntr_idx = hw_cntr_id -\n-\t\t\t\tulp_fc_info->shadow_hw_tbl[dir].start_idx;\n-\t\tsw_acc_tbl_entry = &ulp_fc_info->sw_acc_tbl[dir][sw_cntr_idx];\n-\t\tif (params.resource_sub_type ==\n+\tdir = params.direction;\n+\thw_cntr_id = params.resource_hndl;\n+\tsw_cntr_idx = hw_cntr_id -\n+\t\tulp_fc_info->shadow_hw_tbl[dir].start_idx;\n+\tsw_acc_tbl_entry = &ulp_fc_info->sw_acc_tbl[dir][sw_cntr_idx];\n+\tif (params.resource_sub_type ==\n \t\t\tBNXT_ULP_RESOURCE_SUB_TYPE_INDEX_TYPE_INT_COUNT) {\n-\t\t\tpthread_mutex_lock(&ulp_fc_info->fc_lock);\n-\t\t\tif (sw_acc_tbl_entry->pkt_count) {\n-\t\t\t\tcount->hits_set = 1;\n-\t\t\t\tcount->bytes_set = 1;\n-\t\t\t\tcount->hits = sw_acc_tbl_entry->pkt_count;\n-\t\t\t\tcount->bytes = sw_acc_tbl_entry->byte_count;\n-\t\t\t}\n-\t\t\tif (count->reset) {\n-\t\t\t\tsw_acc_tbl_entry->pkt_count = 0;\n-\t\t\t\tsw_acc_tbl_entry->byte_count = 0;\n-\t\t\t}\n-\t\t\tpthread_mutex_unlock(&ulp_fc_info->fc_lock);\n-\t\t} else {\n-\t\t\t/* TBD: Handle External counters */\n-\t\t\trc = -EINVAL;\n+\t\tpthread_mutex_lock(&ulp_fc_info->fc_lock);\n+\t\tif (sw_acc_tbl_entry->pkt_count) {\n+\t\t\tcount->hits_set = 1;\n+\t\t\tcount->bytes_set = 1;\n+\t\t\tcount->hits = sw_acc_tbl_entry->pkt_count;\n+\t\t\tcount->bytes = sw_acc_tbl_entry->byte_count;\n \t\t}\n+\t\tif (count->reset) {\n+\t\t\tsw_acc_tbl_entry->pkt_count = 0;\n+\t\t\tsw_acc_tbl_entry->byte_count = 0;\n+\t\t}\n+\t\tpthread_mutex_unlock(&ulp_fc_info->fc_lock);\n+\t} else {\n+\t\t/* TBD: Handle External counters */\n+\t\trc = -EINVAL;\n \t}\n \n \treturn rc;\n", "prefixes": [ "v2", "05/11" ] }