Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81602/?format=api
{ "id": 81602, "url": "http://patches.dpdk.org/api/patches/81602/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201020152052.389446-4-amorenoz@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201020152052.389446-4-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201020152052.389446-4-amorenoz@redhat.com", "date": "2020-10-20T15:20:52", "name": "[v2,3/3] virtio-user: set status on virtio-user reconnect", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "488b9985c1c29b2b14ba912e50e534c747251969", "submitter": { "id": 1397, "url": "http://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201020152052.389446-4-amorenoz@redhat.com/mbox/", "series": [ { "id": 13150, "url": "http://patches.dpdk.org/api/series/13150/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13150", "date": "2020-10-20T15:20:49", "name": "virtio-user: fix virtio-user server mode", "version": 2, "mbox": "http://patches.dpdk.org/series/13150/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81602/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2E8F1A04DC;\n\tTue, 20 Oct 2020 17:22:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 62926BE27;\n\tTue, 20 Oct 2020 17:21:14 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id 527EABCEB\n for <dev@dpdk.org>; Tue, 20 Oct 2020 17:21:11 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-130-T0yG9FFjNC-76CwBy5UHNQ-1; Tue, 20 Oct 2020 11:21:07 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3721879515;\n Tue, 20 Oct 2020 15:21:05 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-112-202.ams2.redhat.com\n [10.36.112.202])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 303625577A;\n Tue, 20 Oct 2020 15:21:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1603207269;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mECSGPlM/k1rwIVi8bx1p8Gw94CkLMjqpMAflz15RbM=;\n b=JULmIgEr0TnoTxbjkpj2zqPpA1lQ8OQulo5TAlAm14IPxKUShEDNW2WryLDZzXzhhl+tC7\n qJDN5w3G8z1kX2ybWwYspI19rH6R5Q4kGyh/KL26FTf0Z4bjS6YwAQExfosA68i1K+4Spl\n tNmrF1txO71jyE2f4DJiblXRUP44hpI=", "X-MC-Unique": "T0yG9FFjNC-76CwBy5UHNQ-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "yinan.wang@intel.com, patrick.fu@intel.com, amorenoz@redhat.com,\n maxime.coquelin@redhat.com, stable@dpdk.org,\n Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Tue, 20 Oct 2020 17:20:52 +0200", "Message-Id": "<20201020152052.389446-4-amorenoz@redhat.com>", "In-Reply-To": "<20201020152052.389446-1-amorenoz@redhat.com>", "References": "<20201020152052.389446-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user\n\treconnect", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Newer vhost-user backends will rely on SET_STATUS to start the device\nso this required to support them.\n\nFixes: 57912824615f (\"net/virtio-user: support vhost status setting\")\nCc: maxime.coquelin@redhat.com\nCc: stable@dpdk.org\n\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex e870fb2ff..d8bea4537 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -78,6 +78,13 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev)\n \t\treturn -1;\n \n \tdev->vhostfd = connectfd;\n+\n+\tvtpci_reset(hw);\n+\n+\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_ACK);\n+\n+\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_DRIVER);\n+\n \tif (dev->ops->send_request(dev, VHOST_USER_GET_FEATURES,\n \t\t\t\t &dev->device_features) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"get_features failed: %s\",\n@@ -111,6 +118,8 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev)\n \n \tdev->features &= dev->device_features;\n \n+\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_FEATURES_OK);\n+\n \t/* For packed ring, resetting queues is required in reconnection. */\n \tif (vtpci_packed_queue(hw) &&\n \t (vtpci_get_status(hw) & VIRTIO_CONFIG_STATUS_DRIVER_OK)) {\n@@ -119,8 +128,9 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev)\n \t\tvirtio_user_reset_queues_packed(eth_dev);\n \t}\n \n-\tret = virtio_user_start_device(dev);\n-\tif (ret < 0)\n+\t/* Start the device */\n+\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_DRIVER_OK);\n+\tif (!dev->started)\n \t\treturn -1;\n \n \tif (dev->queue_pairs > 1) {\n", "prefixes": [ "v2", "3/3" ] }