Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81523/?format=api
{ "id": 81523, "url": "http://patches.dpdk.org/api/patches/81523/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603185222-14831-22-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603185222-14831-22-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603185222-14831-22-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T09:13:01", "name": "[v2,21/62] net/sfc: support flow action PHY PORT in MAE backend", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f52cbbe239fbdd497e5cdc2d326b19dff104b53", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603185222-14831-22-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13137, "url": "http://patches.dpdk.org/api/series/13137/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13137", "date": "2020-10-20T09:12:44", "name": "net/sfc: support flow API transfer rules", "version": 2, "mbox": "http://patches.dpdk.org/series/13137/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81523/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0521CA04DD;\n\tTue, 20 Oct 2020 11:24:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7E4FC9A2;\n\tTue, 20 Oct 2020 11:14:39 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 4004EC80E\n for <dev@dpdk.org>; Tue, 20 Oct 2020 11:14:10 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 1032260086 for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:10 +0000 (UTC)", "from us4-mdac16-63.ut7.mdlocal (unknown [10.7.66.62])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1026C2009A\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:10 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.41])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 95E931C004F\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:09 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 4961C4C0071\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:09 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 10:14:00 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 10:14:00 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K9E059028400;\n Tue, 20 Oct 2020 10:14:00 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id E98861613AB;\n Tue, 20 Oct 2020 10:13:59 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 10:13:01 +0100", "Message-ID": "<1603185222-14831-22-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>\n <1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-0.344200-8.000000-10", "X-TMASE-MatchedRID": "5A8hgJTIs0fbiFIWuP4ar6iUivh0j2Pv6VTG9cZxEjIGmHr1eMxt2UAc\n 6DyoS2rIEcE+LOiKuIt27cZtoykdFo9y28rShcKqcvVMncWChZnLvfc3C6SWwvYENPLTaMhvj78\n +1uscT5Knpp75HenHO1SCmfT2v3te3qZ3A4FG8d0Pe5gzF3TVtxisibaaFAhmmyiLZetSf8mfop\n 0ytGwvXiq2rl3dzGQ1LyUV9bAUSPxiq5o2dm5vq4dBBnrMGv35arek3NZtcgYM3B3UjkTO20iUx\n Z5MSMJsl8ibHv3/cAp1BkkntnUIO7cEV2SxXhYSsaGCK1PGkPg4oGQUCbwY5Q+g7mdwjo656FtD\n ZCmYBJ3KTLw/lNgw8g==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--0.344200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603185250-DF44bh1ViLLM", "X-PPE-DISP": "1603185250;DF44bh1ViLLM", "Subject": "[dpdk-dev] [PATCH v2 21/62] net/sfc: support flow action PHY PORT\n\tin MAE backend", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nThe action handler will use MAE action DELIVER with\nMPORT of a given physical port.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/sfc_efx.rst | 4 ++++\n drivers/net/sfc/sfc_mae.c | 40 +++++++++++++++++++++++++++++++++----\n 2 files changed, 40 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 65d52d5551..e367ddd6e6 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -194,6 +194,10 @@ Supported pattern items (***transfer*** rules):\n \n - ETH\n \n+Supported actions (***transfer*** rules):\n+\n+- PHY_PORT\n+\n Validating flow rules depends on the firmware variant.\n \n The :ref:`flow_isolated_mode` is supported.\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 95f8cffc27..057eef537b 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -391,18 +391,50 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n }\n \n static int\n-sfc_mae_rule_parse_action(const struct rte_flow_action *action,\n-\t\t\t __rte_unused efx_mae_actions_t *spec,\n+sfc_mae_rule_parse_action_phy_port(struct sfc_adapter *sa,\n+\t\t\t\t const struct rte_flow_action_phy_port *conf,\n+\t\t\t\t efx_mae_actions_t *spec)\n+{\n+\tefx_mport_sel_t mport;\n+\tuint32_t phy_port;\n+\tint rc;\n+\n+\tif (conf->original != 0)\n+\t\tphy_port = efx_nic_cfg_get(sa->nic)->enc_assigned_port;\n+\telse\n+\t\tphy_port = conf->index;\n+\n+\trc = efx_mae_mport_by_phy_port(phy_port, &mport);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\treturn efx_mae_action_set_populate_deliver(spec, &mport);\n+}\n+\n+static int\n+sfc_mae_rule_parse_action(struct sfc_adapter *sa,\n+\t\t\t const struct rte_flow_action *action,\n+\t\t\t efx_mae_actions_t *spec,\n \t\t\t struct rte_flow_error *error)\n {\n+\tint rc;\n+\n \tswitch (action->type) {\n+\tcase RTE_FLOW_ACTION_TYPE_PHY_PORT:\n+\t\trc = sfc_mae_rule_parse_action_phy_port(sa, action->conf, spec);\n+\t\tbreak;\n \tdefault:\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\"Unsupported action\");\n \t}\n \n-\treturn 0;\n+\tif (rc != 0) {\n+\t\trc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tNULL, \"Failed to request the action\");\n+\t}\n+\n+\treturn rc;\n }\n \n int\n@@ -427,7 +459,7 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \n \tfor (action = actions;\n \t action->type != RTE_FLOW_ACTION_TYPE_END; ++action) {\n-\t\trc = sfc_mae_rule_parse_action(action, spec, error);\n+\t\trc = sfc_mae_rule_parse_action(sa, action, spec, error);\n \t\tif (rc != 0)\n \t\t\tgoto fail_rule_parse_action;\n \t}\n", "prefixes": [ "v2", "21/62" ] }