Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81499/?format=api
{ "id": 81499, "url": "http://patches.dpdk.org/api/patches/81499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-18-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603183709-23420-18-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603183709-23420-18-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T08:47:44", "name": "[17/62] net/sfc: support flow item PHY PORT in MAE backend", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "998bf30284f64ecfb55757154607035e468d7a55", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-18-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13132, "url": "http://patches.dpdk.org/api/series/13132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13132", "date": "2020-10-20T08:47:30", "name": "net/sfc: support flow API transfer rules", "version": 1, "mbox": "http://patches.dpdk.org/series/13132/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81499/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 94623A04DD;\n\tTue, 20 Oct 2020 11:09:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6975FCB34;\n\tTue, 20 Oct 2020 10:50:29 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 2594EAD31\n for <dev@dpdk.org>; Tue, 20 Oct 2020 10:49:08 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.61])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 62E146008C for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:06 +0000 (UTC)", "from us4-mdac16-41.ut7.mdlocal (unknown [10.7.64.23])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 634C78009E\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:06 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.199])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E1FF780056\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:05 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 9877F18005C\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:05 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 09:48:50 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 09:48:50 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K8mnWH030802;\n Tue, 20 Oct 2020 09:48:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 973FA1619F5;\n Tue, 20 Oct 2020 09:48:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<y@solarflare.com>", "CC": "<dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 09:47:44 +0100", "Message-ID": "<1603183709-23420-18-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-2.441700-8.000000-10", "X-TMASE-MatchedRID": "xNyt3d70ywyqfSQfLa/SN6iUivh0j2Pv6VTG9cZxEjIGmHr1eMxt2UAc\n 6DyoS2rIzFlXLlUThJU2varlbSSzl2owheuziK0qR/j040fRFpIUBI/UWYG7Fm+arpqBxtz8KKb\n M5Q4DbH9N9XVFzHGStAC5tSYXAMeQvgJhgunlKsvnvg/SfqXd/dnLANiJ9J62VWQnHKxp38hCZn\n 37VQFgvZ3B/CendwLbRQq6I/z93yVJI5ZUl647UBRFJJyf5BJe3QfwsVk0UbsIoUKaF27lxf2vy\n Qh3a+J6d60Nxl+VEPhajLI6kawbXbMbby/KWwIgCDir6MaPzzhTJhATzQKBJBOXWNbsga/GnEjm\n yz4KDiU1Ubs5jKswrQ9cvEd/Et5dVEc5IqztENReYfSkFq6uAb7jE6+wkCSe+rL5VW+ofZc=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-2.441700-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603183746-iiW_NrMB4YSB", "X-PPE-DISP": "1603183746;iiW_NrMB4YSB", "Subject": "[dpdk-dev] [PATCH 17/62] net/sfc: support flow item PHY PORT in MAE\n\tbackend", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nAdd support for this flow item to MAE-specific RTE flow implementation.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/sfc_efx.rst | 4 +++\n drivers/net/sfc/sfc_mae.c | 69 +++++++++++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_mae.h | 1 +\n 3 files changed, 74 insertions(+)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 7a5aff79f9..b12e93180e 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -188,6 +188,10 @@ Supported actions (***non-transfer*** rules):\n \n - MARK (supported only with ef10_essb Rx datapath)\n \n+Supported pattern items (***transfer*** rules):\n+\n+- PHY_PORT (cannot repeat; conflicts with other traffic source items)\n+\n Validating flow rules depends on the firmware variant.\n \n The :ref:`flow_isolated_mode` is supported.\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex de2c6b26e4..87d2e15d29 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -163,7 +163,76 @@ sfc_mae_flow_cleanup(struct sfc_adapter *sa,\n \t\tefx_mae_match_spec_fini(sa->nic, spec_mae->match_spec);\n }\n \n+static int\n+sfc_mae_rule_parse_item_phy_port(const struct rte_flow_item *item,\n+\t\t\t\t struct sfc_flow_parse_ctx *ctx,\n+\t\t\t\t struct rte_flow_error *error)\n+{\n+\tstruct sfc_mae_parse_ctx *ctx_mae = ctx->mae;\n+\tconst struct rte_flow_item_phy_port supp_mask = {\n+\t\t.index = 0xffffffff,\n+\t};\n+\tconst void *def_mask = &rte_flow_item_phy_port_mask;\n+\tconst struct rte_flow_item_phy_port *spec = NULL;\n+\tconst struct rte_flow_item_phy_port *mask = NULL;\n+\tefx_mport_sel_t mport_v;\n+\tint rc;\n+\n+\tif (ctx_mae->match_mport_set) {\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\"Can't handle multiple traffic source items\");\n+\t}\n+\n+\trc = sfc_flow_parse_init(item,\n+\t\t\t\t (const void **)&spec, (const void **)&mask,\n+\t\t\t\t (const void *)&supp_mask, def_mask,\n+\t\t\t\t sizeof(struct rte_flow_item_phy_port), error);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\tif (mask->index != supp_mask.index) {\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\"Bad mask in the PHY_PORT pattern item\");\n+\t}\n+\n+\t/* If \"spec\" is not set, could be any physical port */\n+\tif (spec == NULL)\n+\t\treturn 0;\n+\n+\trc = efx_mae_mport_by_phy_port(spec->index, &mport_v);\n+\tif (rc != 0) {\n+\t\treturn rte_flow_error_set(error, rc,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\"Failed to convert the PHY_PORT index\");\n+\t}\n+\n+\trc = efx_mae_match_spec_mport_set(ctx_mae->match_spec_action,\n+\t\t\t\t\t &mport_v, NULL);\n+\tif (rc != 0) {\n+\t\treturn rte_flow_error_set(error, rc,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\"Failed to set MPORT for the PHY_PORT\");\n+\t}\n+\n+\tctx_mae->match_mport_set = B_TRUE;\n+\n+\treturn 0;\n+}\n+\n static const struct sfc_flow_item sfc_flow_items[] = {\n+\t{\n+\t\t.type = RTE_FLOW_ITEM_TYPE_PHY_PORT,\n+\t\t/*\n+\t\t * In terms of RTE flow, this item is a META one,\n+\t\t * and its position in the pattern is don't care.\n+\t\t */\n+\t\t.prev_layer = SFC_FLOW_ITEM_ANY_LAYER,\n+\t\t.layer = SFC_FLOW_ITEM_ANY_LAYER,\n+\t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n+\t\t.parse = sfc_mae_rule_parse_item_phy_port,\n+\t},\n };\n \n int\ndiff --git a/drivers/net/sfc/sfc_mae.h b/drivers/net/sfc/sfc_mae.h\nindex 5727962a0b..1ef582e82b 100644\n--- a/drivers/net/sfc/sfc_mae.h\n+++ b/drivers/net/sfc/sfc_mae.h\n@@ -48,6 +48,7 @@ struct sfc_flow_spec;\n \n struct sfc_mae_parse_ctx {\n \tefx_mae_match_spec_t\t\t*match_spec_action;\n+\tbool\t\t\t\tmatch_mport_set;\n };\n \n int sfc_mae_attach(struct sfc_adapter *sa);\n", "prefixes": [ "17/62" ] }