Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81468/?format=api
{ "id": 81468, "url": "http://patches.dpdk.org/api/patches/81468/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-20-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603183709-23420-20-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603183709-23420-20-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T08:47:46", "name": "[19/62] net/sfc: support flow item ETH in MAE backend", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a607d833bd5e9eeaa1d939838492708037a46df", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-20-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13132, "url": "http://patches.dpdk.org/api/series/13132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13132", "date": "2020-10-20T08:47:30", "name": "net/sfc: support flow API transfer rules", "version": 1, "mbox": "http://patches.dpdk.org/series/13132/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81468/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81468/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6F14A04DD;\n\tTue, 20 Oct 2020 10:58:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D9FEBE2F;\n\tTue, 20 Oct 2020 10:49:42 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 884CEBBA0\n for <dev@dpdk.org>; Tue, 20 Oct 2020 10:49:03 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 5846D60065 for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:03 +0000 (UTC)", "from us4-mdac16-62.ut7.mdlocal (unknown [10.7.66.61])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 58F112009A\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:03 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.41])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n D843A1C004F\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:02 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 6CB624C0059\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:02 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 09:48:50 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 09:48:50 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K8mnvU030801;\n Tue, 20 Oct 2020 09:48:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id B1850161A0A;\n Tue, 20 Oct 2020 09:48:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<y@solarflare.com>", "CC": "<dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 09:47:46 +0100", "Message-ID": "<1603183709-23420-20-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-1.355500-8.000000-10", "X-TMASE-MatchedRID": "pm5esiOnALWqfSQfLa/SN6iUivh0j2Pv6VTG9cZxEjIGmHr1eMxt2UAc\n 6DyoS2rIEcE+LOiKuIt27cZtoykdFo9y28rShcKqRpZ38TWrY5yoSgRE9rhqi08iLpubparmku+\n GdcB8c5O+9mDuGGWszi83jj4qEbKvxz6opuAAUJIPe5gzF3TVt9ST/TZ3TTpFbdiWoEZixCujxY\n yRBa/qJcFwgTvxipFajoczmuoPCq2TinQiJ4LphjPnD9L3bIRZjt+BvEYBmOOpyJ8n9mqyBGJBT\n U6nDmRgIZinM5iiFn4uPYpo5rd4OnMsjZzimveuNMpshF9F2MGF15h6/oibNbKsWJ44GuEGPNxa\n u39/BitFwHZmk+dWMmhnUCrcDtVn", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.355500-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603183743-SevSCiCBNykg", "X-PPE-DISP": "1603183743;SevSCiCBNykg", "Subject": "[dpdk-dev] [PATCH 19/62] net/sfc: support flow item ETH in MAE\n\tbackend", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nAdd support for this flow item to MAE-specific RTE flow implementation.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/sfc_efx.rst | 2 +\n drivers/net/sfc/sfc_mae.c | 106 ++++++++++++++++++++++++++++++++++++\n 2 files changed, 108 insertions(+)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex b12e93180e..65d52d5551 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -192,6 +192,8 @@ Supported pattern items (***transfer*** rules):\n \n - PHY_PORT (cannot repeat; conflicts with other traffic source items)\n \n+- ETH\n+\n Validating flow rules depends on the firmware variant.\n \n The :ref:`flow_isolated_mode` is supported.\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 87d2e15d29..95f8cffc27 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -221,6 +221,105 @@ sfc_mae_rule_parse_item_phy_port(const struct rte_flow_item *item,\n \treturn 0;\n }\n \n+struct sfc_mae_field_locator {\n+\tefx_mae_field_id_t\t\tfield_id;\n+\tsize_t\t\t\t\tsize;\n+\t/* Field offset in the corresponding rte_flow_item_ struct */\n+\tsize_t\t\t\t\tofst;\n+};\n+\n+static void\n+sfc_mae_item_build_supp_mask(const struct sfc_mae_field_locator *field_locators,\n+\t\t\t unsigned int nb_field_locators, void *mask_ptr,\n+\t\t\t size_t mask_size)\n+{\n+\tunsigned int i;\n+\n+\tmemset(mask_ptr, 0, mask_size);\n+\n+\tfor (i = 0; i < nb_field_locators; ++i) {\n+\t\tconst struct sfc_mae_field_locator *fl = &field_locators[i];\n+\n+\t\tSFC_ASSERT(fl->ofst + fl->size <= mask_size);\n+\t\tmemset(RTE_PTR_ADD(mask_ptr, fl->ofst), 0xff, fl->size);\n+\t}\n+}\n+\n+static int\n+sfc_mae_parse_item(const struct sfc_mae_field_locator *field_locators,\n+\t\t unsigned int nb_field_locators, const uint8_t *spec,\n+\t\t const uint8_t *mask, efx_mae_match_spec_t *efx_spec,\n+\t\t struct rte_flow_error *error)\n+{\n+\tunsigned int i;\n+\tint rc = 0;\n+\n+\tfor (i = 0; i < nb_field_locators; ++i) {\n+\t\tconst struct sfc_mae_field_locator *fl = &field_locators[i];\n+\n+\t\trc = efx_mae_match_spec_field_set(efx_spec, fl->field_id,\n+\t\t\t\t\t\t fl->size, spec + fl->ofst,\n+\t\t\t\t\t\t fl->size, mask + fl->ofst);\n+\t\tif (rc != 0)\n+\t\t\tbreak;\n+\t}\n+\n+\tif (rc != 0) {\n+\t\trc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\tNULL, \"Failed to process item fields\");\n+\t}\n+\n+\treturn rc;\n+}\n+\n+static const struct sfc_mae_field_locator flocs_eth[] = {\n+\t{\n+\t\tEFX_MAE_FIELD_ETHER_TYPE_BE,\n+\t\tRTE_SIZEOF_FIELD(struct rte_flow_item_eth, type),\n+\t\toffsetof(struct rte_flow_item_eth, type),\n+\t},\n+\t{\n+\t\tEFX_MAE_FIELD_ETH_DADDR_BE,\n+\t\tRTE_SIZEOF_FIELD(struct rte_flow_item_eth, dst),\n+\t\toffsetof(struct rte_flow_item_eth, dst),\n+\t},\n+\t{\n+\t\tEFX_MAE_FIELD_ETH_SADDR_BE,\n+\t\tRTE_SIZEOF_FIELD(struct rte_flow_item_eth, src),\n+\t\toffsetof(struct rte_flow_item_eth, src),\n+\t},\n+};\n+\n+static int\n+sfc_mae_rule_parse_item_eth(const struct rte_flow_item *item,\n+\t\t\t struct sfc_flow_parse_ctx *ctx,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tstruct sfc_mae_parse_ctx *ctx_mae = ctx->mae;\n+\tstruct rte_flow_item_eth supp_mask;\n+\tconst uint8_t *spec = NULL;\n+\tconst uint8_t *mask = NULL;\n+\tint rc;\n+\n+\tsfc_mae_item_build_supp_mask(flocs_eth, RTE_DIM(flocs_eth),\n+\t\t\t\t &supp_mask, sizeof(supp_mask));\n+\n+\trc = sfc_flow_parse_init(item,\n+\t\t\t\t (const void **)&spec, (const void **)&mask,\n+\t\t\t\t (const void *)&supp_mask,\n+\t\t\t\t &rte_flow_item_eth_mask,\n+\t\t\t\t sizeof(struct rte_flow_item_eth), error);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\t/* If \"spec\" is not set, could be any Ethernet */\n+\tif (spec == NULL)\n+\t\treturn 0;\n+\n+\treturn sfc_mae_parse_item(flocs_eth, RTE_DIM(flocs_eth), spec, mask,\n+\t\t\t\t ctx_mae->match_spec_action, error);\n+}\n+\n static const struct sfc_flow_item sfc_flow_items[] = {\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PHY_PORT,\n@@ -233,6 +332,13 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n \t\t.parse = sfc_mae_rule_parse_item_phy_port,\n \t},\n+\t{\n+\t\t.type = RTE_FLOW_ITEM_TYPE_ETH,\n+\t\t.prev_layer = SFC_FLOW_ITEM_START_LAYER,\n+\t\t.layer = SFC_FLOW_ITEM_L2,\n+\t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n+\t\t.parse = sfc_mae_rule_parse_item_eth,\n+\t},\n };\n \n int\n", "prefixes": [ "19/62" ] }