Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81445/?format=api
{ "id": 81445, "url": "http://patches.dpdk.org/api/patches/81445/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-6-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603183709-23420-6-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603183709-23420-6-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T08:47:32", "name": "[05/62] drivers: init/fini MAE on attach/detach", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a67637e3a85991116f700dcf01e4544b087757cc", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-6-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13132, "url": "http://patches.dpdk.org/api/series/13132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13132", "date": "2020-10-20T08:47:30", "name": "net/sfc: support flow API transfer rules", "version": 1, "mbox": "http://patches.dpdk.org/series/13132/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81445/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81445/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC3F5A04DD;\n\tTue, 20 Oct 2020 10:49:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E2F23BBB8;\n\tTue, 20 Oct 2020 10:49:05 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 912F7ACC9\n for <dev@dpdk.org>; Tue, 20 Oct 2020 10:48:56 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.62])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 194B960051 for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:55 +0000 (UTC)", "from us4-mdac16-30.ut7.mdlocal (unknown [10.7.66.140])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 188328009B\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:55 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.33])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 87D6828004D\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:54 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 3EA01A80071\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:54 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 09:48:50 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 09:48:49 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K8mnHn030800;\n Tue, 20 Oct 2020 09:48:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id EBA891616E3;\n Tue, 20 Oct 2020 09:48:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<y@solarflare.com>", "CC": "<dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 09:47:32 +0100", "Message-ID": "<1603183709-23420-6-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-1.175400-8.000000-10", "X-TMASE-MatchedRID": "1DmCryjwV2XabBVcqlDcF7sHVDDM5xAPP6Tki+9nU39YwVHjLI3nekAc\n 6DyoS2rIrXMOxnDE+MQzbI1E6WnGTk4l7sir0CBC/bV/VOhrmoqByxVkfd04JMLlYljmBfZco8W\n MkQWv6iUoTQl7wNH8Po2j49Ftap9Ero1URZJFbJtrfft55rUxllvGCZxC1c9glo/yFibJ7GXOIV\n CKtNnYWbAmjnsVNiz6Qo41jQgk7qUphba8lPe+b9oVs05KV5nOVr9TVCbQbPvw7JxwU0EvZMqER\n OLb/+yO4/0Jvn0rwAJmtL4Dw+zNb0D/MIf9Orkd", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.175400-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603183735-BneXZ7yQ7NE2", "X-PPE-DISP": "1603183735;BneXZ7yQ7NE2", "Subject": "[dpdk-dev] [PATCH 05/62] drivers: init/fini MAE on attach/detach", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nThese actions affect MAE supplementary resources which are libefx-internal.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/efsys.h | 2 +-\n drivers/net/sfc/sfc_mae.c | 17 +++++++++++++++++\n 2 files changed, 18 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/sfc_efx/efsys.h b/drivers/common/sfc_efx/efsys.h\nindex 8636e73b68..bbe9f2ef12 100644\n--- a/drivers/common/sfc_efx/efsys.h\n+++ b/drivers/common/sfc_efx/efsys.h\n@@ -167,7 +167,7 @@ prefetch_read_once(const volatile void *addr)\n \n #define EFSYS_OPT_DESC_PROXY 0\n \n-#define EFSYS_OPT_MAE 0\n+#define EFSYS_OPT_MAE 1\n \n /* ID */\n \ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 3ce654c19b..2a7ed6377a 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -21,6 +21,7 @@ sfc_mae_attach(struct sfc_adapter *sa)\n {\n \tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);\n \tstruct sfc_mae *mae = &sa->mae;\n+\tint rc;\n \n \tsfc_log_init(sa, \"entry\");\n \n@@ -29,21 +30,37 @@ sfc_mae_attach(struct sfc_adapter *sa)\n \t\treturn 0;\n \t}\n \n+\tsfc_log_init(sa, \"init MAE\");\n+\trc = efx_mae_init(sa->nic);\n+\tif (rc != 0)\n+\t\tgoto fail_mae_init;\n+\n \tmae->status = SFC_MAE_STATUS_SUPPORTED;\n \n \tsfc_log_init(sa, \"done\");\n \n \treturn 0;\n+\n+fail_mae_init:\n+\tsfc_log_init(sa, \"failed %d\", rc);\n+\n+\treturn rc;\n }\n \n void\n sfc_mae_detach(struct sfc_adapter *sa)\n {\n \tstruct sfc_mae *mae = &sa->mae;\n+\tenum sfc_mae_status status_prev = mae->status;\n \n \tsfc_log_init(sa, \"entry\");\n \n \tmae->status = SFC_MAE_STATUS_UNKNOWN;\n \n+\tif (status_prev != SFC_MAE_STATUS_SUPPORTED)\n+\t\treturn;\n+\n+\tefx_mae_fini(sa->nic);\n+\n \tsfc_log_init(sa, \"done\");\n }\n", "prefixes": [ "05/62" ] }