Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81437/?format=api
{ "id": 81437, "url": "http://patches.dpdk.org/api/patches/81437/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603182389-10087-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603182389-10087-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603182389-10087-3-git-send-email-humin29@huawei.com", "date": "2020-10-20T08:26:29", "name": "[RFC,V2,2/2] app/testpmd: fix starting failed with queue-stats-mapping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fb0e71f429b7529f1dc574a586e9948f77767507", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603182389-10087-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 13130, "url": "http://patches.dpdk.org/api/series/13130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13130", "date": "2020-10-20T08:26:29", "name": "fix queue stats mapping", "version": 2, "mbox": "http://patches.dpdk.org/series/13130/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81437/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EB714A04DC;\n\tTue, 20 Oct 2020 10:26:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 73AB5BB96;\n\tTue, 20 Oct 2020 10:25:57 +0200 (CEST)", "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id 0CEAFBB04\n for <dev@dpdk.org>; Tue, 20 Oct 2020 10:25:56 +0200 (CEST)", "from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id CD66FCED3B1111DAB9FD;\n Tue, 20 Oct 2020 16:25:53 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id\n 14.3.487.0; Tue, 20 Oct 2020 16:25:46 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <bruce.richardson@intel.com>,\n <thomas.monjalon@6wind.com>, <lihuisong@huawei.com>", "Date": "Tue, 20 Oct 2020 16:26:29 +0800", "Message-ID": "<1603182389-10087-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1603182389-10087-1-git-send-email-humin29@huawei.com>", "References": "<1603182389-10087-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [RFC V2 2/2] app/testpmd: fix starting failed with\n\tqueue-stats-mapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\ntestpmd fails to start with \"--rx-queue-stats-mapping\" and\n\"--tx-queue-stats-mapping\", which is caused by the failure and exit of\n'map_port_queue_stats_mapping_registers' function. By default,\nthe configuration of queue statistics mapping in the initialization\nprocess is implemented in the 'init_port_config' function. However,\nthe dev_configure interface is not called to configure the NIC\nand dev->data-nb_rx/tx_queues is zero. As a result,\n'rte_eth_dev_set_tx/rx_queue_stats_mapping' function fails to verify\nthe queue_id. Therefore, it is necessary to move\n'map_port_queue_stats_mapping_registers' from 'init_port_config'\nto 'start_port' function.\n\nFixes: 013af9b6b64f6e7 (\"app/testpmd: various updates\")\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test-pmd/testpmd.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 86e3271..e4fe2a6 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2742,6 +2742,7 @@ start_port(portid_t pid)\n \t\tneed_check_link_status = 1;\n \n \t\tpl[cfg_pi++] = pi;\n+\t\tmap_port_queue_stats_mapping_registers(pi, port);\n \t}\n \n \tif (need_check_link_status == 1 && !no_link_check)\n@@ -3600,7 +3601,6 @@ init_port_config(void)\n \t\tif (ret != 0)\n \t\t\treturn;\n \n-\t\tmap_port_queue_stats_mapping_registers(pid, port);\n #if defined RTE_LIBRTE_IXGBE_PMD && defined RTE_LIBRTE_IXGBE_BYPASS\n \t\trte_pmd_ixgbe_bypass_init(pid);\n #endif\n", "prefixes": [ "RFC", "V2", "2/2" ] }