Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81269/?format=api
{ "id": 81269, "url": "http://patches.dpdk.org/api/patches/81269/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603030152-13451-14-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603030152-13451-14-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603030152-13451-14-git-send-email-arybchenko@solarflare.com", "date": "2020-10-18T14:09:10", "name": "[13/14] app/testpmd: remove flow_director_flex_mask command", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cabd490015af2941a44040c9572f2875782d274d", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603030152-13451-14-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13082, "url": "http://patches.dpdk.org/api/series/13082/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13082", "date": "2020-10-18T14:08:57", "name": "ethdev: remove legacy filter API", "version": 1, "mbox": "http://patches.dpdk.org/series/13082/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81269/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C518DA04B0;\n\tSun, 18 Oct 2020 16:14:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 76602E27C;\n\tSun, 18 Oct 2020 16:09:48 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id BF754C8B2\n for <dev@dpdk.org>; Sun, 18 Oct 2020 16:09:30 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 68A8C2009B; Sun, 18 Oct 2020 14:09:29 +0000 (UTC)", "from us4-mdac16-15.at1.mdlocal (unknown [10.110.49.197])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 67959800A9;\n Sun, 18 Oct 2020 14:09:29 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 015E740070;\n Sun, 18 Oct 2020 14:09:29 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n BE2574005B;\n Sun, 18 Oct 2020 14:09:28 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Sun, 18 Oct 2020 15:09:23 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Sun, 18 Oct 2020 15:09:23 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09IE9NRW002067;\n Sun, 18 Oct 2020 15:09:23 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id AD9AE1613A9;\n Sun, 18 Oct 2020 15:09:23 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>", "CC": "<dev@dpdk.org>", "Date": "Sun, 18 Oct 2020 15:09:10 +0100", "Message-ID": "<1603030152-13451-14-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603030152-13451-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603030152-13451-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25732.003", "X-TM-AS-Result": "No-9.195500-8.000000-10", "X-TMASE-MatchedRID": "2FY0xL9szyFW3uCK//k4ajVUc/h8Ki+CS1zwNuiBtITfUZT83lbkEIai\n cYvSM3sy4jSEPApuIJz78dnxIA7Z1yB5fvlrSjb1ntN+u6tbkNS6cV0bV9Vi8znZfxjBVQRbDYo\n fQuAXb7gp36ITLH8EKBK/h+VrAVy3QuKBkEdEA0xIcJTn2HkqsSH8kDR0dp2mnp9KgXcu34xvAl\n nua0Nm7YI4kQxluwXMduvJHyi1ZpH+PzzbebkcBEaMPBFKXyAU3YSaHlnZL82Rjx4hNpIk+HFC0\n fMeQA5wv4pvasvMugDdghnhCkMrEJcFdomgH0lnFEUknJ/kEl7dB/CxWTRRu25FeHtsUoHuxPpX\n onmP5aib3HDJVFcDxuE001dFHx2S4rkOv1OWl4QfwV6sBPR0lg==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--9.195500-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25732.003", "X-MDID": "1603030169-eqcNgWVUE1eX", "X-PPE-DISP": "1603030169;eqcNgWVUE1eX", "Subject": "[dpdk-dev] [PATCH 13/14] app/testpmd: remove\n\tflow_director_flex_mask command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The command uses FDIR filter information get API which\nis not supported any more.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test-pmd/cmdline.c | 124 -----------------------------------------\n 1 file changed, 124 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 9ce6c09567..d52db2f4b2 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -981,12 +981,6 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\" tunnel-id (tunnel_id_value)\\n\"\n \t\t\t\" Set flow director Tunnel mask.\\n\\n\"\n \n-\t\t\t\"flow_director_flex_mask (port_id)\"\n-\t\t\t\" flow (none|ipv4-other|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|\"\n-\t\t\t\"ipv6-other|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|l2_payload|all)\"\n-\t\t\t\" (mask)\\n\"\n-\t\t\t\" Configure mask of flex payload.\\n\\n\"\n-\n \t\t\t\"flow_director_flex_payload (port_id)\"\n \t\t\t\" (raw|l2|l3|l4) (config)\\n\"\n \t\t\t\" Configure flex payload selection.\\n\\n\"\n@@ -10551,123 +10545,6 @@ cmdline_parse_inst_t cmd_set_flow_director_tunnel_mask = {\n \t},\n };\n \n-/* *** deal with flow director mask on flexible payload *** */\n-struct cmd_flow_director_flex_mask_result {\n-\tcmdline_fixed_string_t flow_director_flexmask;\n-\tportid_t port_id;\n-\tcmdline_fixed_string_t flow;\n-\tcmdline_fixed_string_t flow_type;\n-\tcmdline_fixed_string_t mask;\n-};\n-\n-static void\n-cmd_flow_director_flex_mask_parsed(void *parsed_result,\n-\t\t\t __rte_unused struct cmdline *cl,\n-\t\t\t __rte_unused void *data)\n-{\n-\tstruct cmd_flow_director_flex_mask_result *res = parsed_result;\n-\tstruct rte_eth_fdir_info fdir_info;\n-\tstruct rte_eth_fdir_flex_mask flex_mask;\n-\tstruct rte_port *port;\n-\tuint64_t flow_type_mask;\n-\tuint16_t i;\n-\tint ret;\n-\n-\tport = &ports[res->port_id];\n-\t/** Check if the port is not started **/\n-\tif (port->port_status != RTE_PORT_STOPPED) {\n-\t\tprintf(\"Please stop port %d first\\n\", res->port_id);\n-\t\treturn;\n-\t}\n-\n-\tmemset(&flex_mask, 0, sizeof(struct rte_eth_fdir_flex_mask));\n-\tret = parse_flexbytes(res->mask,\n-\t\t\tflex_mask.mask,\n-\t\t\tRTE_ETH_FDIR_MAX_FLEXLEN);\n-\tif (ret < 0) {\n-\t\tprintf(\"error: Cannot parse mask input.\\n\");\n-\t\treturn;\n-\t}\n-\n-\tmemset(&fdir_info, 0, sizeof(fdir_info));\n-\tret = rte_eth_dev_filter_ctrl(res->port_id, RTE_ETH_FILTER_FDIR,\n-\t\t\t\tRTE_ETH_FILTER_INFO, &fdir_info);\n-\tif (ret < 0) {\n-\t\tprintf(\"Cannot get FDir filter info\\n\");\n-\t\treturn;\n-\t}\n-\n-\tif (!strcmp(res->flow_type, \"none\")) {\n-\t\t/* means don't specify the flow type */\n-\t\tflex_mask.flow_type = RTE_ETH_FLOW_UNKNOWN;\n-\t\tfor (i = 0; i < RTE_ETH_FLOW_MAX; i++)\n-\t\t\tmemset(&port->dev_conf.fdir_conf.flex_conf.flex_mask[i],\n-\t\t\t 0, sizeof(struct rte_eth_fdir_flex_mask));\n-\t\tport->dev_conf.fdir_conf.flex_conf.nb_flexmasks = 1;\n-\t\trte_memcpy(&port->dev_conf.fdir_conf.flex_conf.flex_mask[0],\n-\t\t\t\t &flex_mask,\n-\t\t\t\t sizeof(struct rte_eth_fdir_flex_mask));\n-\t\tcmd_reconfig_device_queue(res->port_id, 1, 1);\n-\t\treturn;\n-\t}\n-\tflow_type_mask = fdir_info.flow_types_mask[0];\n-\tif (!strcmp(res->flow_type, \"all\")) {\n-\t\tif (!flow_type_mask) {\n-\t\t\tprintf(\"No flow type supported\\n\");\n-\t\t\treturn;\n-\t\t}\n-\t\tfor (i = RTE_ETH_FLOW_UNKNOWN; i < RTE_ETH_FLOW_MAX; i++) {\n-\t\t\tif (flow_type_mask & (1ULL << i)) {\n-\t\t\t\tflex_mask.flow_type = i;\n-\t\t\t\tfdir_set_flex_mask(res->port_id, &flex_mask);\n-\t\t\t}\n-\t\t}\n-\t\tcmd_reconfig_device_queue(res->port_id, 1, 1);\n-\t\treturn;\n-\t}\n-\tflex_mask.flow_type = str2flowtype(res->flow_type);\n-\tif (!(flow_type_mask & (1ULL << flex_mask.flow_type))) {\n-\t\tprintf(\"Flow type %s not supported on port %d\\n\",\n-\t\t\t\tres->flow_type, res->port_id);\n-\t\treturn;\n-\t}\n-\tfdir_set_flex_mask(res->port_id, &flex_mask);\n-\tcmd_reconfig_device_queue(res->port_id, 1, 1);\n-}\n-\n-cmdline_parse_token_string_t cmd_flow_director_flexmask =\n-\tTOKEN_STRING_INITIALIZER(struct cmd_flow_director_flex_mask_result,\n-\t\t\t\t flow_director_flexmask,\n-\t\t\t\t \"flow_director_flex_mask\");\n-cmdline_parse_token_num_t cmd_flow_director_flexmask_port_id =\n-\tTOKEN_NUM_INITIALIZER(struct cmd_flow_director_flex_mask_result,\n-\t\t\t port_id, UINT16);\n-cmdline_parse_token_string_t cmd_flow_director_flexmask_flow =\n-\tTOKEN_STRING_INITIALIZER(struct cmd_flow_director_flex_mask_result,\n-\t\t\t\t flow, \"flow\");\n-cmdline_parse_token_string_t cmd_flow_director_flexmask_flow_type =\n-\tTOKEN_STRING_INITIALIZER(struct cmd_flow_director_flex_mask_result,\n-\t\tflow_type, \"none#ipv4-other#ipv4-frag#ipv4-tcp#ipv4-udp#ipv4-sctp#\"\n-\t\t\"ipv6-other#ipv6-frag#ipv6-tcp#ipv6-udp#ipv6-sctp#l2_payload#all\");\n-cmdline_parse_token_string_t cmd_flow_director_flexmask_mask =\n-\tTOKEN_STRING_INITIALIZER(struct cmd_flow_director_flex_mask_result,\n-\t\t\t\t mask, NULL);\n-\n-cmdline_parse_inst_t cmd_set_flow_director_flex_mask = {\n-\t.f = cmd_flow_director_flex_mask_parsed,\n-\t.data = NULL,\n-\t.help_str = \"flow_director_flex_mask ... : \"\n-\t\t\"Set flow director's flex mask on NIC\",\n-\t.tokens = {\n-\t\t(void *)&cmd_flow_director_flexmask,\n-\t\t(void *)&cmd_flow_director_flexmask_port_id,\n-\t\t(void *)&cmd_flow_director_flexmask_flow,\n-\t\t(void *)&cmd_flow_director_flexmask_flow_type,\n-\t\t(void *)&cmd_flow_director_flexmask_mask,\n-\t\tNULL,\n-\t},\n-};\n-\n /* *** deal with flow director flexible payload configuration *** */\n struct cmd_flow_director_flexpayload_result {\n \tcmdline_fixed_string_t flow_director_flexpayload;\n@@ -17659,7 +17536,6 @@ cmdline_parse_ctx_t main_ctx[] = {\n \t(cmdline_parse_inst_t *)&cmd_set_flow_director_ip_mask,\n \t(cmdline_parse_inst_t *)&cmd_set_flow_director_mac_vlan_mask,\n \t(cmdline_parse_inst_t *)&cmd_set_flow_director_tunnel_mask,\n-\t(cmdline_parse_inst_t *)&cmd_set_flow_director_flex_mask,\n \t(cmdline_parse_inst_t *)&cmd_set_flow_director_flex_payload,\n \t(cmdline_parse_inst_t *)&cmd_flow,\n \t(cmdline_parse_inst_t *)&cmd_show_port_meter_cap,\n", "prefixes": [ "13/14" ] }