Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81136/?format=api
http://patches.dpdk.org/api/patches/81136/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201016142742.87297-13-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201016142742.87297-13-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201016142742.87297-13-ciara.power@intel.com", "date": "2020-10-16T14:27:36", "name": "[v9,12/18] net/virtio: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "33a55e6a097b51b1f9ed4a42325dc543cc3f055d", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201016142742.87297-13-ciara.power@intel.com/mbox/", "series": [ { "id": 13067, "url": "http://patches.dpdk.org/api/series/13067/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13067", "date": "2020-10-16T14:27:24", "name": "add max SIMD bitwidth to EAL", "version": 9, "mbox": "http://patches.dpdk.org/series/13067/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81136/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81136/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1938A04DB;\n\tFri, 16 Oct 2020 16:32:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 826B91EF90;\n\tFri, 16 Oct 2020 16:28:24 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id F1EC21EF8C\n for <dev@dpdk.org>; Fri, 16 Oct 2020 16:28:20 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Oct 2020 07:28:20 -0700", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.239])\n by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2020 07:28:18 -0700" ], "IronPort-SDR": [ "\n N9POTKkwtIYUtce1ajm1HcRvNcMeuN4qrjnx0+UzV3z/lbVEt6Ya3iOXvvHAKmEVKy2UZsQmVV\n pcI4AF8BdDdQ==", "\n s9TXr7qnlVc7vqveI0bx1f8uDGD+4Cbivw9sF1XTNXxzEaa5z8mnM3NozfME50+AtfLupbukOA\n eIKg3c2XWgjA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9775\"; a=\"163143030\"", "E=Sophos;i=\"5.77,383,1596524400\"; d=\"scan'208\";a=\"163143030\"", "E=Sophos;i=\"5.77,383,1596524400\"; d=\"scan'208\";a=\"357395089\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "viktorin@rehivetech.com, ruifeng.wang@arm.com, jerinj@marvell.com,\n drc@linux.vnet.ibm.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, david.marchand@redhat.com,\n Ciara Power <ciara.power@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Fri, 16 Oct 2020 15:27:36 +0100", "Message-Id": "<20201016142742.87297-13-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20201016142742.87297-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20201016142742.87297-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 12/18] net/virtio: add checks for max SIMD\n\tbitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Maxime Coquelin <maxime.coquelin@redhat.com>\nCc: Chenbo Xia <chenbo.xia@intel.com>\nCc: Zhihong Wang <zhihong.wang@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\nAcked-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n\n---\nv4: Updated enum name.\nv3: Moved max SIMD bitwidth check to configure function with other vec\n support checks.\n---\n drivers/net/virtio/virtio_ethdev.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 65eefa2a31..8560c406de 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -2313,7 +2313,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\tif ((hw->use_vec_rx || hw->use_vec_tx) &&\n \t\t (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) ||\n \t\t !vtpci_with_feature(hw, VIRTIO_F_IN_ORDER) ||\n-\t\t !vtpci_with_feature(hw, VIRTIO_F_VERSION_1))) {\n+\t\t !vtpci_with_feature(hw, VIRTIO_F_VERSION_1) ||\n+\t\t rte_get_max_simd_bitwidth() < RTE_SIMD_512)) {\n \t\t\tPMD_DRV_LOG(INFO,\n \t\t\t\t\"disabled packed ring vectorized path for requirements not met\");\n \t\t\thw->use_vec_rx = 0;\n@@ -2366,6 +2367,12 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\t\t\t\t\"disabled split ring vectorized rx for offloading enabled\");\n \t\t\t\thw->use_vec_rx = 0;\n \t\t\t}\n+\n+\t\t\tif (rte_get_max_simd_bitwidth() < RTE_SIMD_128) {\n+\t\t\t\tPMD_DRV_LOG(INFO,\n+\t\t\t\t\t\"disabled split ring vectorized rx, max SIMD bitwidth too low\");\n+\t\t\t\thw->use_vec_rx = 0;\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [ "v9", "12/18" ] }{ "id": 81136, "url": "