Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80901/?format=api
{ "id": 80901, "url": "http://patches.dpdk.org/api/patches/80901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201015124154.13357-2-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201015124154.13357-2-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201015124154.13357-2-getelson@nvidia.com", "date": "2020-10-15T12:41:52", "name": "[v5,1/3] ethdev: allow negative values in flow rule types", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3df2137aa9e839c72ab461f9201647b974e83709", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201015124154.13357-2-getelson@nvidia.com/mbox/", "series": [ { "id": 13009, "url": "http://patches.dpdk.org/api/series/13009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13009", "date": "2020-10-15T12:41:51", "name": "Tunnel Offload API", "version": 5, "mbox": "http://patches.dpdk.org/series/13009/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80901/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/80901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A6FEA04DB;\n\tThu, 15 Oct 2020 14:42:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0FA951E53E;\n\tThu, 15 Oct 2020 14:42:24 +0200 (CEST)", "from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com\n [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 71A1B1DF96\n for <dev@dpdk.org>; Thu, 15 Oct 2020 14:42:22 +0200 (CEST)", "from hqmail.nvidia.com (Not Verified[216.228.121.13]) by\n hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)\n id <B5f8843800000>; Thu, 15 Oct 2020 05:41:36 -0700", "from nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13)\n with Microsoft SMTP Server (TLS) id 15.0.1473.3;\n Thu, 15 Oct 2020 12:42:12 +0000" ], "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <matan@nvidia.com>, <rasland@nvidia.com>,\n <elibr@nvidia.com>, <ozsh@nvidia.com>, Ori Kam <orika@nvidia.com>, Viacheslav\n Ovsiienko <viacheslavo@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>, \"Andrew Rybchenko\"\n <andrew.rybchenko@oktetlabs.ru>", "Date": "Thu, 15 Oct 2020 15:41:52 +0300", "Message-ID": "<20201015124154.13357-2-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201015124154.13357-1-getelson@nvidia.com>", "References": "<20200625160348.26220-1-getelson@mellanox.com>\n <20201015124154.13357-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain", "X-Originating-IP": "[10.124.1.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;\n t=1602765696; bh=BYgtzkn5IPTpFN2k7SA3aHtBop/z+AF8oZGoNSx5p2I=;\n h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To:\n References:MIME-Version:Content-Transfer-Encoding:Content-Type:\n X-Originating-IP:X-ClientProxiedBy;\n b=Ycn42B3VJbjw+2kSoWFN7sYTLYdq9dWaJl5Lp0VJdEsJA57azOvtCENnxgvGTCERC\n 7LYe3mRPdaDOg/Xd08Oe88EmfksWcvs5h4qXoExW08QSoUayJ1GZJhfcmAHQqm+kEg\n 1nXwbzLUPRqk+KsLu+FulLwV4y0sjMfjCD24efQCZWOMuSYfBd4YSp+ujaSX7/0b1B\n yYj68rC5LmcsBpLJKRVis7TDU6ItwmNIGQujRAJO3LPCw8DeZureTs3FbXK4dFNRRR\n XLW2rPHw60X1WOEH5AS9rE/qDT0ckMBta7zlLMyoE7fMghlb8ZWU4yjTdmJUXEIvh4\n tEwf9vpMi6OfA==", "Subject": "[dpdk-dev] [PATCH v5 1/3] ethdev: allow negative values in flow\n\trule types", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RTE flow items & actions use positive values in item & action type.\nNegative values are reserved for PMD private types. PMD\nitems & actions usually are not exposed to application and are not\nused to create RTE flows.\n\nThe patch allows applications with access to PMD flow\nitems & actions ability to integrate RTE and PMD items & actions\nand use them to create flow rule.\n\nRTE flow item or action conversion library accepts positive known\nelement types with predefined sizes only. Private PMD items and\nactions do not fit into this scheme becase PMD type values are\nnegative, each PMD has it's own types numeration and element types and\ntheir sizes are not visible at RTE level. To resolve these\nlimitations the patch proposes this solution:\n1. PMD can expose elements of pointer size only. RTE flow\n conversion functions will use pointer size for each configuration\n object in private PMD element it processes;\n2. RTE flow verification will not reject elements with negative type.\n\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n\n---\nv4:\n* update the 'Negative types' section in the rtre_flow.rst\n\n* update the patch comment\n\nv5:\n* rebase to next-net\n---\n doc/guides/prog_guide/rte_flow.rst | 3 +++\n doc/guides/rel_notes/release_20_11.rst | 5 +++++\n lib/librte_ethdev/rte_flow.c | 28 ++++++++++++++++++++------\n 3 files changed, 30 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex 55497c9033..d0dd7a00f1 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -2765,6 +2765,9 @@ identifiers they are not aware of.\n \n A method to generate them remains to be defined.\n \n+Application may use PMD dynamic items or actions in flow rules. In that case\n+size of configuration object in dynamic element must be a pointer size.\n+\n Planned types\n ~~~~~~~~~~~~~\n \ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 3181fdb6a7..55bcb5e91f 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -92,6 +92,11 @@ New Features\n * Updated HWRM structures to 1.10.1.70 version.\n * Added TRUFLOW support for Stingray devices.\n \n+* **Flow rules allowed to use private PMD items / actions.**\n+\n+ * Flow rule verification was updated to accept private PMD\n+ items and actions.\n+\n * **Updated Cisco enic driver.**\n \n * Added support for VF representors with single-queue Tx/Rx and flow API\ndiff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c\nindex ee4f3464fe..411da1940e 100644\n--- a/lib/librte_ethdev/rte_flow.c\n+++ b/lib/librte_ethdev/rte_flow.c\n@@ -480,7 +480,11 @@ rte_flow_conv_item_spec(void *buf, const size_t size,\n \t\t}\n \t\tbreak;\n \tdefault:\n-\t\toff = rte_flow_desc_item[item->type].size;\n+\t\t/**\n+\t\t * allow PMD private flow item\n+\t\t */\n+\t\toff = (int)item->type >= 0 ?\n+\t\t rte_flow_desc_item[item->type].size : sizeof(void *);\n \t\trte_memcpy(buf, data, (size > off ? off : size));\n \t\tbreak;\n \t}\n@@ -583,7 +587,11 @@ rte_flow_conv_action_conf(void *buf, const size_t size,\n \t\t}\n \t\tbreak;\n \tdefault:\n-\t\toff = rte_flow_desc_action[action->type].size;\n+\t\t/**\n+\t\t * allow PMD private flow action\n+\t\t */\n+\t\toff = (int)action->type >= 0 ?\n+\t\t rte_flow_desc_action[action->type].size : sizeof(void *);\n \t\trte_memcpy(buf, action->conf, (size > off ? off : size));\n \t\tbreak;\n \t}\n@@ -625,8 +633,12 @@ rte_flow_conv_pattern(struct rte_flow_item *dst,\n \tunsigned int i;\n \n \tfor (i = 0, off = 0; !num || i != num; ++i, ++src, ++dst) {\n-\t\tif ((size_t)src->type >= RTE_DIM(rte_flow_desc_item) ||\n-\t\t !rte_flow_desc_item[src->type].name)\n+\t\t/**\n+\t\t * allow PMD private flow item\n+\t\t */\n+\t\tif (((int)src->type >= 0) &&\n+\t\t\t((size_t)src->type >= RTE_DIM(rte_flow_desc_item) ||\n+\t\t !rte_flow_desc_item[src->type].name))\n \t\t\treturn rte_flow_error_set\n \t\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM, src,\n \t\t\t\t \"cannot convert unknown item type\");\n@@ -714,8 +726,12 @@ rte_flow_conv_actions(struct rte_flow_action *dst,\n \tunsigned int i;\n \n \tfor (i = 0, off = 0; !num || i != num; ++i, ++src, ++dst) {\n-\t\tif ((size_t)src->type >= RTE_DIM(rte_flow_desc_action) ||\n-\t\t !rte_flow_desc_action[src->type].name)\n+\t\t/**\n+\t\t * allow PMD private flow action\n+\t\t */\n+\t\tif (((int)src->type >= 0) &&\n+\t\t ((size_t)src->type >= RTE_DIM(rte_flow_desc_action) ||\n+\t\t !rte_flow_desc_action[src->type].name))\n \t\t\treturn rte_flow_error_set\n \t\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t src, \"cannot convert unknown action type\");\n", "prefixes": [ "v5", "1/3" ] }