Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80848/?format=api
{ "id": 80848, "url": "http://patches.dpdk.org/api/patches/80848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602755228-25535-5-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602755228-25535-5-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602755228-25535-5-git-send-email-g.singh@nxp.com", "date": "2020-10-15T09:47:05", "name": "[v2,4/7] raw/dpaa2_qdma: optimize IOVA conversion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "59b55f0191a434c9a2785310e5822ac4432ee6a8", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602755228-25535-5-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 12996, "url": "http://patches.dpdk.org/api/series/12996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12996", "date": "2020-10-15T09:47:01", "name": "raw/dpaa2_qdma: driver enhancement", "version": 2, "mbox": "http://patches.dpdk.org/series/12996/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80848/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/80848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF2FCA04DB;\n\tThu, 15 Oct 2020 11:48:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2C0AD1DDB3;\n\tThu, 15 Oct 2020 11:47:26 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 3E89C1DD7E\n for <dev@dpdk.org>; Thu, 15 Oct 2020 11:47:22 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 0C9C1200574;\n Thu, 15 Oct 2020 11:47:21 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 7C93720056D;\n Thu, 15 Oct 2020 11:47:18 +0200 (CEST)", "from lsv11086.swis.cn-sha01.nxp.com (lsv11086.swis.cn-sha01.nxp.com\n [92.121.210.87])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id C473240313;\n Thu, 15 Oct 2020 11:47:14 +0200 (CEST)" ], "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "dev@dpdk.org,\n\tnipun.gupta@nxp.com,\n\themant.agrawal@nxp.com", "Cc": "thomas@monjalon.net,\n\tJun Yang <jun.yang@nxp.com>", "Date": "Thu, 15 Oct 2020 17:47:05 +0800", "Message-Id": "<1602755228-25535-5-git-send-email-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1602755228-25535-1-git-send-email-g.singh@nxp.com>", "References": "<1599470764-30569-1-git-send-email-g.singh@nxp.com>\n <1602755228-25535-1-git-send-email-g.singh@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 4/7] raw/dpaa2_qdma: optimize IOVA conversion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jun Yang <jun.yang@nxp.com>\n\nrte_mempool_virt2iova is now used for converting with IOVA off.\n\nSigned-off-by: Jun Yang <jun.yang@nxp.com>\n---\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 29 +++++++++++++++++++++++------\n drivers/raw/dpaa2_qdma/dpaa2_qdma.h | 5 +++++\n 2 files changed, 28 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\nindex 6eef7a57a..94dc7886a 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n@@ -221,7 +221,9 @@ static inline int dpdmai_dev_set_fd_lf(\n {\n \tstruct rte_qdma_rbp *rbp = &qdma_vq->rbp;\n \tstruct rte_qdma_job **ppjob;\n+\tvoid *elem;\n \tstruct qbman_fle *fle;\n+\tuint64_t elem_iova, fle_iova;\n \tint ret = 0;\n \tstruct qdma_device *qdma_dev = QDMA_DEV_OF_VQ(qdma_vq);\n \n@@ -229,19 +231,29 @@ static inline int dpdmai_dev_set_fd_lf(\n \t * Get an FLE/SDD from FLE pool.\n \t * Note: IO metadata is before the FLE and SDD memory.\n \t */\n-\tret = rte_mempool_get(qdma_dev->fle_pool, (void **)(&ppjob));\n+\tret = rte_mempool_get(qdma_dev->fle_pool, (void **)(&elem));\n \tif (ret) {\n \t\tDPAA2_QDMA_DP_DEBUG(\"Memory alloc failed for FLE\");\n \t\treturn ret;\n \t}\n \n+#ifdef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA\n+\telem_iova = rte_mempool_virt2iova(elem);\n+#else\n+\telem_iova = DPAA2_VADDR_TO_IOVA(elem);\n+#endif\n+\n \t/* Set the metadata */\n \tjob->vq_id = qdma_vq->vq_id;\n+\tppjob = (struct rte_qdma_job **)\n+\t\t((uintptr_t)(uint64_t)elem + QDMA_FLE_JOB_OFFSET);\n \t*ppjob = job;\n \n-\tfle = (struct qbman_fle *)(ppjob + 1);\n+\tfle = (struct qbman_fle *)\n+\t\t((uintptr_t)(uint64_t)elem + QDMA_FLE_FLE_OFFSET);\n+\tfle_iova = elem_iova + QDMA_FLE_FLE_OFFSET;\n \n-\tDPAA2_SET_FD_ADDR(fd, DPAA2_VADDR_TO_IOVA(fle));\n+\tDPAA2_SET_FD_ADDR(fd, fle_iova);\n \tDPAA2_SET_FD_COMPOUND_FMT(fd);\n \tDPAA2_SET_FD_FRC(fd, QDMA_SER_CTX);\n \n@@ -283,6 +295,8 @@ static inline uint16_t dpdmai_dev_get_job_lf(\n \t\t\t\t\t\tconst struct qbman_fd *fd,\n \t\t\t\t\t\tstruct rte_qdma_job **job)\n {\n+\tvoid *elem;\n+\tstruct qbman_fle *fle;\n \tstruct rte_qdma_job **ppjob;\n \tuint16_t vqid;\n \tstruct qdma_device *qdma_dev = QDMA_DEV_OF_VQ(qdma_vq);\n@@ -291,9 +305,12 @@ static inline uint16_t dpdmai_dev_get_job_lf(\n \t * Fetch metadata from FLE. job and vq_id were set\n \t * in metadata in the enqueue operation.\n \t */\n-\tppjob = (struct rte_qdma_job **)\n+\tfle = (struct qbman_fle *)\n \t\t\tDPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd));\n-\tppjob -= 1;\n+\telem = (void *)((uintptr_t)(uint64_t)fle - QDMA_FLE_FLE_OFFSET);\n+\n+\tppjob = (struct rte_qdma_job **)\n+\t\t((uintptr_t)(uint64_t)elem + QDMA_FLE_JOB_OFFSET);\n \n \t*job = (struct rte_qdma_job *)*ppjob;\n \t(*job)->status = (DPAA2_GET_FD_ERR(fd) << 8) |\n@@ -301,7 +318,7 @@ static inline uint16_t dpdmai_dev_get_job_lf(\n \tvqid = (*job)->vq_id;\n \n \t/* Free FLE to the pool */\n-\trte_mempool_put(qdma_dev->fle_pool, (void *)ppjob);\n+\trte_mempool_put(qdma_dev->fle_pool, elem);\n \n \treturn vqid;\n }\ndiff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.h b/drivers/raw/dpaa2_qdma/dpaa2_qdma.h\nindex 4265ee828..ff7743fb5 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.h\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.h\n@@ -17,6 +17,11 @@ struct rte_qdma_job;\n #define QDMA_FLE_POOL_SIZE (sizeof(struct rte_qdma_job *) + \\\n \t\tsizeof(struct qbman_fle) * DPAA2_QDMA_MAX_FLE + \\\n \t\tsizeof(struct qdma_sdd) * DPAA2_QDMA_MAX_SDD)\n+\n+#define QDMA_FLE_JOB_OFFSET 0\n+#define QDMA_FLE_FLE_OFFSET \\\n+\t\t(QDMA_FLE_JOB_OFFSET + sizeof(struct rte_qdma_job *))\n+\n /** FLE pool cache size */\n #define QDMA_FLE_CACHE_SIZE(_num) (_num/(RTE_MAX_LCORE * 2))\n \n", "prefixes": [ "v2", "4/7" ] }