Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80731/?format=api
{ "id": 80731, "url": "http://patches.dpdk.org/api/patches/80731/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602682146-4722-8-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602682146-4722-8-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602682146-4722-8-git-send-email-arybchenko@solarflare.com", "date": "2020-10-14T13:29:02", "name": "[07/11] test/bonding: check eth dev stop status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "96938db90f38c84029ec7287742e0cc0544fbed5", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602682146-4722-8-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12958, "url": "http://patches.dpdk.org/api/series/12958/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12958", "date": "2020-10-14T13:28:55", "name": "ethdev: change device stop to return status", "version": 1, "mbox": "http://patches.dpdk.org/series/12958/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80731/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/80731/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E112EA04B7;\n\tWed, 14 Oct 2020 15:31:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A02401DE2C;\n\tWed, 14 Oct 2020 15:29:29 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6A9C81DDCF\n for <dev@dpdk.org>; Wed, 14 Oct 2020 15:29:20 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 14BF3200E0; Wed, 14 Oct 2020 13:29:19 +0000 (UTC)", "from us4-mdac16-11.at1.mdlocal (unknown [10.110.49.193])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 0F878800AF;\n Wed, 14 Oct 2020 13:29:19 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.103])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 8016A100052;\n Wed, 14 Oct 2020 13:29:18 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 47257980087;\n Wed, 14 Oct 2020 13:29:18 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Wed, 14 Oct 2020 14:29:14 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Wed, 14 Oct 2020 14:29:14 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09EDTE6I009194;\n Wed, 14 Oct 2020 14:29:14 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 20C441613A9;\n Wed, 14 Oct 2020 14:29:14 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Chas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Wed, 14 Oct 2020 14:29:02 +0100", "Message-ID": "<1602682146-4722-8-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602682146-4722-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602682146-4722-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25724.003", "X-TM-AS-Result": "No-4.089200-8.000000-10", "X-TMASE-MatchedRID": "cxaTYRzWUivRlxaUc/KTYX4neC0h7SAD3V4UShoTXaeYkF7ZtFfCU0kx\n APClfhN0YHB0GcKFMltFdYu4cV7ttyHhSBQfglfsA9lly13c/gHVoHA9HwvQm5wsUqEjZnPr2VC\n 1QWKKKPoRtfYWlraBqb5XOALI4JsjBOatfChdjHspJ8SpVT9O/3607foZgOWyJmE4A+qD79lZru\n EoKvBZSdXn8fbOSyKigF2CU61NPqQfE8yM4pjsDwtuKBGekqUpm+MB6kaZ2g7eWeTngWZnHRf+g\n QU4ZiK245RtQqwkfAAMHRdGyc5Bo65KZDnh0cOvqOA9Bck2vxPPPacHi4DkkHzd5FVSeyJMhNKJ\n okIvZoPkA8OrYHdwDGfYlY/yoV/0Up6EHOb2+c7kHZDO53QSwjflzkGcoK72", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.089200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25724.003", "X-MDID": "1602682159-Jk0aP0AKZeYK", "X-PPE-DISP": "1602682159;Jk0aP0AKZeYK", "Subject": "[dpdk-dev] [PATCH 07/11] test/bonding: check eth dev stop status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_dev_stop() return value was changed from void to int,\nso this patch modify usage of this function across test/bonding\naccording to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test/test_link_bonding.c | 42 +++++++++++++++++++++-------\n app/test/test_link_bonding_mode4.c | 8 ++++--\n app/test/test_link_bonding_rssconf.c | 3 +-\n 3 files changed, 40 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c\nindex 3a46f943f1..e8b76bd850 100644\n--- a/app/test/test_link_bonding.c\n+++ b/app/test/test_link_bonding.c\n@@ -613,7 +613,9 @@ test_stop_bonded_device(void)\n \tstruct rte_eth_link link_status;\n \tint retval;\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tretval = rte_eth_link_get(test_params->bonded_port_id, &link_status);\n \tTEST_ASSERT(retval >= 0,\n@@ -647,7 +649,10 @@ remove_slaves_and_stop_bonded_device(void)\n \t\tTEST_ASSERT_SUCCESS(test_remove_slave_from_bonded_device(),\n \t\t\t\t\"test_remove_slave_from_bonded_device failed\");\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n+\n \trte_eth_stats_reset(test_params->bonded_port_id);\n \trte_eth_bond_mac_address_reset(test_params->bonded_port_id);\n \n@@ -755,7 +760,9 @@ test_set_primary_slave(void)\n \t\t\t\ttest_params->slave_port_ids[i]);\n \n \t\t/* stop/start bonded eth dev to apply new MAC */\n-\t\trte_eth_dev_stop(test_params->bonded_port_id);\n+\t\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\t\ttest_params->bonded_port_id);\n \n \t\tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\t\"Failed to start bonded port %d\",\n@@ -1024,7 +1031,10 @@ test_set_bonded_port_initialization_mac_assignment(void)\n \t\t\tslave_port_ids[2]),\n \t\t\t\"failed to set primary port on bonded device.\");\n \n-\trte_eth_dev_stop(bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\tbonded_port_id);\n+\n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(bonded_port_id),\n \t\t\t\t\"Failed to start bonded pmd eth device %d.\",\n \t\t\t\tbonded_port_id);\n@@ -1063,7 +1073,9 @@ test_set_bonded_port_initialization_mac_assignment(void)\n \t * b - remove slave ethdevs\n \t * c - Verify slave ethdevs MACs are restored\n \t */\n-\trte_eth_dev_stop(bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\tbonded_port_id);\n \n \tfor (i = 0; i < BONDED_INIT_MAC_ASSIGNMENT_SLAVE_COUNT; i++) {\n \t\tTEST_ASSERT_SUCCESS(rte_eth_bond_slave_remove(bonded_port_id,\n@@ -1769,7 +1781,9 @@ test_roundrobin_verify_mac_assignment(void)\n \n \t/* stop / start bonded device and verify that primary MAC address is\n \t * propagate to bonded device and slaves */\n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\"Failed to start bonded device\");\n@@ -2404,7 +2418,9 @@ test_activebackup_verify_mac_assignment(void)\n \t/* stop / start bonded device and verify that primary MAC address is\n \t * propagated to bonded device and slaves */\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\"Failed to start device\");\n@@ -3335,7 +3351,9 @@ test_balance_verify_mac_assignment(void)\n \t/* stop / start bonded device and verify that primary MAC address is\n \t * propagated to bonded device and slaves */\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\"Failed to start bonded device\");\n@@ -3932,7 +3950,9 @@ test_broadcast_verify_mac_assignment(void)\n \t/* stop / start bonded device and verify that primary MAC address is\n \t * propagated to bonded device and slaves */\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\"Failed to start bonded device\");\n@@ -4472,7 +4492,9 @@ test_tlb_verify_mac_assignment(void)\n \t/* stop / start bonded device and verify that primary MAC address is\n \t * propagated to bonded device and slaves */\n \n-\trte_eth_dev_stop(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params->bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params->bonded_port_id);\n \n \tTEST_ASSERT_SUCCESS(rte_eth_dev_start(test_params->bonded_port_id),\n \t\t\t\"Failed to start device\");\ndiff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex cf12f026dd..2c835fa7ad 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -355,7 +355,9 @@ remove_slaves_and_stop_bonded_device(void)\n \tuint16_t slaves[RTE_MAX_ETHPORTS];\n \tuint16_t i;\n \n-\trte_eth_dev_stop(test_params.bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params.bonded_port_id),\n+\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\ttest_params.bonded_port_id);\n \n \tFOR_EACH_SLAVE(i, slave)\n \t\tremove_slave(slave);\n@@ -368,7 +370,9 @@ remove_slaves_and_stop_bonded_device(void)\n \t\t\ttest_params.bonded_port_id, retval);\n \n \tFOR_EACH_PORT(i, slave) {\n-\t\trte_eth_dev_stop(slave->port_id);\n+\t\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(slave->port_id),\n+\t\t\t\t\"Failed to stop bonded port %u\",\n+\t\t\t\tslave->port_id);\n \n \t\tTEST_ASSERT(slave->bonded == 0,\n \t\t\t\"Port id=%u is still marked as enslaved.\", slave->port_id);\ndiff --git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c\nindex 1a9571e5c6..5dac60ca1e 100644\n--- a/app/test/test_link_bonding_rssconf.c\n+++ b/app/test/test_link_bonding_rssconf.c\n@@ -176,7 +176,8 @@ static int\n remove_slaves_and_stop_bonded_device(void)\n {\n \tTEST_ASSERT_SUCCESS(remove_slaves(), \"Removing slaves\");\n-\trte_eth_dev_stop(test_params.bond_port_id);\n+\tTEST_ASSERT_SUCCESS(rte_eth_dev_stop(test_params.bond_port_id),\n+\t\t\t\"Failed to stop port %u\", test_params.bond_port_id);\n \treturn TEST_SUCCESS;\n }\n \n", "prefixes": [ "07/11" ] }