Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80703/?format=api
{ "id": 80703, "url": "http://patches.dpdk.org/api/patches/80703/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201014091945.1934-3-stevex.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201014091945.1934-3-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201014091945.1934-3-stevex.yang@intel.com", "date": "2020-10-14T09:19:42", "name": "[v5,2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0c4c97d7f76ddb991b2a71fc46080b27abbdf919", "submitter": { "id": 1883, "url": "http://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201014091945.1934-3-stevex.yang@intel.com/mbox/", "series": [ { "id": 12947, "url": "http://patches.dpdk.org/api/series/12947/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12947", "date": "2020-10-14T09:19:40", "name": "fix default max mtu size when device configured", "version": 5, "mbox": "http://patches.dpdk.org/series/12947/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80703/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/80703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC0CCA04B7;\n\tWed, 14 Oct 2020 11:22:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 149251DD72;\n\tWed, 14 Oct 2020 11:21:31 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 3BA7E1DD36\n for <dev@dpdk.org>; Wed, 14 Oct 2020 11:21:29 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Oct 2020 02:21:28 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Oct 2020 02:21:26 -0700" ], "IronPort-SDR": [ "\n hagoZvryUb3VCjwYuJyra4hQH4uGdmlkFDuYGTH/fivhRJd03Z2euL6BoMdUsY/gJUTcIv6ct0\n pZly9bKDIkVw==", "\n YdsVgwn/esEa0wddY1o9rMATZM42s951QfCccP5L37E32GBVMPg05X6eeshhkE8+l3dJzxnhVA\n X+E6NYU2pzKA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9773\"; a=\"183585319\"", "E=Sophos;i=\"5.77,374,1596524400\"; d=\"scan'208\";a=\"183585319\"", "E=Sophos;i=\"5.77,374,1596524400\"; d=\"scan'208\";a=\"530752296\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "jia.guo@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com,\n jingjing.wu@intel.com, beilei.xing@intel.com, konstantin.ananyev@intel.com,\n SteveX Yang <stevex.yang@intel.com>", "Date": "Wed, 14 Oct 2020 09:19:42 +0000", "Message-Id": "<20201014091945.1934-3-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201014091945.1934-1-stevex.yang@intel.com>", "References": "<20200928065541.7520-1-stevex.yang@intel.com>\n <20201014091945.1934-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 2/5] net/igc: fix max mtu size packets with\n\tvlan tag cannot be received by default", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "when application presets the max rx packet length and expected mtu at\nthe same time, driver need identify if the preset max frame size can\nhold mtu data and Ether overhead completely.\n\nif not, adjust the max frame size via mtu_set ops within dev_configure.\n\nFixes: a5aeb2b9e225 (\"net/igc: support Rx and Tx\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/igc/igc_ethdev.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 7f5066df4..98e98b3e4 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -337,11 +337,22 @@ static int\n eth_igc_configure(struct rte_eth_dev *dev)\n {\n \tstruct igc_interrupt *intr = IGC_DEV_PRIVATE_INTR(dev);\n+\tuint32_t frame_size = dev->data->mtu + IGC_ETH_OVERHEAD;\n \tint ret;\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tret = igc_check_mq_mode(dev);\n+\t/**\n+\t * Reset the max frame size via mtu_set ops if preset max frame\n+\t * cannot hold MTU data and Ether overhead.\n+\t */\n+\tif (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {\n+\t\tret = eth_igc_mtu_set(dev, dev->data->mtu);\n+\t\tif (ret != 0)\n+\t\t\treturn ret;\n+\t}\n+\n+\tret = igc_check_mq_mode(dev);\n \tif (ret != 0)\n \t\treturn ret;\n \n", "prefixes": [ "v5", "2/5" ] }