Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80523/?format=api
{ "id": 80523, "url": "http://patches.dpdk.org/api/patches/80523/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-6-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602596753-32282-6-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602596753-32282-6-git-send-email-arybchenko@solarflare.com", "date": "2020-10-13T13:45:22", "name": "[05/36] common/sfc_efx/base: fix PHY config failure on Riverhead", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d386962b223cb007c9adfe725da9bf4d0d973352", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-6-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12916, "url": "http://patches.dpdk.org/api/series/12916/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12916", "date": "2020-10-13T13:45:18", "name": "net/sfc: add EF100 support", "version": 1, "mbox": "http://patches.dpdk.org/series/12916/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80523/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/80523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E22A2A04B7;\n\tTue, 13 Oct 2020 15:51:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68CEA1DBE4;\n\tTue, 13 Oct 2020 15:46:27 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id DB9961DB64\n for <dev@dpdk.org>; Tue, 13 Oct 2020 15:46:04 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n BC70420087 for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from us4-mdac16-70.at1.mdlocal (unknown [10.110.50.188])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id B9A39800A4\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.106])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 46B6840070\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 10F3FB40053\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 13 Oct 2020 14:45:56 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09DDjtJM006001\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 819651613A9\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 13 Oct 2020 14:45:22 +0100", "Message-ID": "<1602596753-32282-6-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-TM-AS-Result": "No-0.724900-8.000000-10", "X-TMASE-MatchedRID": "etdF63qa72LXzzB1gl4n6hMXUu1hb2Vry733NwuklsK8YDH/UBNnm+Z5\n Gn23AeDZuA9fFHhyLzxajR+Ehbyh3yxppiUy9o4cA9lly13c/gF9LQinZ4QefPcjNeVeWlqY+gt\n Hj7OwNO3x/F0UMEoTu6+aUruJq/iIZknOS76xfgoDvSO9JNum4wS6Ev3Usx38Tn6B/xU5F7IIII\n wJXCuS6TWEe8r2X8GA4z734sO+DCON2+/l3xAHHgAD0FqlZdom0b4rJ92tmtF/d7a9VsfzMCmt4\n /F9KOV7", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--0.724900-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-MDID": "1602596761-5qYF8ERBkeX6", "X-PPE-DISP": "1602596761;5qYF8ERBkeX6", "Subject": "[dpdk-dev] [PATCH 05/36] common/sfc_efx/base: fix PHY config\n\tfailure on Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Riverhead does not support LED control yet. It is perfectly\nfine to ignore LED set failure because of no support if\nconfigured LED mode is the default.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_phy.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_phy.c b/drivers/common/sfc_efx/base/ef10_phy.c\nindex 3d07c254bf..74a18841d9 100644\n--- a/drivers/common/sfc_efx/base/ef10_phy.c\n+++ b/drivers/common/sfc_efx/base/ef10_phy.c\n@@ -530,8 +530,16 @@ ef10_phy_reconfigure(\n #endif\n \n \trc = efx_mcdi_phy_set_led(enp, phy_led_mode);\n-\tif (rc != 0)\n+\tif (rc != 0) {\n+\t\t/*\n+\t\t * If LED control is not supported by firmware, we can\n+\t\t * silently ignore default mode set failure\n+\t\t * (see FWRIVERHD-198).\n+\t\t */\n+\t\tif (rc == EOPNOTSUPP && phy_led_mode == EFX_PHY_LED_DEFAULT)\n+\t\t\tgoto out;\n \t\tgoto fail3;\n+\t}\n \n out:\n \treturn (0);\n", "prefixes": [ "05/36" ] }