Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80384/?format=api
{ "id": 80384, "url": "http://patches.dpdk.org/api/patches/80384/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602519585-5194-10-git-send-email-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602519585-5194-10-git-send-email-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602519585-5194-10-git-send-email-viacheslavo@nvidia.com", "date": "2020-10-12T16:19:45", "name": "[v3,9/9] net/mlx5: update Rx datapath to support split", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0935ca117cccec50681c7031296f68605ff473e7", "submitter": { "id": 1926, "url": "http://patches.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602519585-5194-10-git-send-email-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 11673, "url": "http://patches.dpdk.org/api/series/11673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11673", "date": "2020-08-17T17:49:38", "name": "[RFC] ethdev: introduce Rx buffer split", "version": 1, "mbox": "http://patches.dpdk.org/series/11673/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80384/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/80384/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D26FA04B6;\n\tMon, 12 Oct 2020 18:21:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 024131D94E;\n\tMon, 12 Oct 2020 18:20:03 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 4DB761D933\n for <dev@dpdk.org>; Mon, 12 Oct 2020 18:19:52 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@nvidia.com) with SMTP; 12 Oct 2020 19:19:46 +0300", "from nvidia.com (pegasus12.mtr.labs.mlnx [10.210.17.40])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09CGJjKQ017440;\n Mon, 12 Oct 2020 19:19:46 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomasm@monjalon.net, stephen@networkplumber.org, ferruh.yigit@intel.com,\n olivier.matz@6wind.com, jerinjacobk@gmail.com,\n maxime.coquelin@redhat.com, david.marchand@redhat.com,\n arybchenko@solarflare.com", "Date": "Mon, 12 Oct 2020 16:19:45 +0000", "Message-Id": "<1602519585-5194-10-git-send-email-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602519585-5194-1-git-send-email-viacheslavo@nvidia.com>", "References": "\n <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>\n <1602519585-5194-1-git-send-email-viacheslavo@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v3 9/9] net/mlx5: update Rx datapath to support\n\tsplit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Only the regular rx_burst routine is updated to support split,\nbecause the vectorized ones does not support scatter and MPRQ\ndoes not support split at all.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 11 +++++------\n drivers/net/mlx5/mlx5_rxtx.c | 3 ++-\n 2 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 4ec4677..2ebb265 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -210,9 +210,10 @@\n \n \t/* Iterate on segments. */\n \tfor (i = 0; (i != elts_n); ++i) {\n+\t\tstruct rte_eth_rxseg *seg = &rxq_ctrl->rxq.rxseg[i % sges_n];\n \t\tstruct rte_mbuf *buf;\n \n-\t\tbuf = rte_pktmbuf_alloc(rxq_ctrl->rxq.mp);\n+\t\tbuf = rte_pktmbuf_alloc(seg->mp);\n \t\tif (buf == NULL) {\n \t\t\tDRV_LOG(ERR, \"port %u empty mbuf pool\",\n \t\t\t\tPORT_ID(rxq_ctrl->priv));\n@@ -225,12 +226,10 @@\n \t\tMLX5_ASSERT(rte_pktmbuf_data_len(buf) == 0);\n \t\tMLX5_ASSERT(rte_pktmbuf_pkt_len(buf) == 0);\n \t\tMLX5_ASSERT(!buf->next);\n-\t\t/* Only the first segment keeps headroom. */\n-\t\tif (i % sges_n)\n-\t\t\tSET_DATA_OFF(buf, 0);\n+\t\tSET_DATA_OFF(buf, seg->offset);\n \t\tPORT(buf) = rxq_ctrl->rxq.port_id;\n-\t\tDATA_LEN(buf) = rte_pktmbuf_tailroom(buf);\n-\t\tPKT_LEN(buf) = DATA_LEN(buf);\n+\t\tDATA_LEN(buf) = seg->length;\n+\t\tPKT_LEN(buf) = seg->length;\n \t\tNB_SEGS(buf) = 1;\n \t\t(*rxq_ctrl->rxq.elts)[i] = buf;\n \t}\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex b530ff4..dd84249 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -1334,7 +1334,8 @@ enum mlx5_txcmp_code {\n \t\trte_prefetch0(seg);\n \t\trte_prefetch0(cqe);\n \t\trte_prefetch0(wqe);\n-\t\trep = rte_mbuf_raw_alloc(rxq->mp);\n+\t\t/* Allocate the buf from the same pool. */\n+\t\trep = rte_mbuf_raw_alloc(seg->pool);\n \t\tif (unlikely(rep == NULL)) {\n \t\t\t++rxq->stats.rx_nombuf;\n \t\t\tif (!pkt) {\n", "prefixes": [ "v3", "9/9" ] }