Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80275/?format=api
{ "id": 80275, "url": "http://patches.dpdk.org/api/patches/80275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net>", "list_archive_url": "https://inbox.dpdk.org/dev/96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net", "date": "2020-10-10T10:20:09", "name": "net/bonding: LACP Packet statistics support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "df933bf99f97a7067cbc759501cac2875416eed7", "submitter": { "id": 1676, "url": "http://patches.dpdk.org/api/people/1676/?format=api", "name": "Kiran KN", "email": "kirankn@juniper.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net/mbox/", "series": [ { "id": 12859, "url": "http://patches.dpdk.org/api/series/12859/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12859", "date": "2020-10-10T10:20:09", "name": "net/bonding: LACP Packet statistics support", "version": 1, "mbox": "http://patches.dpdk.org/series/12859/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80275/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/80275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24931A04B1;\n\tSat, 10 Oct 2020 12:20:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D364E1D8CE;\n\tSat, 10 Oct 2020 12:20:16 +0200 (CEST)", "from mx0b-00273201.pphosted.com (mx0a-00273201.pphosted.com\n [208.84.65.16]) by dpdk.org (Postfix) with ESMTP id 44F511D6E2\n for <dev@dpdk.org>; Sat, 10 Oct 2020 12:20:15 +0200 (CEST)", "from pps.filterd (m0108157.ppops.net [127.0.0.1])\n by mx0a-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 09AAKBAP009669; Sat, 10 Oct 2020 03:20:11 -0700", "from nam10-mw2-obe.outbound.protection.outlook.com\n (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103])\n by mx0a-00273201.pphosted.com with ESMTP id 34355ug8xr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 10 Oct 2020 03:20:11 -0700", "from MWHPR0501MB3755.namprd05.prod.outlook.com\n (2603:10b6:301:7d::23) by MWHPR0501MB3756.namprd05.prod.outlook.com\n (2603:10b6:301:7a::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.11; Sat, 10 Oct\n 2020 10:20:10 +0000", "from MWHPR0501MB3755.namprd05.prod.outlook.com\n ([fe80::8104:6667:3757:e1f]) by MWHPR0501MB3755.namprd05.prod.outlook.com\n ([fe80::8104:6667:3757:e1f%6]) with mapi id 15.20.3477.014; Sat, 10 Oct 2020\n 10:20:10 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net;\n h=from : to : cc :\n subject : date : message-id : content-type : content-id :\n content-transfer-encoding : mime-version; s=PPS1017;\n bh=EfehTwwQxzzp1Bkq/wAQa9ZuFwKzM9HKQKycusgECSg=;\n b=LS8JKnCK6zle38cFoKzy51/CTbJQaWt58MFJwaza2LOYlcpAayHMdr/P5ObxRaZv62pw\n 4qzAwPK4fS8FaOA6nHetFDsO4MoCPwzia5PDBIbZIwhX5zYZX+mv8FaW+EeWF0OJ4/87\n B80R0GCvw7jdkQ0MALlfGl8O8ZUcrTSp4EwhyCiEaj4tBM93eMPrliLA+mcWyhLBSalY\n em6/6Jf/W2z70bRL/5fjm9bs+qXM9/xFM3HjJ9fYnkuLj6X7tqSjpvzhjWi40oAzT6DW\n Zu48hc0Sv0s3FyZccgJgZinttfm1Op7AQnjNHcEFcfEffVRNIWiExAMc3sJMxTLscn5y cQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EfehTwwQxzzp1Bkq/wAQa9ZuFwKzM9HKQKycusgECSg=;\n b=jYd+d/NJmcx96j86hLjSdXIvLUooX59UU1VcjEYD9g1USE0mkScnyio13ozJo1KXncLDjxPMsE+bb8vR4aDhwj+jrgLooCjQIesYy8gx6nGwhxsJn8ShPr/FjuyU6E7oPgupswd94+S+wBYD7b1BemcFk4QLRaEaJ7BHaSMhcjs=" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CL9YaGlKZJRssVJrJV24HcF2qOUoZp9iQs5408xetY7CLNT9oTRS9StaXRwX6HsdSmkOjr812IpqQMjQCicYXhTfoR2T5rTPj/st50Pg/AwfoZq5ZHFvWBiA4OcZxdvucXe4daoJvm/tafSFxaU2/P0zACflM1T7AqDBi3MWjJOE8VcuSbngXTAkW8FWxudAKEqd7dEtNA3ukpP2NKeWBo47AgHGDzze8A4D5tZpNNzapvItzbseo3kw+SqmmaahPakXE4108N+ScVQJ4EOSyyBvtrCPG3RqG6AnOjpkEVUhvfuMPAMUdPlx88MY4VTwjRYsrEoKqKOvOszeKuqINQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EfehTwwQxzzp1Bkq/wAQa9ZuFwKzM9HKQKycusgECSg=;\n b=VF/iAlGa0Oa5qM6pNmosbUB3IbtP5ouhEXL34s/paP47scxvmsYwjkxqbW+380Lx2xEMkzr+BXOw13pbibRD07NY4O48g8BG4qER2iN17MlJkaTTw4FUJ6SxwktrLGaQDVVcmYy6pTAdmfLHe85PutydD80Ya/lUHwhfodnbf2brT/OnwmixhUCJVgGEQvxTfQC66qfYKB+nAc8B80Nt0Wlw47qjLti5iTQjBz/5DRT2JZ9c5kpGwgFAocISqCcUVAU02j0QhAuaNxVe6YRN3/OAm2f0uScYZZBY2doAavXybprQiQFUt6JtESFK/Hoxj0IeFAXjxsj9xD8CVTvKYw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net;\n dkim=pass header.d=juniper.net; arc=none", "From": "Kiran KN <kirankn@juniper.net>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"chas3@att.com\" <chas3@att.com>, David Marchand\n <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net>", "Thread-Topic": "[PATCH] net/bonding: LACP Packet statistics support", "Thread-Index": "AQHWnu7u/qkHDC6FoUq9fev5YlPRmQ==", "Date": "Sat, 10 Oct 2020 10:20:09 +0000", "Message-ID": "<96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "user-agent": "Microsoft-MacOutlook/16.41.20091302", "msip_labels": "MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=abec7c70-7bf9-4709-9c42-52e47e3c57cb;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2020-10-10T10:17:25Z;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard;\n MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=Juniper\n Business Use\n Only;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;", "authentication-results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=juniper.net;", "x-originating-ip": "[116.197.184.11]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "6cbdf3e1-38da-491f-d72c-08d86d06115e", "x-ms-traffictypediagnostic": "MWHPR0501MB3756:", "x-microsoft-antispam-prvs": "\n <MWHPR0501MB37568EB8978B9D5166A96632AE090@MWHPR0501MB3756.namprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:2958;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n pO5Jp5af/i2m4o1zHzGxZt5XdDDo49z3kw9FfhXroptNTClEAgqjtrmDse4r7RRGs/D0QxZTzoKLe2NHo+UO4MzRkOFaVytprtwqoRm9bzBKzCNFEgogJxdDpkM+WnBpVzl2HcCk2sT8CELdT/244QsR9HbO09YJPuil1nJvxqScy9iS6IFLMtRqol2Co2dDD2b+0je93H4wLSEsnrVJupSW/MCDKYlSp2+c61Cgsh30iY6Xbx61UC8MhlgfwSb8sHVsrwgTPdkJnJhw8mTR6st3HxyRCzYed4LXInAWD6QjQLBndIKIeWiKqlohVqASzz7FI8OQpg1z+o2sdWG/MA==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MWHPR0501MB3755.namprd05.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(4636009)(346002)(136003)(376002)(366004)(39860400002)(396003)(76116006)(91956017)(66476007)(6916009)(8936002)(26005)(64756008)(186003)(66446008)(478600001)(66556008)(36756003)(66946007)(83380400001)(6506007)(6486002)(4326008)(33656002)(5660300002)(2616005)(8676002)(54906003)(86362001)(316002)(6512007)(71200400001)(2906002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n T/LCwaeqO2KzQnp4YOBoz5OcOadI9G6vAtUJeYwwIcv7zNOfEudzKucdbNWMfScZrMMiYWuR7Unqae3CydtOaw7Z5YOmxLpSyjTlAjoVEOhA2X4q1u8ly+PuZmEkV8k64QeFgi0C7vlBDY4qK9m97wrQ2hkA/CHKXX64OjCA/v6rG30G943MIo7mvQRD0pNPAIvGO6aJBEUseBrKObBSZSumzQOjkfLCJ8cbfyAMhiYQCdC+eeLlJ/f1yBhllyyGUsLrBpZvRNIIJlNXhY0obTiP4Iog0LArWAGLBlKwA/Ruq0HEM4CdUh1DAz0pWLPPqUonFWvp/nXgnVim1c5RLHlTOm2LE2pytJGQJNbqYh5BxVnMm/TPFbhw5rPaKUBQLXU14K6KYAvyR0uh2mn/R/cR/AWvznP53/bMtra935gBQmKvNJP2KqwvLrcBABQOpe9quBt2UwapFoEvaHC7WpcULZXfBFmS7wIJqyVxCgCuwxysPLPshcrka3G85EFs3INyMs0FKX9v/QGPK7oVI0raER97ra/WN0R9ohKnA30EmXVLEsNkLkNEaxsP8AC1Q6nyNmkmOKtYiRj/BdPt09aMCG9IouDn6BT35bbYAjQF1Y5Vrb473v70pbR7MEZMwdPKWJXQ/w+G4HHCJk+M1w==", "x-ms-exchange-transport-forked": "True", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-ID": "<C3C3A60D0052CB42A3D87762DF8E8F40@namprd05.prod.outlook.com>", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "juniper.net", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "\n MWHPR0501MB3755.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6cbdf3e1-38da-491f-d72c-08d86d06115e", "X-MS-Exchange-CrossTenant-originalarrivaltime": "10 Oct 2020 10:20:10.0415 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "bea78b3c-4cdb-4130-854a-1d193232e5f4", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 2Fexxi+KF3ShODx0EOYpuwmuOiWUyYBmXJzJl/fqpxuy1XqusVNeM4TMYPb4nvKhXva/2HvzD+Af3y5xnkOxwQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR0501MB3756", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-10-10_04:2020-10-09,\n 2020-10-10 signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_spam_notspam policy=outbound_spam\n score=0 mlxlogscore=999\n mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0\n impostorscore=0 clxscore=1011 bulkscore=0 phishscore=0 lowpriorityscore=0\n priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2009150000 definitions=main-2010100096", "Subject": "[dpdk-dev] [PATCH] net/bonding: LACP Packet statistics support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "net/bonding: LACP Packet statistics support\n\nStore the LACP packets sent and received for each slave.\nThis can be used for debug purposes from any DPDK application.\n\nSigned-Off-By: Kiran K N <kirankn@juniper.net>\n\nChange-Id: Iae82bd7d0879a4c4333a292c96d431798c56e301\n---\n drivers/net/bonding/eth_bond_8023ad_private.h | 2 ++\n drivers/net/bonding/rte_eth_bond_8023ad.c | 39 +++++++++++++++++++++++++++\n drivers/net/bonding/rte_eth_bond_8023ad.h | 20 ++++++++++++++\n 3 files changed, 61 insertions(+)\n\n--\n2.16.6\n\n\n\nJuniper Business Use Only", "diff": "diff --git a/drivers/net/bonding/eth_bond_8023ad_private.h b/drivers/net/bonding/eth_bond_8023ad_private.h\r\nindex ef0b56850..500640b28 100644\r\n--- a/drivers/net/bonding/eth_bond_8023ad_private.h\r\n+++ b/drivers/net/bonding/eth_bond_8023ad_private.h\r\n@@ -19,6 +19,8 @@\r\n #define BOND_MODE_8023AX_SLAVE_RX_PKTS 3\r\n /** Maximum number of LACP packets from one slave queued in TX ring. */\r\n #define BOND_MODE_8023AX_SLAVE_TX_PKTS 1\r\n+/** maximum number of slaves for each port */\r\n+#define BOND_MODE_8023AD_MAX_SLAVES 6\r\n /**\r\n * Timeouts deffinitions (5.4.4 in 802.1AX documentation).\r\n */\r\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\r\nindex ea79a1344..37eb29847 100644\r\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\r\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\r\n@@ -132,6 +132,9 @@ static const struct rte_ether_addr lacp_mac_addr = {\r\n\r\n struct port bond_mode_8023ad_ports[RTE_MAX_ETHPORTS];\r\n\r\n+static uint64_t lacpdu_tx_count[BOND_MODE_8023AD_MAX_SLAVES];\r\n+static uint64_t lacpdu_rx_count[BOND_MODE_8023AD_MAX_SLAVES];\r\n+\r\n static void\r\n timer_cancel(uint64_t *timer)\r\n {\r\n@@ -629,6 +632,7 @@ tx_machine(struct bond_dev_private *internals, uint16_t slave_id)\r\n set_warning_flags(port, WRN_TX_QUEUE_FULL);\r\n return;\r\n }\r\n+lacpdu_tx_count[slave_id]++;\r\n } else {\r\n uint16_t pkts_sent = rte_eth_tx_burst(slave_id,\r\n internals->mode4.dedicated_queues.tx_qid,\r\n@@ -638,6 +642,7 @@ tx_machine(struct bond_dev_private *internals, uint16_t slave_id)\r\n set_warning_flags(port, WRN_TX_QUEUE_FULL);\r\n return;\r\n }\r\n+lacpdu_tx_count[slave_id] += pkts_sent;\r\n }\r\n\r\n\r\n@@ -896,6 +901,10 @@ bond_mode_8023ad_periodic_cb(void *arg)\r\n lacp_pkt = NULL;\r\n\r\n rx_machine_update(internals, slave_id, lacp_pkt);\r\n+\r\n+if (retval == 0) {\r\n+ lacpdu_rx_count[slave_id]++;\r\n+ }\r\n } else {\r\n uint16_t rx_count = rte_eth_rx_burst(slave_id,\r\n internals->mode4.dedicated_queues.rx_qid,\r\n@@ -906,6 +915,8 @@ bond_mode_8023ad_periodic_cb(void *arg)\r\n slave_id, lacp_pkt);\r\n else\r\n rx_machine_update(internals, slave_id, NULL);\r\n+\r\n+lacpdu_rx_count[slave_id] += rx_count;\r\n }\r\n\r\n periodic_machine(internals, slave_id);\r\n@@ -1715,3 +1726,31 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)\r\n\r\n return retval;\r\n }\r\n+\r\n+uint64_t\r\n+rte_eth_bond_8023ad_lacp_tx_count(uint16_t port_id, uint8_t clear)\r\n+{\r\n+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)\r\n+return -1;\r\n+\r\n+if(clear) {\r\n+lacpdu_tx_count[port_id] = 0;\r\n+return 0;\r\n+}\r\n+\r\n+ return lacpdu_tx_count[port_id];\r\n+}\r\n+\r\n+uint64_t\r\n+rte_eth_bond_8023ad_lacp_rx_count(uint16_t port_id, uint8_t clear)\r\n+{\r\n+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)\r\n+return -1;\r\n+\r\n+if(clear) {\r\n+lacpdu_rx_count[port_id] = 0;\r\n+return 0;\r\n+}\r\n+\r\n+return lacpdu_rx_count[port_id];\r\n+}\r\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h\r\nindex 5623e1424..7163de381 100644\r\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.h\r\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h\r\n@@ -340,4 +340,24 @@ rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id,\r\n */\r\n int\r\n rte_eth_bond_8023ad_ext_set_fast(uint16_t port_id, uint16_t slave_id);\r\n+\r\n+/**\r\n+ * Get Lacp statistics counter for slaves\r\n+ * @param port_id Bonding slave device id\r\n+ * @param clear, reset statistics\r\n+ * @return\r\n+ * 0 on success, negative value otherwise\r\n+ */\r\n+uint64_t\r\n+rte_eth_bond_8023ad_lacp_tx_count(uint16_t port_id, uint8_t clear);\r\n+\r\n+/**\r\n+ * Get Lacp statistics counter for slaves\r\n+ * @param port_id Bonding slave device id\r\n+ * @param clear, reset statistics\r\n+ * @return\r\n+ * 0 on success, negative value otherwise\r\n+ */\r\n+uint64_t\r\n+rte_eth_bond_8023ad_lacp_rx_count(uint16_t port_id, uint8_t clear);\r\n #endif /* RTE_ETH_BOND_8023AD_H_ */\r\n", "prefixes": [] }