Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80222/?format=api
{ "id": 80222, "url": "http://patches.dpdk.org/api/patches/80222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201009213855.17933-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201009213855.17933-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201009213855.17933-12-stephen@networkplumber.org", "date": "2020-10-09T21:38:49", "name": "[v4,11/17] app: replace references to master/slave", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7bb5067f294422dc5d701381912a3d4cf1b9d4f0", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201009213855.17933-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 12839, "url": "http://patches.dpdk.org/api/series/12839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12839", "date": "2020-10-09T21:38:38", "name": "Replace terms master/slave", "version": 4, "mbox": "http://patches.dpdk.org/series/12839/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80222/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/80222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 530DAA04BC;\n\tFri, 9 Oct 2020 23:42:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D5341D5FB;\n\tFri, 9 Oct 2020 23:39:27 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id C1D2B1D5C6\n for <dev@dpdk.org>; Fri, 9 Oct 2020 23:39:17 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id g9so8280217pgh.8\n for <dev@dpdk.org>; Fri, 09 Oct 2020 14:39:17 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x18sm12173381pfj.90.2020.10.09.14.39.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 09 Oct 2020 14:39:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=0AlVKZj0bR5VRVreZ7figZ6kQQFr03w3B16mpwZx6c4=;\n b=KTDekm9RM79qhlC4ifYa6eVFQtKNv3RdO8T0gnK/One5NULV5dW/IzDsdKshvN+Ubg\n Mdu0Ojz3TLiTaiwThYYnmbMIL9jPwxTTNtYEXgYv83312JNskUyt4hNuX4aps9VukRBb\n cYqkL3oE8BJznclIruB3NFL4Th+0GaE1MwPNVnb5A3FF4uHKsE8sZUnXDPX5qcrbpsjn\n l3uP2VMzujvf7e6PBsee3zZNDonGvvEqcaDXiNZbSppE5/hngABFkMiAXIfujXc21WQV\n NZ7GQ2ct4+UZnioHQ9P1oSI/x5NDsQAWhHdhnjOmUUgnM7xmoA0aXO0MpRkJQqluXtr6\n ZKAg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=0AlVKZj0bR5VRVreZ7figZ6kQQFr03w3B16mpwZx6c4=;\n b=OSw4TPgIODJ7CpaQaMpbF/khJXdePss6s8w9lB3TRglcCcdKjV1B+khMkHWUn2SSbn\n 1pNrR34Mig45rKTHedw6b8UPChgN65/gHTq6tyHvC0NfxVPkIv5W63vHJ+vyZr24ha1N\n TVhEX2JD8RrYoy7bCenUJPPQGUF83okqtks54ljydCFas2iSQhr1wFxRqJX/SsxqEzk2\n epbR+cZtG5+oPq47lH+S4+XadmOf/6XyU5wyah2c/LA5BlMciwrhQ2TLOnzeGI1Qetux\n +tJskJq3HByCNrRh1nedL583RlXXRYcn8LUXcEDHKRJyiyuLAcyWv6Ml1AaL/NsfAiBt\n YijA==", "X-Gm-Message-State": "AOAM533Mek841rNfUEcE2uMCtsCSkQ5M+/aj0oeJgjVZ9ZuOtMYt0O4I\n yuU+5EOW125yKM5WGUEppEbJT6MCO3meiw==", "X-Google-Smtp-Source": "\n ABdhPJx9FFlQI9z4y8QriVtfRPpBXhwu/vawazGqNjpQE5YR/lyGbbRmbgXfoqgsV+6vRY9uy/PPlQ==", "X-Received": "by 2002:a62:b616:0:b029:150:f692:412d with SMTP id\n j22-20020a62b6160000b0290150f692412dmr13383775pff.8.1602279556611;\n Fri, 09 Oct 2020 14:39:16 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 9 Oct 2020 14:38:49 -0700", "Message-Id": "<20201009213855.17933-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201009213855.17933-1-stephen@networkplumber.org>", "References": "<20200911190701.29171-1-stephen@networkplumber.org>\n <20201009213855.17933-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 11/17] app: replace references to master/slave", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the miscellaneous tests. Replace references to master lcore with\nmain lcore and slave lcore with worker lcore.\n\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-acl/main.c | 2 +-\n app/test-bbdev/test_bbdev_perf.c | 16 ++++++++--------\n app/test-compress-perf/main.c | 8 ++++----\n app/test-crypto-perf/main.c | 14 +++++++-------\n app/test-flow-perf/main.c | 2 +-\n app/test-pipeline/main.c | 4 ++--\n app/test-sad/main.c | 4 ++--\n 7 files changed, 25 insertions(+), 25 deletions(-)", "diff": "diff --git a/app/test-acl/main.c b/app/test-acl/main.c\nindex 0a5dfb621d5e..72ff26674dac 100644\n--- a/app/test-acl/main.c\n+++ b/app/test-acl/main.c\n@@ -1085,7 +1085,7 @@ main(int argc, char **argv)\n \tif (config.trace_file != NULL)\n \t\ttracef_init();\n \n-\tRTE_LCORE_FOREACH_SLAVE(lcore)\n+\tRTE_LCORE_FOREACH_WORKER(lcore)\n \t\t rte_eal_remote_launch(search_ip5tuples, NULL, lcore);\n \n \tsearch_ip5tuples(NULL);\ndiff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 45c0d62acabc..da0c60dd9054 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -3651,14 +3651,14 @@ bler_test(struct active_device *ad,\n \n \trte_atomic16_set(&op_params->sync, SYNC_WAIT);\n \n-\t/* Master core is set at first entry */\n+\t/* Main core is set at first entry */\n \tt_params[0].dev_id = ad->dev_id;\n \tt_params[0].lcore_id = rte_lcore_id();\n \tt_params[0].op_params = op_params;\n \tt_params[0].queue_id = ad->queue_ids[used_cores++];\n \tt_params[0].iter_count = 0;\n \n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\tif (used_cores >= num_lcores)\n \t\t\tbreak;\n \n@@ -3675,7 +3675,7 @@ bler_test(struct active_device *ad,\n \trte_atomic16_set(&op_params->sync, SYNC_START);\n \tret = bler_function(&t_params[0]);\n \n-\t/* Master core is always used */\n+\t/* Main core is always used */\n \tfor (used_cores = 1; used_cores < num_lcores; used_cores++)\n \t\tret |= rte_eal_wait_lcore(t_params[used_cores].lcore_id);\n \n@@ -3769,14 +3769,14 @@ throughput_test(struct active_device *ad,\n \n \trte_atomic16_set(&op_params->sync, SYNC_WAIT);\n \n-\t/* Master core is set at first entry */\n+\t/* Main core is set at first entry */\n \tt_params[0].dev_id = ad->dev_id;\n \tt_params[0].lcore_id = rte_lcore_id();\n \tt_params[0].op_params = op_params;\n \tt_params[0].queue_id = ad->queue_ids[used_cores++];\n \tt_params[0].iter_count = 0;\n \n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\tif (used_cores >= num_lcores)\n \t\t\tbreak;\n \n@@ -3793,7 +3793,7 @@ throughput_test(struct active_device *ad,\n \trte_atomic16_set(&op_params->sync, SYNC_START);\n \tret = throughput_function(&t_params[0]);\n \n-\t/* Master core is always used */\n+\t/* Main core is always used */\n \tfor (used_cores = 1; used_cores < num_lcores; used_cores++)\n \t\tret |= rte_eal_wait_lcore(t_params[used_cores].lcore_id);\n \n@@ -3817,7 +3817,7 @@ throughput_test(struct active_device *ad,\n \t/* In interrupt TC we need to wait for the interrupt callback to deqeue\n \t * all pending operations. Skip waiting for queues which reported an\n \t * error using processing_status variable.\n-\t * Wait for master lcore operations.\n+\t * Wait for main lcore operations.\n \t */\n \ttp = &t_params[0];\n \twhile ((rte_atomic16_read(&tp->nb_dequeued) <\n@@ -3830,7 +3830,7 @@ throughput_test(struct active_device *ad,\n \ttp->mbps /= TEST_REPETITIONS;\n \tret |= (int)rte_atomic16_read(&tp->processing_status);\n \n-\t/* Wait for slave lcores operations */\n+\t/* Wait for worker lcores operations */\n \tfor (used_cores = 1; used_cores < num_lcores; used_cores++) {\n \t\ttp = &t_params[used_cores];\n \ndiff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c\nindex ed21605d89c2..cc9951a9b107 100644\n--- a/app/test-compress-perf/main.c\n+++ b/app/test-compress-perf/main.c\n@@ -389,7 +389,7 @@ main(int argc, char **argv)\n \ti = 0;\n \tuint8_t qp_id = 0, cdev_index = 0;\n \n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\tif (i == total_nb_qps)\n \t\t\tbreak;\n@@ -413,7 +413,7 @@ main(int argc, char **argv)\n \twhile (test_data->level <= test_data->level_lst.max) {\n \n \t\ti = 0;\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\tif (i == total_nb_qps)\n \t\t\t\tbreak;\n@@ -424,7 +424,7 @@ main(int argc, char **argv)\n \t\t\ti++;\n \t\t}\n \t\ti = 0;\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\tif (i == total_nb_qps)\n \t\t\t\tbreak;\n@@ -449,7 +449,7 @@ main(int argc, char **argv)\n \n \tcase ST_DURING_TEST:\n \t\ti = 0;\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\t\tif (i == total_nb_qps)\n \t\t\t\tbreak;\n \ndiff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c\nindex 8f8e580e4dc6..1b54f0902aee 100644\n--- a/app/test-crypto-perf/main.c\n+++ b/app/test-crypto-perf/main.c\n@@ -594,7 +594,7 @@ main(int argc, char **argv)\n \n \ti = 0;\n \tuint8_t qp_id = 0, cdev_index = 0;\n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\tif (i == total_nb_qps)\n \t\t\tbreak;\n@@ -658,7 +658,7 @@ main(int argc, char **argv)\n \t\t\t\tdistribution_total[buffer_size_count - 1];\n \n \t\ti = 0;\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\tif (i == total_nb_qps)\n \t\t\t\tbreak;\n@@ -668,7 +668,7 @@ main(int argc, char **argv)\n \t\t\ti++;\n \t\t}\n \t\ti = 0;\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\tif (i == total_nb_qps)\n \t\t\t\tbreak;\n@@ -688,7 +688,7 @@ main(int argc, char **argv)\n \n \t\twhile (opts.test_buffer_size <= opts.max_buffer_size) {\n \t\t\ti = 0;\n-\t\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\t\tif (i == total_nb_qps)\n \t\t\t\t\tbreak;\n@@ -698,7 +698,7 @@ main(int argc, char **argv)\n \t\t\t\ti++;\n \t\t\t}\n \t\t\ti = 0;\n-\t\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\t\t\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\t\t\tif (i == total_nb_qps)\n \t\t\t\t\tbreak;\n@@ -722,7 +722,7 @@ main(int argc, char **argv)\n \t}\n \n \ti = 0;\n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \n \t\tif (i == total_nb_qps)\n \t\t\tbreak;\n@@ -742,7 +742,7 @@ main(int argc, char **argv)\n \n err:\n \ti = 0;\n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n+\tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\tif (i == total_nb_qps)\n \t\t\tbreak;\n \ndiff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex c420da6a57c1..ba5ba112f262 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -1445,7 +1445,7 @@ main(int argc, char **argv)\n \n \tif (enable_fwd) {\n \t\tinit_lcore_info();\n-\t\trte_eal_mp_remote_launch(start_forwarding, NULL, CALL_MASTER);\n+\t\trte_eal_mp_remote_launch(start_forwarding, NULL, CALL_MAIN);\n \t}\n \n \tRTE_ETH_FOREACH_DEV(port) {\ndiff --git a/app/test-pipeline/main.c b/app/test-pipeline/main.c\nindex 7f0d6d3f1862..c8ee4e8927a4 100644\n--- a/app/test-pipeline/main.c\n+++ b/app/test-pipeline/main.c\n@@ -66,8 +66,8 @@ main(int argc, char **argv)\n \tapp_init();\n \n \t/* Launch per-lcore init on every lcore */\n-\trte_eal_mp_remote_launch(app_lcore_main_loop, NULL, CALL_MASTER);\n-\tRTE_LCORE_FOREACH_SLAVE(lcore) {\n+\trte_eal_mp_remote_launch(app_lcore_main_loop, NULL, CALL_MAIN);\n+\tRTE_LCORE_FOREACH_WORKER(lcore) {\n \t\tif (rte_eal_wait_lcore(lcore) < 0)\n \t\t\treturn -1;\n \t}\ndiff --git a/app/test-sad/main.c b/app/test-sad/main.c\nindex b01e84c570bb..e9c26e741621 100644\n--- a/app/test-sad/main.c\n+++ b/app/test-sad/main.c\n@@ -657,11 +657,11 @@ main(int argc, char **argv)\n \n \tadd_rules(sad, 10);\n \tif (config.parallel_lookup)\n-\t\trte_eal_mp_remote_launch(lookup, sad, SKIP_MASTER);\n+\t\trte_eal_mp_remote_launch(lookup, sad, SKIP_MAIN);\n \n \tlookup(sad);\n \tif (config.parallel_lookup)\n-\t\tRTE_LCORE_FOREACH_SLAVE(lcore_id)\n+\t\tRTE_LCORE_FOREACH_WORKER(lcore_id)\n \t\t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n \t\t\t\treturn -1;\n \n", "prefixes": [ "v4", "11/17" ] }