Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 79682,
    "url": "http://patches.dpdk.org/api/patches/79682/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201005162658.12416-3-vikas.gupta@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201005162658.12416-3-vikas.gupta@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201005162658.12416-3-vikas.gupta@broadcom.com",
    "date": "2020-10-05T16:26:52",
    "name": "[v3,2/8] crypto/bcmfs: add vfio support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4ff34685230f91d81cf7446bed7bb81cf637a65a",
    "submitter": {
        "id": 1907,
        "url": "http://patches.dpdk.org/api/people/1907/?format=api",
        "name": "Vikas Gupta",
        "email": "vikas.gupta@broadcom.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201005162658.12416-3-vikas.gupta@broadcom.com/mbox/",
    "series": [
        {
            "id": 12697,
            "url": "http://patches.dpdk.org/api/series/12697/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12697",
            "date": "2020-10-05T16:26:50",
            "name": "Add Crypto PMD for Broadcom`s FlexSparc devices",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/12697/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/79682/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/79682/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6630AA04B1;\n\tMon,  5 Oct 2020 18:27:46 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0FB2A1B868;\n\tMon,  5 Oct 2020 18:27:20 +0200 (CEST)",
            "from mail-pj1-f65.google.com (mail-pj1-f65.google.com\n [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 81BD71B81B\n for <dev@dpdk.org>; Mon,  5 Oct 2020 18:27:18 +0200 (CEST)",
            "by mail-pj1-f65.google.com with SMTP id u3so71012pjr.3\n for <dev@dpdk.org>; Mon, 05 Oct 2020 09:27:18 -0700 (PDT)",
            "from rahul_yocto_ubuntu18.ibn.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id d129sm378061pfc.161.2020.10.05.09.27.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 05 Oct 2020 09:27:15 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=zCcJDKmoJb7h1J+agOYxMBimwpth1uNf7EnHK2qnH28=;\n b=ALNDtoPQw5M60IadK2LFiVWQs6EACUQNd0nHPo2HD6f5oHT/NL9EPv8eIbneszPoR6\n SB01zc9zRKvxU+JCEuy68dxsXrFx8TCeQsLq5wTXTcPz5uity9CSKoo0eU5H983nYYPc\n xgRLSlBYSdUW+hM6diAH3v6M27rezg80Qoj2A=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=zCcJDKmoJb7h1J+agOYxMBimwpth1uNf7EnHK2qnH28=;\n b=HIBWwEQl7GjfoiVGupIEh9yuoW0mPyarVbTaDVPb7YQQ8W7Tye3bHl05PfnhKiX/1c\n pVAJP5i0UQoX94x0IAvopICe33NTcBg0EYYGn2DyuYdeD1MdoVy0x/wg3LiXPQO7KfEF\n 5To/Al6hbZTnNUPgVgtdYs0friF2GExSt/nnJfTEkyVtZHh4OUBZWxUCjGwfQxjCHfsC\n wxkJKC2VlqPaCtGqKTtg9h3CdEvBZ6Xuy+I7J0l1y2ImH/pxY930WEVpqQvfkiRLDMn9\n sS5vKTg0/hp7JPkuliqF9r3B2et39uWuVjBFx9L78aubXhn2e7wvZqhhMd+i9QmQwhj8\n 2jbw==",
        "X-Gm-Message-State": "AOAM531D6qSHL8wK1jibQVUHW35Ui0laJUR/pdfA36jGDdGuZoSjp4N7\n IoLaUA2LWQGQKzLGk2lL8bBhq6SNlemNsvpUTPTjEREw7gCJB3oJxYGk8V+Xb2c/WTPGjgNslaw\n 6d3gVNQJplYC8sn9d+NGUPveFTGMNdkgGg+CehZ24Q5RZ2Xigz1WyI04Lepfi",
        "X-Google-Smtp-Source": "\n ABdhPJwAvMhiZeyxi5wBt1gmIl0lOVZawwD9dqG/6aIFtjXiA3rdmTqnC0G7suEKScqpiea9+M349A==",
        "X-Received": "by 2002:a17:90a:d356:: with SMTP id\n i22mr213783pjx.90.1601915236068;\n Mon, 05 Oct 2020 09:27:16 -0700 (PDT)",
        "From": "Vikas Gupta <vikas.gupta@broadcom.com>",
        "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com",
        "Cc": "vikram.prakash@broadcom.com, Vikas Gupta <vikas.gupta@broadcom.com>,\n Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>",
        "Date": "Mon,  5 Oct 2020 21:56:52 +0530",
        "Message-Id": "<20201005162658.12416-3-vikas.gupta@broadcom.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20201005162658.12416-1-vikas.gupta@broadcom.com>",
        "References": "<20200813172344.3228-1-vikas.gupta@broadcom.com>\n <20201005162658.12416-1-vikas.gupta@broadcom.com>",
        "Content-Type": "text/plain",
        "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
        "Subject": "[dpdk-dev] [PATCH v3 2/8] crypto/bcmfs: add vfio support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add VFIO support for BCMFS PMD.\nThe BCMFS PMD functionality is dependent on the VFIO_PRESENT flag,\nwhich gets enabled in the rte_vfio.h.\nIf this flag is not enabled in the compiling platform driver will\nsilently return with error, when executed.\n\nSigned-off-by: Vikas Gupta <vikas.gupta@broadcom.com>\nSigned-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/crypto/bcmfs/bcmfs_device.c |   5 ++\n drivers/crypto/bcmfs/bcmfs_device.h |   6 ++\n drivers/crypto/bcmfs/bcmfs_vfio.c   | 107 ++++++++++++++++++++++++++++\n drivers/crypto/bcmfs/bcmfs_vfio.h   |  17 +++++\n drivers/crypto/bcmfs/meson.build    |   3 +-\n 5 files changed, 137 insertions(+), 1 deletion(-)\n create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.c\n create mode 100644 drivers/crypto/bcmfs/bcmfs_vfio.h",
    "diff": "diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c\nindex c9865ee6a5..1ea6c3b13e 100644\n--- a/drivers/crypto/bcmfs/bcmfs_device.c\n+++ b/drivers/crypto/bcmfs/bcmfs_device.c\n@@ -12,6 +12,7 @@\n \n #include \"bcmfs_device.h\"\n #include \"bcmfs_logs.h\"\n+#include \"bcmfs_vfio.h\"\n \n struct bcmfs_device_attr {\n \tconst char name[BCMFS_MAX_PATH_LEN];\n@@ -72,6 +73,10 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev,\n \n \tfsdev->vdev = vdev;\n \n+\t/* attach to VFIO */\n+\tif (bcmfs_attach_vfio(fsdev))\n+\t\tgoto cleanup;\n+\n \tTAILQ_INSERT_TAIL(&fsdev_list, fsdev, next);\n \n \treturn fsdev;\ndiff --git a/drivers/crypto/bcmfs/bcmfs_device.h b/drivers/crypto/bcmfs/bcmfs_device.h\nindex cc64a8df2c..c41cc00318 100644\n--- a/drivers/crypto/bcmfs/bcmfs_device.h\n+++ b/drivers/crypto/bcmfs/bcmfs_device.h\n@@ -35,6 +35,12 @@ struct bcmfs_device {\n \tchar name[BCMFS_DEV_NAME_LEN];\n \t/* Parent vdev */\n \tstruct rte_vdev_device *vdev;\n+\t/* vfio handle */\n+\tint vfio_dev_fd;\n+\t/* mapped address */\n+\tuint8_t *mmap_addr;\n+\t/* mapped size */\n+\tuint32_t mmap_size;\n };\n \n #endif /* _BCMFS_DEV_H_ */\ndiff --git a/drivers/crypto/bcmfs/bcmfs_vfio.c b/drivers/crypto/bcmfs/bcmfs_vfio.c\nnew file mode 100644\nindex 0000000000..dc2def580f\n--- /dev/null\n+++ b/drivers/crypto/bcmfs/bcmfs_vfio.c\n@@ -0,0 +1,107 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Broadcom.\n+ * All rights reserved.\n+ */\n+\n+#include <errno.h>\n+#include <sys/mman.h>\n+#include <sys/ioctl.h>\n+\n+#include <rte_vfio.h>\n+\n+#include \"bcmfs_device.h\"\n+#include \"bcmfs_logs.h\"\n+#include \"bcmfs_vfio.h\"\n+\n+#ifdef VFIO_PRESENT\n+static int\n+vfio_map_dev_obj(const char *path, const char *dev_obj,\n+\t\t uint32_t *size, void **addr, int *dev_fd)\n+{\n+\tint32_t ret;\n+\tstruct vfio_group_status status = { .argsz = sizeof(status) };\n+\n+\tstruct vfio_device_info d_info = { .argsz = sizeof(d_info) };\n+\tstruct vfio_region_info reg_info = { .argsz = sizeof(reg_info) };\n+\n+\tret = rte_vfio_setup_device(path, dev_obj, dev_fd, &d_info);\n+\tif (ret) {\n+\t\tBCMFS_LOG(ERR, \"VFIO Setting for device failed\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* getting device region info*/\n+\tret = ioctl(*dev_fd, VFIO_DEVICE_GET_REGION_INFO, &reg_info);\n+\tif (ret < 0) {\n+\t\tBCMFS_LOG(ERR, \"Error in VFIO getting REGION_INFO\");\n+\t\tgoto map_failed;\n+\t}\n+\n+\t*addr = mmap(NULL, reg_info.size,\n+\t\t     PROT_WRITE | PROT_READ, MAP_SHARED,\n+\t\t     *dev_fd, reg_info.offset);\n+\tif (*addr == MAP_FAILED) {\n+\t\tBCMFS_LOG(ERR, \"Error mapping region (errno = %d)\", errno);\n+\t\tret = errno;\n+\t\tgoto map_failed;\n+\t}\n+\t*size = reg_info.size;\n+\n+\treturn 0;\n+\n+map_failed:\n+\trte_vfio_release_device(path, dev_obj, *dev_fd);\n+\n+\treturn ret;\n+}\n+\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev)\n+{\n+\tint ret;\n+\tint vfio_dev_fd;\n+\tvoid  *v_addr = NULL;\n+\tuint32_t size = 0;\n+\n+\tret = vfio_map_dev_obj(dev->dirname, dev->name,\n+\t\t\t       &size, &v_addr, &vfio_dev_fd);\n+\tif (ret)\n+\t\treturn -1;\n+\n+\tdev->mmap_size = size;\n+\tdev->mmap_addr = v_addr;\n+\tdev->vfio_dev_fd = vfio_dev_fd;\n+\n+\treturn 0;\n+}\n+\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev)\n+{\n+\tint ret;\n+\n+\tif (dev == NULL)\n+\t\treturn;\n+\n+\t/* unmap the addr */\n+\tmunmap(dev->mmap_addr, dev->mmap_size);\n+\t/* release the device */\n+\tret = rte_vfio_release_device(dev->dirname, dev->name,\n+\t\t\t\t      dev->vfio_dev_fd);\n+\tif (ret < 0) {\n+\t\tBCMFS_LOG(ERR, \"cannot release device\");\n+\t\treturn;\n+\t}\n+}\n+#else\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev __rte_unused)\n+{\n+\treturn -1;\n+}\n+\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev __rte_unused)\n+{\n+}\n+#endif\ndiff --git a/drivers/crypto/bcmfs/bcmfs_vfio.h b/drivers/crypto/bcmfs/bcmfs_vfio.h\nnew file mode 100644\nindex 0000000000..d0fdf6483f\n--- /dev/null\n+++ b/drivers/crypto/bcmfs/bcmfs_vfio.h\n@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2020 Broadcom\n+ * All rights reserved.\n+ */\n+\n+#ifndef _BCMFS_VFIO_H_\n+#define _BCMFS_VFIO_H_\n+\n+/* Attach the bcmfs device to vfio */\n+int\n+bcmfs_attach_vfio(struct bcmfs_device *dev);\n+\n+/* Release the bcmfs device from vfio */\n+void\n+bcmfs_release_vfio(struct bcmfs_device *dev);\n+\n+#endif /* _BCMFS_VFIO_H_ */\ndiff --git a/drivers/crypto/bcmfs/meson.build b/drivers/crypto/bcmfs/meson.build\nindex a4bdd8ee5d..fd39eba20e 100644\n--- a/drivers/crypto/bcmfs/meson.build\n+++ b/drivers/crypto/bcmfs/meson.build\n@@ -6,5 +6,6 @@\n deps += ['eal', 'bus_vdev']\n sources = files(\n \t\t'bcmfs_logs.c',\n-\t\t'bcmfs_device.c'\n+\t\t'bcmfs_device.c',\n+\t\t'bcmfs_vfio.c'\n \t\t)\n",
    "prefixes": [
        "v3",
        "2/8"
    ]
}