Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79460/?format=api
{ "id": 79460, "url": "http://patches.dpdk.org/api/patches/79460/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201001102245.326223-1-3chas3@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201001102245.326223-1-3chas3@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201001102245.326223-1-3chas3@gmail.com", "date": "2020-10-01T10:22:44", "name": "[v2,1/2] net: check that seg is valid before dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f7ce73403ec8bcad289f05fdce3ab5bcde9df176", "submitter": { "id": 341, "url": "http://patches.dpdk.org/api/people/341/?format=api", "name": "Chas Williams", "email": "3chas3@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201001102245.326223-1-3chas3@gmail.com/mbox/", "series": [ { "id": 12640, "url": "http://patches.dpdk.org/api/series/12640/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12640", "date": "2020-10-01T10:22:44", "name": "[v2,1/2] net: check that seg is valid before dereference", "version": 2, "mbox": "http://patches.dpdk.org/series/12640/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79460/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05694A04B5;\n\tThu, 1 Oct 2020 12:36:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9136C1DAFE;\n\tThu, 1 Oct 2020 12:22:53 +0200 (CEST)", "from mail-qt1-f194.google.com (mail-qt1-f194.google.com\n [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id EBF831DAF8\n for <dev@dpdk.org>; Thu, 1 Oct 2020 12:22:50 +0200 (CEST)", "by mail-qt1-f194.google.com with SMTP id y11so3832879qtn.9\n for <dev@dpdk.org>; Thu, 01 Oct 2020 03:22:50 -0700 (PDT)", "from monolith.fios-router.home\n (pool-96-255-60-31.washdc.fios.verizon.net. [96.255.60.31])\n by smtp.googlemail.com with ESMTPSA id\n q185sm5662399qke.25.2020.10.01.03.22.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Oct 2020 03:22:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=TfhGEOwCD8FHLioOVqBXNZ7zon0lRTk22WIVFBrFGkI=;\n b=o6xScIeSd5RRaHf/UCQoWTwddKiD/T7rPlLRtWxwNy9jS6g+iKHpoF23v1Y3bReL2z\n SbXB8TDE+WCo3k8Uo6+o/nwART5nJgPXcjqeEfEl6keXQvSMdapKLsbMjhqUobqYuH46\n 6Z5M4mw5xKBX2Da2d/Ruwu1d8uPmsOq8w4yYw7i2WGSLV40lRLC8tOm/XQuZekKCF8Sd\n y/xVYFEWNSNGB9zL2xRR2nBI/YFb+L5dI3braWuUq2ZcSUD0ZqdrYJuw+LDMuJ8qa2OU\n LdBBeW4ZcYldw588nZm+D8gI11stbXO4GyJRe3m8C5Ow+pKuguDHSc/In2df9U5jsvF+\n t1hQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=TfhGEOwCD8FHLioOVqBXNZ7zon0lRTk22WIVFBrFGkI=;\n b=CBBZHYYCoWugiK0jAeJXxQRNvDwx9AlVLObgXQPQHfzNfAxQwKXxuyFAqLHNLEtBBy\n a3Prl+qYsmadv3n2cmSdTRaUzk7+TrlDyVX7aLRwNGMnaZoJ+JbH/wPcBCS/V2LK8CU0\n RfCMGXVSVpZk4Drxa/9c0s1oT9XQWY3seEhjCKXWCHqDzg8Qfe9n9/1tv5+A7FGJC6yC\n /pL6hmO1/N7IpvM2LNRUnl9IQgbvIuohK5xOll0BBUzqRkgHlCw5oxsKgmBjtkhuxVMY\n NPnryiTXdt7urbUcsi7nMl1vdwstyWBUHVjNgkPc22zdW0RWkj4plzGLpPJvKxUUWKhT\n XUOw==", "X-Gm-Message-State": "AOAM5307B8b6u6aXRQstXAiQubizZNaoG6X7swmo1rddoEHfPULCaqNJ\n QL5KGUrhSGkXFcSElJSweMC4tDimT4J10g==", "X-Google-Smtp-Source": "\n ABdhPJyHdvcujaaJ7nkuI9irwxpm1G/BJHExk8JNKLFiIYNYKzCwKRp4fvFXOFOy5+Zv5xuAefL/dg==", "X-Received": "by 2002:ac8:1a7b:: with SMTP id q56mr6736136qtk.56.1601547770297;\n Thu, 01 Oct 2020 03:22:50 -0700 (PDT)", "From": "Chas Williams <3chas3@gmail.com>", "To": "dev@dpdk.org", "Cc": "olivier.matz@6wind.com,\n\tChas Williams <3chas3@gmail.com>", "Date": "Thu, 1 Oct 2020 06:22:44 -0400", "Message-Id": "<20201001102245.326223-1-3chas3@gmail.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200928153219.285343-1-3chas3@gmail.com>", "References": "<20200928153219.285343-1-3chas3@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] net: check that seg is valid before\n\tdereference", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the overall pkt_len and segment lengths are out of agreement,\nit is possible for the seg to be NULL after the loop. Add assert\nto check this condition in debug builds. Otherwise, return failure.\n\nFixes: c442fed81bb9 (\"net: add function to calculate checksum in mbuf\")\n\nSigned-off-by: Chas Williams <3chas3@gmail.com>\n---\n lib/librte_net/rte_ip.h | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h\nindex fcd1eb342..b2bb5d7b9 100644\n--- a/lib/librte_net/rte_ip.h\n+++ b/lib/librte_net/rte_ip.h\n@@ -225,6 +225,9 @@ rte_raw_cksum_mbuf(const struct rte_mbuf *m, uint32_t off, uint32_t len,\n \t\t\tbreak;\n \t\toff -= seglen;\n \t}\n+\tRTE_ASSERT(seg != NULL);\n+\tif (seg == NULL)\n+\t\treturn -1;\n \tseglen -= off;\n \tbuf = rte_pktmbuf_mtod_offset(seg, const char *, off);\n \tif (seglen >= len) {\n", "prefixes": [ "v2", "1/2" ] }