Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79350/?format=api
http://patches.dpdk.org/api/patches/79350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200930130415.11211-14-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200930130415.11211-14-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200930130415.11211-14-ciara.power@intel.com", "date": "2020-09-30T13:04:09", "name": "[v3,13/18] net/virtio: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0ec3059a656991603990c5aead5cbf3a40a16f91", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200930130415.11211-14-ciara.power@intel.com/mbox/", "series": [ { "id": 12621, "url": "http://patches.dpdk.org/api/series/12621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12621", "date": "2020-09-30T13:03:56", "name": "add max SIMD bitwidth to EAL", "version": 3, "mbox": "http://patches.dpdk.org/series/12621/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79350/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79350/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A1B3A04B5;\n\tWed, 30 Sep 2020 15:12:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9C0A01DB83;\n\tWed, 30 Sep 2020 15:08:40 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 0AE831DB44\n for <dev@dpdk.org>; Wed, 30 Sep 2020 15:08:24 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Sep 2020 06:08:23 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga008.fm.intel.com with ESMTP; 30 Sep 2020 06:08:21 -0700" ], "IronPort-SDR": [ "\n kQa7KCYebNYTwsViF9Oz6XIO15xGL/9lvo6HDU+IN1JSvP4hLN6/O58kSirBcrcCvtlbHBqt2N\n QpIJDB5EMCtQ==", "\n oibkUHzkZC9DqYke/Qa1mm/zKiFHhUSdJ9bdtIVkjFypAGFAT5aJ3pMxviCFoOW82ScujHfvrX\n jK3bfcPVZAnA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9759\"; a=\"150223489\"", "E=Sophos;i=\"5.77,322,1596524400\"; d=\"scan'208\";a=\"150223489\"", "E=Sophos;i=\"5.77,322,1596524400\"; d=\"scan'208\";a=\"294603259\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Wed, 30 Sep 2020 14:04:09 +0100", "Message-Id": "<20200930130415.11211-14-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200930130415.11211-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20200930130415.11211-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 13/18] net/virtio: add checks for max SIMD\n\tbitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Maxime Coquelin <maxime.coquelin@redhat.com>\nCc: Chenbo Xia <chenbo.xia@intel.com>\nCc: Zhihong Wang <zhihong.wang@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n\n---\nv3: Moved max SIMD bitwidth check to configure function with other vec\n support checks.\n---\n drivers/net/virtio/virtio_ethdev.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 013a2904e6..f749e81405 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -2306,7 +2306,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\tif ((hw->use_vec_rx || hw->use_vec_tx) &&\n \t\t (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) ||\n \t\t !vtpci_with_feature(hw, VIRTIO_F_IN_ORDER) ||\n-\t\t !vtpci_with_feature(hw, VIRTIO_F_VERSION_1))) {\n+\t\t !vtpci_with_feature(hw, VIRTIO_F_VERSION_1) ||\n+\t\t rte_get_max_simd_bitwidth() < RTE_MAX_512_SIMD)) {\n \t\t\tPMD_DRV_LOG(INFO,\n \t\t\t\t\"disabled packed ring vectorized path for requirements not met\");\n \t\t\thw->use_vec_rx = 0;\n@@ -2359,6 +2360,12 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\t\t\t\t\"disabled split ring vectorized rx for offloading enabled\");\n \t\t\t\thw->use_vec_rx = 0;\n \t\t\t}\n+\n+\t\t\tif (rte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD) {\n+\t\t\t\tPMD_DRV_LOG(INFO,\n+\t\t\t\t\t\"disabled split ring vectorized rx, max SIMD bitwidth too low\");\n+\t\t\t\thw->use_vec_rx = 0;\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [ "v3", "13/18" ] }{ "id": 79350, "url": "