Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79346/?format=api
{ "id": 79346, "url": "http://patches.dpdk.org/api/patches/79346/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200930130415.11211-9-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200930130415.11211-9-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200930130415.11211-9-ciara.power@intel.com", "date": "2020-09-30T13:04:04", "name": "[v3,08/18] net/fm10k: add checks for max SIMD bitwidth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6f574b6d6f2c519cc6a67cb6ff7b5e31fa276e2e", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200930130415.11211-9-ciara.power@intel.com/mbox/", "series": [ { "id": 12621, "url": "http://patches.dpdk.org/api/series/12621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12621", "date": "2020-09-30T13:03:56", "name": "add max SIMD bitwidth to EAL", "version": 3, "mbox": "http://patches.dpdk.org/series/12621/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79346/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70EE0A04B5;\n\tWed, 30 Sep 2020 15:11:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 292DE1DB5A;\n\tWed, 30 Sep 2020 15:08:30 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 7828E1DAFA\n for <dev@dpdk.org>; Wed, 30 Sep 2020 15:08:16 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Sep 2020 06:08:15 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga008.fm.intel.com with ESMTP; 30 Sep 2020 06:08:14 -0700" ], "IronPort-SDR": [ "\n DPhZhsM5UHUvK1CqpqXQDHcxLPp+MAgQxtKk209d6SW9Ag4zD4gIavjlhBWetKEcrqD3M4Aqqs\n dL+g8lThQC7Q==", "\n gW+a7K67X8/iwiONdMPkZUSOWEb5VzqJOaB3zzEkgacAyZlfKEc5FVXxsH90HVhOyGYVivBi3Q\n K+rcK2KJAIAw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9759\"; a=\"150223473\"", "E=Sophos;i=\"5.77,322,1596524400\"; d=\"scan'208\";a=\"150223473\"", "E=Sophos;i=\"5.77,322,1596524400\"; d=\"scan'208\";a=\"294603217\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Xiao Wang <xiao.w.wang@intel.com>", "Date": "Wed, 30 Sep 2020 14:04:04 +0100", "Message-Id": "<20200930130415.11211-9-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200930130415.11211-1-ciara.power@intel.com>", "References": "<20200807155859.63888-1-ciara.power@intel.com>\n <20200930130415.11211-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/18] net/fm10k: add checks for max SIMD\n\tbitwidth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When choosing a vector path to take, an extra condition must be\nsatisfied to ensure the max SIMD bitwidth allows for the CPU enabled\npath.\n\nCc: Qi Zhang <qi.z.zhang@intel.com>\nCc: Xiao Wang <xiao.w.wang@intel.com>\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 5771d83b55..a8bc1036a3 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2930,7 +2930,9 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\t/* primary process has set the ftag flag and offloads */\n \t\ttxq = dev->data->tx_queues[0];\n-\t\tif (fm10k_tx_vec_condition_check(txq)) {\n+\t\tif (fm10k_tx_vec_condition_check(txq) ||\n+\t\t\t\trte_get_max_simd_bitwidth()\n+\t\t\t\t< RTE_MAX_128_SIMD) {\n \t\t\tdev->tx_pkt_burst = fm10k_xmit_pkts;\n \t\t\tdev->tx_pkt_prepare = fm10k_prep_pkts;\n \t\t\tPMD_INIT_LOG(DEBUG, \"Use regular Tx func\");\n@@ -2949,7 +2951,8 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)\n \t\ttxq = dev->data->tx_queues[i];\n \t\ttxq->tx_ftag_en = tx_ftag_en;\n \t\t/* Check if Vector Tx is satisfied */\n-\t\tif (fm10k_tx_vec_condition_check(txq))\n+\t\tif (fm10k_tx_vec_condition_check(txq) ||\n+\t\t\t\trte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD)\n \t\t\tuse_sse = 0;\n \t}\n \n@@ -2983,7 +2986,9 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)\n \t * conditions to be met.\n \t */\n \tif (!fm10k_rx_vec_condition_check(dev) &&\n-\t\t\tdev_info->rx_vec_allowed && !rx_ftag_en) {\n+\t\t\tdev_info->rx_vec_allowed && !rx_ftag_en &&\n+\t\t\t\trte_get_max_simd_bitwidth()\n+\t\t\t\t>= RTE_MAX_128_SIMD) {\n \t\tif (dev->data->scattered_rx)\n \t\t\tdev->rx_pkt_burst = fm10k_recv_scattered_pkts_vec;\n \t\telse\n", "prefixes": [ "v3", "08/18" ] }