Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78555/?format=api
http://patches.dpdk.org/api/patches/78555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200923111228.6274-4-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200923111228.6274-4-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200923111228.6274-4-ciara.power@intel.com", "date": "2020-09-23T11:12:28", "name": "[v9,3/3] ethdev: add common stats for telemetry", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e2cd73a4fbcb78f92b434f239c01239c0a87aa62", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Ciara Power", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200923111228.6274-4-ciara.power@intel.com/mbox/", "series": [ { "id": 12439, "url": "http://patches.dpdk.org/api/series/12439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12439", "date": "2020-09-23T11:12:26", "name": "add basic ethdev stats with data object recursion", "version": 9, "mbox": "http://patches.dpdk.org/series/12439/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78555/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DD466A04B1;\n\tWed, 23 Sep 2020 13:15:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 98D391DB8A;\n\tWed, 23 Sep 2020 13:15:35 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id AE4CF1DB4B\n for <dev@dpdk.org>; Wed, 23 Sep 2020 13:15:31 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Sep 2020 04:15:29 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by FMSMGA003.fm.intel.com with ESMTP; 23 Sep 2020 04:15:27 -0700" ], "IronPort-SDR": [ "\n 05TTJFeDCEWbe9kkRHW2otF+ClMh6BudQIUwwG7fzRO/xlzJe0MaCZEochgA/1lr39dQDbeOjP\n oXngyjsx1RYg==", "\n JEZ/EBrkifjPSIH0nF3epQ/QKI1GQR8vDIOTmDijQrft+4zu6xYRVzcFdB6di7vPtsuwv3Rlq7\n 8BE7oVdCwdng==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9752\"; a=\"178932666\"", "E=Sophos;i=\"5.77,293,1596524400\"; d=\"scan'208\";a=\"178932666\"", "E=Sophos;i=\"5.77,293,1596524400\"; d=\"scan'208\";a=\"347314629\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "keith.wiles@intel.com, bruce.richardson@intel.com,\n Ciara Power <ciara.power@intel.com>, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Wed, 23 Sep 2020 12:12:28 +0100", "Message-Id": "<20200923111228.6274-4-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200923111228.6274-1-ciara.power@intel.com>", "References": "<20200612105344.15383-1-ciara.power@intel.com>\n <20200923111228.6274-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v9 3/3] ethdev: add common stats for telemetry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The ethdev library now registers a telemetry command for common ethdev\nstatistics.\n\nAn example usage is shown below:\n\nConnecting to /var/run/dpdk/rte/dpdk_telemetry.v2\n{\"version\": \"DPDK 20.08.0-rc1\", \"pid\": 14119, \"max_output_len\": 16384}\n--> /ethdev/stats,0\n{\"/ethdev/stats\": {\"ipackets\": 0, \"opackets\": 0, \"ibytes\": 0, \"obytes\": \\\n 0, \"imissed\": 0, \"ierrors\": 0, \"oerrors\": 0, \"rx_nombuf\": 0, \\\n \"q_ipackets\": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], \\\n \"q_opackets\": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], \\\n \"q_ibytes\": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], \\\n \"q_obytes\": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], \\\n \"q_errors\": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]}}\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 53 ++++++++++++++++++++++++++++++++++\n 1 file changed, 53 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex dfe5c1b488..81bb86c433 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -5328,6 +5328,57 @@ handle_port_list(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static void\n+add_port_queue_stats(struct rte_tel_data *d, uint64_t *q_stats,\n+\t\tconst char *stat_name)\n+{\n+\tint q;\n+\tstruct rte_tel_data *q_data = rte_tel_data_alloc();\n+\trte_tel_data_start_array(q_data, RTE_TEL_U64_VAL);\n+\tfor (q = 0; q < RTE_ETHDEV_QUEUE_STAT_CNTRS; q++)\n+\t\trte_tel_data_add_array_u64(q_data, q_stats[q]);\n+\trte_tel_data_add_dict_container(d, stat_name, q_data, 0);\n+}\n+\n+#define ADD_DICT_STAT(stats, s) rte_tel_data_add_dict_u64(d, #s, stats.s)\n+\n+static int\n+handle_port_stats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_stats stats;\n+\tint port_id, ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tret = rte_eth_stats_get(port_id, &stats);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\n+\trte_tel_data_start_dict(d);\n+\tADD_DICT_STAT(stats, ipackets);\n+\tADD_DICT_STAT(stats, opackets);\n+\tADD_DICT_STAT(stats, ibytes);\n+\tADD_DICT_STAT(stats, obytes);\n+\tADD_DICT_STAT(stats, imissed);\n+\tADD_DICT_STAT(stats, ierrors);\n+\tADD_DICT_STAT(stats, oerrors);\n+\tADD_DICT_STAT(stats, rx_nombuf);\n+\tadd_port_queue_stats(d, stats.q_ipackets, \"q_ipackets\");\n+\tadd_port_queue_stats(d, stats.q_opackets, \"q_opackets\");\n+\tadd_port_queue_stats(d, stats.q_ibytes, \"q_ibytes\");\n+\tadd_port_queue_stats(d, stats.q_obytes, \"q_obytes\");\n+\tadd_port_queue_stats(d, stats.q_errors, \"q_errors\");\n+\n+\treturn 0;\n+}\n+\n static int\n handle_port_xstats(const char *cmd __rte_unused,\n \t\tconst char *params,\n@@ -5414,6 +5465,8 @@ RTE_INIT(ethdev_init_telemetry)\n {\n \trte_telemetry_register_cmd(\"/ethdev/list\", handle_port_list,\n \t\t\t\"Returns list of available ethdev ports. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/ethdev/stats\", handle_port_stats,\n+\t\t\t\"Returns the common stats for a port. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/xstats\", handle_port_xstats,\n \t\t\t\"Returns the extended stats for a port. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/link_status\",\n", "prefixes": [ "v9", "3/3" ] }{ "id": 78555, "url": "