Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78414/?format=api
{ "id": 78414, "url": "http://patches.dpdk.org/api/patches/78414/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200922120329.21185-15-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922120329.21185-15-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922120329.21185-15-huwei013@chinasoftinc.com", "date": "2020-09-22T12:03:26", "name": "[v2,14/17] net/hns3: fix flow RSS queue num with 0", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "40139adc4a0de2d17c866256a23cc1c57c201b0f", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200922120329.21185-15-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 12408, "url": "http://patches.dpdk.org/api/series/12408/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12408", "date": "2020-09-22T12:03:12", "name": "updates for hns3 PMD driver", "version": 2, "mbox": "http://patches.dpdk.org/series/12408/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78414/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78414/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BCC8A04B0;\n\tTue, 22 Sep 2020 14:06:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3A0131DC15;\n\tTue, 22 Sep 2020 14:04:15 +0200 (CEST)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id BD1961DAE8\n for <dev@dpdk.org>; Tue, 22 Sep 2020 14:03:46 +0200 (CEST)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id 8u2DCTlEOsvhaeJ0 (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);\n Tue, 22 Sep 2020 20:03:44 +0800 (CST)", "from localhost.localdomain (120.133.139.157) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 22 Sep 2020\n 20:03:44 +0800" ], "X-ASG-Debug-ID": "1600776224-149d111bae1ab930001-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "CC": "<xavier.huwei@huawei.com>", "Date": "Tue, 22 Sep 2020 20:03:26 +0800", "X-ASG-Orig-Subj": "[PATCH v2 14/17] net/hns3: fix flow RSS queue num with 0", "Message-ID": "<20200922120329.21185-15-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20200922120329.21185-1-huwei013@chinasoftinc.com>", "References": "<20200922085401.12272-1-huwei013@chinasoftinc.com>\n <20200922120329.21185-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[120.133.139.157]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1600776224", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://incspam.chinasofti.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2789", "Subject": "[dpdk-dev] [PATCH v2 14/17] net/hns3: fix flow RSS queue num with 0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nWhen user specifies RSS queue num for 0 in action list by flow create API,\nit should create a valid flow rule. The following flow rule should be\nsuccess in the command line of the testpmd application:\nflow create 0 <pattern> actions rss queues / end\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 23 ++++++-----------------\n 1 file changed, 6 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 6f2ff87..5b5124c 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1360,10 +1360,9 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,\n \tuint16_t n;\n \n \tNEXT_ITEM_OF_ACTION(act, actions, act_index);\n-\t/* Get configuration args from APP cmdline input */\n \trss = act->conf;\n \n-\tif (rss == NULL || rss->queue_num == 0) {\n+\tif (rss == NULL) {\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t\t act, \"no valid queues\");\n@@ -1537,11 +1536,6 @@ hns3_update_indir_table(struct rte_eth_dev *dev,\n \tuint8_t queue_id;\n \tuint32_t i;\n \n-\tif (num == 0) {\n-\t\thns3_err(hw, \"No PF queues are configured to enable RSS\");\n-\t\treturn -ENOTSUP;\n-\t}\n-\n \tallow_rss_queues = RTE_MIN(dev->data->nb_rx_queues, hw->rss_size_max);\n \t/* Fill in redirection table */\n \tmemcpy(indir_tbl, hw->rss_info.rss_indirection_tbl,\n@@ -1632,10 +1626,11 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \thns3_info(hw, \"Max of contiguous %u PF queues are configured\", num);\n \n \trte_spinlock_lock(&hw->lock);\n-\t/* Update redirection talbe of rss */\n-\tret = hns3_update_indir_table(dev, &rss_flow_conf, num);\n-\tif (ret)\n-\t\tgoto rss_config_err;\n+\tif (num) {\n+\t\tret = hns3_update_indir_table(dev, &rss_flow_conf, num);\n+\t\tif (ret)\n+\t\t\tgoto rss_config_err;\n+\t}\n \n \t/* Set hash algorithm and flow types by the user's config */\n \tret = hns3_hw_rss_hash_set(hw, &rss_flow_conf);\n@@ -1661,9 +1656,6 @@ hns3_clear_rss_filter(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \n-\tif (hw->rss_info.conf.queue_num == 0)\n-\t\treturn 0;\n-\n \treturn hns3_config_rss_filter(dev, &hw->rss_info, false);\n }\n \n@@ -1674,9 +1666,6 @@ hns3_restore_rss_filter(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \n-\tif (hw->rss_info.conf.queue_num == 0)\n-\t\treturn 0;\n-\n \t/* When user flush all rules, it doesn't need to restore RSS rule */\n \tif (hw->rss_info.conf.func == RTE_ETH_HASH_FUNCTION_MAX)\n \t\treturn 0;\n", "prefixes": [ "v2", "14/17" ] }