Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78318/?format=api
{ "id": 78318, "url": "http://patches.dpdk.org/api/patches/78318/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200922085401.12272-12-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922085401.12272-12-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922085401.12272-12-huwei013@chinasoftinc.com", "date": "2020-09-22T08:53:55", "name": "[11/17] net/hns3: check input RSS type when creating flow with RSS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a355a66209236f3e580df6f435ede06394ebbe26", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200922085401.12272-12-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 12401, "url": "http://patches.dpdk.org/api/series/12401/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12401", "date": "2020-09-22T08:53:46", "name": "updates for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/12401/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78318/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 152F9A04E1;\n\tTue, 22 Sep 2020 11:03:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CACDD1DC66;\n\tTue, 22 Sep 2020 10:55:19 +0200 (CEST)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 512241DAF8\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:54:58 +0200 (CEST)", "from mail.chinasoftinc.com ([10.168.0.51]) by\n incedge.chinasoftinc.com with ESMTP id jMf0gDAxE2oStujr (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);\n Tue, 22 Sep 2020 16:54:57 +0800 (CST)", "from localhost.localdomain (120.133.139.157) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 22 Sep 2020\n 16:54:56 +0800" ], "X-ASG-Debug-ID": "1600764897-149d111bae19b060001-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.51", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "CC": "<xavier.huwei@huawei.com>", "Date": "Tue, 22 Sep 2020 16:53:55 +0800", "X-ASG-Orig-Subj": "[PATCH 11/17] net/hns3: check input RSS type when creating\n flow with RSS", "Message-ID": "<20200922085401.12272-12-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20200922085401.12272-1-huwei013@chinasoftinc.com>", "References": "<20200922085401.12272-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[120.133.139.157]", "X-Barracuda-Connect": "UNKNOWN[10.168.0.51]", "X-Barracuda-Start-Time": "1600764897", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://incspam.chinasofti.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2184", "Subject": "[dpdk-dev] [PATCH 11/17] net/hns3: check input RSS type when\n\tcreating flow with RSS", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lijun Ou <oulijun@huawei.com>\n\nThis patch adds checking the input RSS type when creating a flow with RSS.\nIf the input RSS type are not supported based on hns3 network engine, an\nerror is returned.\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 26 ++++++++------------------\n 1 file changed, 8 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 14d5968..f4ea47a 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1403,6 +1403,13 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n \t\t\t\t\t \"too many queues for RSS context\");\n \n+\tif (rss->types & (ETH_RSS_L4_DST_ONLY | ETH_RSS_L4_SRC_ONLY) &&\n+\t (rss->types & ETH_RSS_IP))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\t\t &rss->types,\n+\t\t\t\t\t \"input RSS types are not supported\");\n+\n \tact_index++;\n \n \t/* Check if the next not void action is END */\n@@ -1563,23 +1570,6 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\t.queue = conf->conf.queue,\n \t};\n \n-\t/* The types is Unsupported by hns3' RSS */\n-\tif (!(rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT) &&\n-\t rss_flow_conf.types) {\n-\t\thns3_err(hw,\n-\t\t\t \"Flow types(%\" PRIx64 \") is unsupported by hns3's RSS\",\n-\t\t\t rss_flow_conf.types);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (rss_flow_conf.key_len &&\n-\t rss_flow_conf.key_len > RTE_DIM(rss_info->key)) {\n-\t\thns3_err(hw,\n-\t\t\t\"input hash key(%u) greater than supported len(%zu)\",\n-\t\t\trss_flow_conf.key_len, RTE_DIM(rss_info->key));\n-\t\treturn -EINVAL;\n-\t}\n-\n \t/* Filter the unsupported flow types */\n \tflow_types = conf->conf.types ?\n \t\t rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT :\n@@ -1755,7 +1745,7 @@ hns3_flow_create(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \tstruct hns3_fdir_rule fdir_rule;\n \tint ret;\n \n-\tret = hns3_flow_args_check(attr, pattern, actions, error);\n+\tret = hns3_flow_validate(dev, attr, pattern, actions, error);\n \tif (ret)\n \t\treturn NULL;\n \n", "prefixes": [ "11/17" ] }