Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78296/?format=api
{ "id": 78296, "url": "http://patches.dpdk.org/api/patches/78296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-53-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600764594-14752-53-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600764594-14752-53-git-send-email-arybchenko@solarflare.com", "date": "2020-09-22T08:49:46", "name": "[52/60] common/sfc_efx/base: use EF10 EVB methods for Riverhead", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "511cd3538b59fe60c160039c7b7f2af301e750d4", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-53-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12400, "url": "http://patches.dpdk.org/api/series/12400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12400", "date": "2020-09-22T08:48:59", "name": "common/sfc_efx: support Riverhead NIC family", "version": 1, "mbox": "http://patches.dpdk.org/series/12400/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78296/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51463A04E1;\n\tTue, 22 Sep 2020 10:58:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D8F81DBBC;\n\tTue, 22 Sep 2020 10:51:25 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D57B11C1B8\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:50:22 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.143])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 7C60A20053 for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:22 +0000 (UTC)", "from us4-mdac16-56.at1.mdlocal (unknown [10.110.48.199])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 7BEFF8009B\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:22 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 22F3940061\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:22 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DF91E40051\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:21 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 22 Sep 2020 09:50:12 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 09:50:12 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08M8oB1g004830\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:11 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id E21461613AB\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:11 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 22 Sep 2020 09:49:46 +0100", "Message-ID": "<1600764594-14752-53-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-2.218500-8.000000-10", "X-TMASE-MatchedRID": "JE3IqDHqIlRwmwJKzmoXvN1+No0HEURtaeMaKzvXUpljLp8Cm8vwF5eg\n nc+D+O7x7afHkEmafZNw5T4Iaj538mJZXQNDzktSrSAIWhdbeu+Oz/LLJUcaHlVkJxysad/IWFC\n ZbvPiXUWaJfo0dDvh7uehiFig8ZML2DRLgpZEiUb/V0SDC1Do0LqGBW9J0Yqj4uxAgOavdLkTw7\n jCStQ0rgpziWOou199rotBFWSuK2gfE8yM4pjsD7TsNDeEKGMAxEHRux+uk8ifEzJ5hPndGb/l3\n H6/FhCkcINU0gY/zhd1rxAhRQJGl4SBvWNn7mscFUX3r5/Cwe3+zdxDSa8yxd+Ie37Y4WM5cTO5\n N2/Xfcu40d0Fv56SCRySoBCeolQDq8uPJC94SFgR06l6KId4N3r0M0SKNnXWVlxr1FJij9s=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.218500-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600764622-iY3jGdpRLTzt", "Subject": "[dpdk-dev] [PATCH 52/60] common/sfc_efx/base: use EF10 EVB methods\n\tfor Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no difference yet in EVB support on EF10 and Riverhead.\nSo, it is better to reuse existing methods.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_evb.c | 8 ++++----\n drivers/common/sfc_efx/base/efx_check.h | 4 ++--\n drivers/common/sfc_efx/base/efx_evb.c | 24 ++++++++++++++++++++++++\n 3 files changed, 30 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_evb.c b/drivers/common/sfc_efx/base/ef10_evb.c\nindex aeeaa5189f..089d791543 100644\n--- a/drivers/common/sfc_efx/base/ef10_evb.c\n+++ b/drivers/common/sfc_efx/base/ef10_evb.c\n@@ -9,13 +9,13 @@\n \n #if EFSYS_OPT_EVB\n \n-#if EFX_OPTS_EF10()\n+#if EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10()\n \n \t__checkReturn\tefx_rc_t\n ef10_evb_init(\n \t__in\t\tefx_nic_t *enp)\n {\n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n \treturn (0);\n }\n@@ -24,7 +24,7 @@ ef10_evb_init(\n ef10_evb_fini(\n \t__in\t\tefx_nic_t *enp)\n {\n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n }\n \n static\t__checkReturn\tefx_rc_t\n@@ -545,5 +545,5 @@ ef10_evb_vport_stats(\n \t\t\tEFX_STATS_UPLOAD, 0));\n }\n \n-#endif /* EFX_OPTS_EF10() */\n+#endif /* EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() */\n #endif /* EFSYS_OPT_EVB */\ndiff --git a/drivers/common/sfc_efx/base/efx_check.h b/drivers/common/sfc_efx/base/efx_check.h\nindex af90a4c373..f9f97946e5 100644\n--- a/drivers/common/sfc_efx/base/efx_check.h\n+++ b/drivers/common/sfc_efx/base/efx_check.h\n@@ -373,8 +373,8 @@\n \n #if EFSYS_OPT_EVB\n /* Support enterprise virtual bridging */\n-# if !(EFX_OPTS_EF10())\n-# error \"EVB requires EF10 arch\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10())\n+# error \"EVB requires RIVERHEAD or EF10 arch\"\n # endif\n #endif /* EFSYS_OPT_EVB */\n \ndiff --git a/drivers/common/sfc_efx/base/efx_evb.c b/drivers/common/sfc_efx/base/efx_evb.c\nindex 17318b7e11..b6c9b88fc2 100644\n--- a/drivers/common/sfc_efx/base/efx_evb.c\n+++ b/drivers/common/sfc_efx/base/efx_evb.c\n@@ -46,6 +46,24 @@ static const efx_evb_ops_t\t__efx_evb_ef10_ops = {\n };\n #endif /* EFX_OPTS_EF10() */\n \n+#if EFSYS_OPT_RIVERHEAD\n+static const efx_evb_ops_t\t__efx_evb_rhead_ops = {\n+\tef10_evb_init,\t\t\t/* eeo_init */\n+\tef10_evb_fini,\t\t\t/* eeo_fini */\n+\tef10_evb_vswitch_alloc,\t\t/* eeo_vswitch_alloc */\n+\tef10_evb_vswitch_free,\t\t/* eeo_vswitch_free */\n+\tef10_evb_vport_alloc,\t\t/* eeo_vport_alloc */\n+\tef10_evb_vport_free,\t\t/* eeo_vport_free */\n+\tef10_evb_vport_mac_addr_add,\t/* eeo_vport_mac_addr_add */\n+\tef10_evb_vport_mac_addr_del,\t/* eeo_vport_mac_addr_del */\n+\tef10_evb_vadaptor_alloc,\t/* eeo_vadaptor_alloc */\n+\tef10_evb_vadaptor_free,\t\t/* eeo_vadaptor_free */\n+\tef10_evb_vport_assign,\t\t/* eeo_vport_assign */\n+\tef10_evb_vport_reconfigure,\t/* eeo_vport_reconfigure */\n+\tef10_evb_vport_stats,\t\t/* eeo_vport_stats */\n+};\n+#endif /* EFSYS_OPT_RIVERHEAD */\n+\n \t__checkReturn\tefx_rc_t\n efx_evb_init(\n \t__in\t\tefx_nic_t *enp)\n@@ -83,6 +101,12 @@ efx_evb_init(\n \t\tbreak;\n #endif /* EFSYS_OPT_MEDFORD2 */\n \n+#if EFSYS_OPT_RIVERHEAD\n+\tcase EFX_FAMILY_RIVERHEAD:\n+\t\teeop = &__efx_evb_rhead_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_RIVERHEAD */\n+\n \tdefault:\n \t\tEFSYS_ASSERT(0);\n \t\trc = ENOTSUP;\n", "prefixes": [ "52/60" ] }