Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78289/?format=api
{ "id": 78289, "url": "http://patches.dpdk.org/api/patches/78289/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-13-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600764594-14752-13-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600764594-14752-13-git-send-email-arybchenko@solarflare.com", "date": "2020-09-22T08:49:06", "name": "[12/60] common/sfc_efx/base: set NIC features in generic place", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "246cff8cdcf1b3940cb004bcc6b3aa2c486564e7", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-13-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12400, "url": "http://patches.dpdk.org/api/series/12400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12400", "date": "2020-09-22T08:48:59", "name": "common/sfc_efx: support Riverhead NIC family", "version": 1, "mbox": "http://patches.dpdk.org/series/12400/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78289/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 720F0A04E1;\n\tTue, 22 Sep 2020 10:57:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E80811DB92;\n\tTue, 22 Sep 2020 10:51:15 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 461C31C1B8\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:50:22 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n E39DA20054 for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:21 +0000 (UTC)", "from us4-mdac16-31.at1.mdlocal (unknown [10.110.49.215])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E2FE9800A3\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:21 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.8])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 2257610004F\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:16 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n E06244C0059\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:15 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 22 Sep 2020 09:50:09 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 09:50:09 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08M8o9lJ004626\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:09 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8622D1613A9\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:09 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 22 Sep 2020 09:49:06 +0100", "Message-ID": "<1600764594-14752-13-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-1.583500-8.000000-10", "X-TMASE-MatchedRID": "48f3rcDgjOUfLZjRGBdfQbzgL/eLACDEjs/yyyVHGh4aV9cxC+J6t+Z5\n Gn23AeDZuA9fFHhyLzx7Okmvhl+K960iin8P0KjVPwKTD1v8YV5MkOX0UoduufdG7cmuMnEoltB\n o/Ez2R6fJ4tcwPl28ZqJJJims/s54DPIzF4wRfrAURSScn+QSXt0H8LFZNFG7CKFCmhdu5cUpxd\n faW7N4HuI4vM7P9jJIT0wX/W0Ngm8ycHQDSefcEB3iQvy24OiACMO49QkG0Cxmc48Ihirc5pMh6\n vjiL7Ops677reRA/y0A5SS2XRjKFM+aZOIheolUvvUo0hZPhlzM/43UL1MJR56oP1a0mRIj", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.583500-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600764616-lQcBJYdi_QQL", "Subject": "[dpdk-dev] [PATCH 12/60] common/sfc_efx/base: set NIC features in\n\tgeneric place", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no point to duplicate it NIC family specific probe handlers.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_nic.c | 2 --\n drivers/common/sfc_efx/base/efx_nic.c | 3 +++\n drivers/common/sfc_efx/base/siena_nic.c | 3 ---\n 3 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c\nindex 47329ff8dc..4796dd6b59 100644\n--- a/drivers/common/sfc_efx/base/ef10_nic.c\n+++ b/drivers/common/sfc_efx/base/ef10_nic.c\n@@ -2098,8 +2098,6 @@ ef10_nic_probe(\n \t}\n #endif\n \n-\tencp->enc_features = enp->en_features;\n-\n \treturn (0);\n \n #if EFSYS_OPT_MON_STATS\ndiff --git a/drivers/common/sfc_efx/base/efx_nic.c b/drivers/common/sfc_efx/base/efx_nic.c\nindex b5e36661c9..9d6961e2ff 100644\n--- a/drivers/common/sfc_efx/base/efx_nic.c\n+++ b/drivers/common/sfc_efx/base/efx_nic.c\n@@ -318,6 +318,7 @@ efx_nic_probe(\n \t__in\t\tefx_nic_t *enp,\n \t__in\t\tefx_fw_variant_t efv)\n {\n+\tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n \tconst efx_nic_ops_t *enop;\n \tefx_rc_t rc;\n \n@@ -351,6 +352,8 @@ efx_nic_probe(\n \tif ((rc = enop->eno_probe(enp)) != 0)\n \t\tgoto fail1;\n \n+\tencp->enc_features = enp->en_features;\n+\n \tif ((rc = efx_phy_probe(enp)) != 0)\n \t\tgoto fail2;\n \ndiff --git a/drivers/common/sfc_efx/base/siena_nic.c b/drivers/common/sfc_efx/base/siena_nic.c\nindex bd5e8ceb8a..b9b6d1951c 100644\n--- a/drivers/common/sfc_efx/base/siena_nic.c\n+++ b/drivers/common/sfc_efx/base/siena_nic.c\n@@ -301,7 +301,6 @@ siena_nic_probe(\n \t__in\t\tefx_nic_t *enp)\n {\n \tefx_port_t *epp = &(enp->en_port);\n-\tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n \tsiena_link_state_t sls;\n \tunsigned int mask;\n \tefx_oword_t oword;\n@@ -369,8 +368,6 @@ siena_nic_probe(\n \t\tgoto fail12;\n #endif\n \n-\tencp->enc_features = enp->en_features;\n-\n \treturn (0);\n \n #if EFSYS_OPT_MON_STATS\n", "prefixes": [ "12/60" ] }