Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 78070,
    "url": "http://patches.dpdk.org/api/patches/78070/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200918054518.208990-1-ruifeng.wang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200918054518.208990-1-ruifeng.wang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200918054518.208990-1-ruifeng.wang@arm.com",
    "date": "2020-09-18T05:45:17",
    "name": "crypto/armv8: remove crypto enum list end references",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6eac20282ec6d80c7c4672d61c9fbf1d64ceeff2",
    "submitter": {
        "id": 1198,
        "url": "http://patches.dpdk.org/api/people/1198/?format=api",
        "name": "Ruifeng Wang",
        "email": "ruifeng.wang@arm.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200918054518.208990-1-ruifeng.wang@arm.com/mbox/",
    "series": [
        {
            "id": 12332,
            "url": "http://patches.dpdk.org/api/series/12332/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12332",
            "date": "2020-09-18T05:45:17",
            "name": "crypto/armv8: remove crypto enum list end references",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12332/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/78070/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/78070/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7962A04C7;\n\tFri, 18 Sep 2020 07:45:45 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 03AF21D8D8;\n\tFri, 18 Sep 2020 07:45:45 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 4FE621D8D3\n for <dev@dpdk.org>; Fri, 18 Sep 2020 07:45:43 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B03EA11D4;\n Thu, 17 Sep 2020 22:45:42 -0700 (PDT)",
            "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.116])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 808913F68F;\n Thu, 17 Sep 2020 22:45:40 -0700 (PDT)"
        ],
        "From": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "To": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "Cc": "dev@dpdk.org, arkadiuszx.kusztal@intel.com, akhil.goyal@nxp.com,\n honnappa.nagarahalli@arm.com, nd@arm.com",
        "Date": "Fri, 18 Sep 2020 13:45:17 +0800",
        "Message-Id": "<20200918054518.208990-1-ruifeng.wang@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] crypto/armv8: remove crypto enum list end\n\treferences",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Removed references to RTE_CRYPTO_CIPHER_LIST_END and\nRTE_CRYPTO_AUTH_LIST_END.\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\nThis is follow up of cryptodev change:\nhttp://patches.dpdk.org/patch/76330/\n drivers/crypto/armv8/armv8_pmd_private.h | 6 ++----\n drivers/crypto/armv8/rte_armv8_pmd.c     | 9 ++++++---\n 2 files changed, 8 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/armv8/armv8_pmd_private.h\nindex 66b03fb92..75ddba79c 100644\n--- a/drivers/crypto/armv8/armv8_pmd_private.h\n+++ b/drivers/crypto/armv8/armv8_pmd_private.h\n@@ -70,11 +70,9 @@ enum armv8_crypto_auth_mode {\n \tARMV8_CRYPTO_AUTH_LIST_END = ARMV8_CRYPTO_AUTH_NOT_SUPPORTED\n };\n \n-#define CRYPTO_ORDER_MAX\t\tARMV8_CRYPTO_CHAIN_LIST_END\n-#define CRYPTO_CIPHER_OP_MAX\t\tARMV8_CRYPTO_CIPHER_OP_LIST_END\n #define CRYPTO_CIPHER_KEYLEN_MAX\tARMV8_CRYPTO_CIPHER_KEYLEN_LIST_END\n-#define CRYPTO_CIPHER_MAX\t\tRTE_CRYPTO_CIPHER_LIST_END\n-#define CRYPTO_AUTH_MAX\t\t\tRTE_CRYPTO_AUTH_LIST_END\n+#define CRYPTO_CIPHER_MAX\t\t(RTE_CRYPTO_CIPHER_AES_ECB + 1)\n+#define CRYPTO_AUTH_MAX\t\t\t(RTE_CRYPTO_AUTH_SHA512_HMAC + 1)\n \n #define HMAC_IPAD_VALUE\t\t\t(0x36)\n #define HMAC_OPAD_VALUE\t\t\t(0x5C)\ndiff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c\nindex c95729db5..c3db711b7 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd.c\n@@ -143,7 +143,8 @@ crypto_chain_order[] = {\n \tcrypto_func_tbl_t *func_tbl =\t\t\t\t\t\\\n \t\t\t\t(crypto_chain_order[(order)])[(cop)];\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t((*func_tbl)[(calg)][(aalg)][KEYL(keyl)]);\t\t\\\n+\t((calg >= CRYPTO_CIPHER_MAX) || (aalg >= CRYPTO_AUTH_MAX)) ?\t\\\n+\t\tNULL : ((*func_tbl)[(calg)][(aalg)][KEYL(keyl)]);\t\\\n })\n \n /*----------------------------------------------------------------------------*/\n@@ -188,7 +189,8 @@ crypto_key_sched_dir[] = {\n ({\t\t\t\t\t\t\t\t\t\\\n \tcrypto_key_sched_tbl_t *ks_tbl = crypto_key_sched_dir[(cop)];\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t((*ks_tbl)[(calg)][KEYL(keyl)]);\t\t\t\t\\\n+\t(calg >= CRYPTO_CIPHER_MAX) ?\t\t\t\t\t\\\n+\t\tNULL : ((*ks_tbl)[(calg)][KEYL(keyl)]);\t\t\t\\\n })\n \n /*----------------------------------------------------------------------------*/\n@@ -436,7 +438,8 @@ armv8_crypto_set_session_chained_parameters(struct armv8_crypto_session *sess,\n \t\treturn -ENOTSUP;\n \t}\n \n-\tif (unlikely(sess->crypto_func == NULL)) {\n+\tif (unlikely(sess->crypto_func == NULL ||\n+\t\tsess->cipher.key_sched == NULL)) {\n \t\t/*\n \t\t * If we got here that means that there must be a bug\n \t\t * in the algorithms selection above. Nevertheless keep\n",
    "prefixes": []
}