Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77977,
    "url": "http://patches.dpdk.org/api/patches/77977/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-18-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200917053035.1889989-18-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-18-mk@semihalf.com",
    "date": "2020-09-17T05:30:32",
    "name": "[17/20] net/ena/base: simplify loop copying Rx descs",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c399f0c45d167f96d745727e2e0348bfdd9af413",
    "submitter": {
        "id": 786,
        "url": "http://patches.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-18-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 12298,
            "url": "http://patches.dpdk.org/api/series/12298/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12298",
            "date": "2020-09-17T05:30:15",
            "name": "Upgrade HAL and add ENI metrics support",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12298/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77977/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77977/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB607A04B6;\n\tThu, 17 Sep 2020 07:33:33 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBBD71D5A3;\n\tThu, 17 Sep 2020 07:31:21 +0200 (CEST)",
            "from mail-lj1-f169.google.com (mail-lj1-f169.google.com\n [209.85.208.169]) by dpdk.org (Postfix) with ESMTP id EB40E1D583\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:31:13 +0200 (CEST)",
            "by mail-lj1-f169.google.com with SMTP id k25so917920ljk.0\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:31:13 -0700 (PDT)",
            "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:31:12 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=fMRSWuDUq8h4HkN7vPjeZ8tPid29yrJTNMESmMIIVqA=;\n b=JlTUDOdUyQ/IyZMW6HoOgFSNCSUFzTEy0cFOz6RnnOrik+LY/Y/swUGsj9UQsR5BXL\n cgutPHEJFV9ABWrmzsnKPx+S5tWBxP4kVvERCbi7qrAiro3JDtRiqnicBepC6tSasETL\n VauNfPbRlxx1v+POjluXE3Bn8/QNhBddMjqci138aR29gD4L8eeCvzrbRGC3ggHw/cn7\n VjfxqEVdMd0RfjtW55CmFVlRTI54P4T7B7FYbxVMHGoGJ92NM/cKlbhL76xaS3CIMHUt\n RisTINiiAyGpXjrTPiTOs7C2PUJ8PZhGQ1rm3Lg4e0aT5RRdXyeg2QJX9dg4SRYzNUO2\n VgvA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=fMRSWuDUq8h4HkN7vPjeZ8tPid29yrJTNMESmMIIVqA=;\n b=UweOMneYOAa9t14BwLbsnt4lcKEiRIsOWPBTZfYWx+FHzNuf6FZnu3HJo/a0jAQ3ZU\n tmPL2q13wp2/+T+I7s6LqJZuL+1c0wammLYSxaExkI2lWpaN6h9LxT/DvBIrpbV3E8l+\n TjgyjcLTxtRtTH72kb30NMI0YFgrUggzcJHqLV/O1BRCNLiWL4c4+XZEIkxYN03smRD5\n y/v7FSLy0twI1DCJtTEtuCBBSVeCZyGObKkjMrGkt9oASuZn9u2augM8I8LxwDtkUObc\n H/QwC2mOcBQ1fBGxwXeVPwdgxJ36gpvZHQ9v0a8vR9kYRQxm+jRe5i1hz0qdwr9WVJQH\n X/uA==",
        "X-Gm-Message-State": "AOAM533hI1ytgWInnaepXxa8BdvgyLnv+JsxgOznOih+UJgduut1lBfB\n eYDOWI/01Gr6iFaT6XWUtmyXXJ5hA20rjQW+",
        "X-Google-Smtp-Source": "\n ABdhPJyUqauF9LtB3mAUraieLOnjx7aBBvg8cJldEQW7qn4SkGmw6ka8T91M2/M0SVIK6zsZx974Zw==",
        "X-Received": "by 2002:a2e:8705:: with SMTP id m5mr8918019lji.459.1600320673244;\n Wed, 16 Sep 2020 22:31:13 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n Marcin Wojtas <mw@semihalf.com>, Evgeny Schemeilin <evgenys@amazon.com>",
        "Date": "Thu, 17 Sep 2020 07:30:32 +0200",
        "Message-Id": "<20200917053035.1889989-18-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>",
        "References": "<20200917053035.1889989-1-mk@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 17/20] net/ena/base: simplify loop copying Rx\n\tdescs",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Checking for the cdesc not being NULL doesn't have any sense if the idx\nargument is not 0, so it can be skipped, as the error won't be detected\nanyway.\n\nTo simplify that, only the 'i' value is being verified and the code is\nbreaking from the infinite loop in case when all descriptors were copied\ninto the buffer.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_eth_com.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c\nindex 766643f47b..a35d92fbd3 100644\n--- a/drivers/net/ena/base/ena_eth_com.c\n+++ b/drivers/net/ena/base/ena_eth_com.c\n@@ -557,10 +557,15 @@ int ena_com_rx_pkt(struct ena_com_io_cq *io_cq,\n \tena_rx_ctx->pkt_offset = cdesc->offset;\n \n \tdo {\n-\t\tena_buf->len = cdesc->length;\n-\t\tena_buf->req_id = cdesc->req_id;\n-\t\tena_buf++;\n-\t} while ((++i < nb_hw_desc) && (cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i)));\n+\t\tena_buf[i].len = cdesc->length;\n+\t\tena_buf[i].req_id = cdesc->req_id;\n+\n+\t\tif (++i >= nb_hw_desc)\n+\t\t\tbreak;\n+\n+\t\tcdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i);\n+\n+\t} while (1);\n \n \t/* Update SQ head ptr */\n \tio_sq->next_to_comp += nb_hw_desc;\n",
    "prefixes": [
        "17/20"
    ]
}