Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77976/?format=api
{ "id": 77976, "url": "http://patches.dpdk.org/api/patches/77976/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-17-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200917053035.1889989-17-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-17-mk@semihalf.com", "date": "2020-09-17T05:30:31", "name": "[16/20] net/ena/base: convert values to u32 before shifting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ce4f01bfd7fc93f91d9345f9abc399d4cd6cb41", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-17-mk@semihalf.com/mbox/", "series": [ { "id": 12298, "url": "http://patches.dpdk.org/api/series/12298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12298", "date": "2020-09-17T05:30:15", "name": "Upgrade HAL and add ENI metrics support", "version": 1, "mbox": "http://patches.dpdk.org/series/12298/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77976/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77976/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB48BA04B6;\n\tThu, 17 Sep 2020 07:33:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9050D1D59C;\n\tThu, 17 Sep 2020 07:31:20 +0200 (CEST)", "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 290C31D57C\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:31:12 +0200 (CEST)", "by mail-lf1-f66.google.com with SMTP id d15so749998lfq.11\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:31:12 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:31:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=uQhraO1g72tWjTGxSAywlOStDpmL/77DQ8ZO6LgDuX4=;\n b=o31ypeNEnAcLtNUOj9gmDAwqyjJw8ropNn58xUudxn251MkagiuiVk1apS7igz4ljP\n 739hrlpV4o9KUp0V3MMvikARDapH/00zzje40sIf4x17Unt86YpKayI5IZl/iS7G7uv0\n O97TEPPkNh6MoAPz8fI30d4Qehd+Zm+uoZbuC7U+S5DPgyXB0j+hEdCQKeH1zxuOiG0/\n uVoxRco1dSv28dKU8b6hqsKpLP1hVaep1begkaA/Pgmazs2+zZrn9WzUUhknWKdTVLgI\n mVfHu82L2FTDtPvNUNuC9RDD4gDbcgge0p4+pUVowVYhhYQY+Hh+OiBbkQ3LbhLpHiT6\n XaHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=uQhraO1g72tWjTGxSAywlOStDpmL/77DQ8ZO6LgDuX4=;\n b=fdMIqIw6YaV6ma+aR/FtO5z/DsvtJRSEE1TX6kRl0hXCzSjKUXhbiydA7dbPcISncw\n /xr7iMgYTYAw1vFR/vGil9h8dys+qHqjjQQ2qZTH0+lxskeVwHKWJ2QxMQVTUSQzrRPS\n gaWb9G7LCGCI0z+1OgZ1NhEo/Tb18TI+8VrEapz5Z6XTAVaHX9Wl4AOzQZAsc+bvkB+E\n Dc74kw48W97NGG5F3as38pD88tREKtsnkV0JJA7sgbyKKqHJcv0HM3CGsjmM/JHXtnyh\n nt5U3Ool/sAl+x1xavQMM24RuobdV4H/kJcDfhSaFeuO2IcGuMOlgKwU+QhGpikQ0B4k\n uLqA==", "X-Gm-Message-State": "AOAM532Ty/bdYw005GwmHvjQcUi7uwYjr+gsLrh6wnp0dHksmHzgr8XL\n eLJggHGDTaZFD151aIFGlrYQ/QtKazBpT2f/", "X-Google-Smtp-Source": "\n ABdhPJyM4eqqUYSpGGXC4tAtd//biXalDetMeZ+DU7akDHsRrnmiHKdnDP++8ddsDSdKjhObLRTeyg==", "X-Received": "by 2002:a05:6512:2101:: with SMTP id\n q1mr10198739lfr.157.1600320671384;\n Wed, 16 Sep 2020 22:31:11 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n Marcin Wojtas <mw@semihalf.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Date": "Thu, 17 Sep 2020 07:30:31 +0200", "Message-Id": "<20200917053035.1889989-17-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>", "References": "<20200917053035.1889989-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 16/20] net/ena/base: convert values to u32 before\n\tshifting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When filling out meta descriptor, all values should be converted to the\ndesired type (u32 in case of the meta descriptor) to prevent losing the\ndata.\n\nFor example, io_sq->phase is of type u8. If\nENA_ETH_IO_TX_META_DESC_PHASE_SHIFT would be greater then 8, all data\nwould be lost.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_eth_com.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c\nindex b6821a7917..766643f47b 100644\n--- a/drivers/net/ena/base/ena_eth_com.c\n+++ b/drivers/net/ena/base/ena_eth_com.c\n@@ -278,7 +278,7 @@ static int ena_com_create_meta(struct ena_com_io_sq *io_sq,\n \tmeta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_EXT_VALID_MASK;\n \n \t/* bits 0-9 of the mss */\n-\tmeta_desc->word2 |= (ena_meta->mss <<\n+\tmeta_desc->word2 |= ((u32)ena_meta->mss <<\n \t\tENA_ETH_IO_TX_META_DESC_MSS_LO_SHIFT) &\n \t\tENA_ETH_IO_TX_META_DESC_MSS_LO_MASK;\n \t/* bits 10-13 of the mss */\n@@ -288,7 +288,7 @@ static int ena_com_create_meta(struct ena_com_io_sq *io_sq,\n \n \t/* Extended meta desc */\n \tmeta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_ETH_META_TYPE_MASK;\n-\tmeta_desc->len_ctrl |= (io_sq->phase <<\n+\tmeta_desc->len_ctrl |= ((u32)io_sq->phase <<\n \t\tENA_ETH_IO_TX_META_DESC_PHASE_SHIFT) &\n \t\tENA_ETH_IO_TX_META_DESC_PHASE_MASK;\n \n@@ -301,7 +301,7 @@ static int ena_com_create_meta(struct ena_com_io_sq *io_sq,\n \t\tENA_ETH_IO_TX_META_DESC_L3_HDR_OFF_SHIFT) &\n \t\tENA_ETH_IO_TX_META_DESC_L3_HDR_OFF_MASK;\n \n-\tmeta_desc->word2 |= (ena_meta->l4_hdr_len <<\n+\tmeta_desc->word2 |= ((u32)ena_meta->l4_hdr_len <<\n \t\tENA_ETH_IO_TX_META_DESC_L4_HDR_LEN_IN_WORDS_SHIFT) &\n \t\tENA_ETH_IO_TX_META_DESC_L4_HDR_LEN_IN_WORDS_MASK;\n \n@@ -434,16 +434,16 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \tif (!have_meta)\n \t\tdesc->len_ctrl |= ENA_ETH_IO_TX_DESC_FIRST_MASK;\n \n-\tdesc->buff_addr_hi_hdr_sz |= (header_len <<\n+\tdesc->buff_addr_hi_hdr_sz |= ((u32)header_len <<\n \t\tENA_ETH_IO_TX_DESC_HEADER_LENGTH_SHIFT) &\n \t\tENA_ETH_IO_TX_DESC_HEADER_LENGTH_MASK;\n-\tdesc->len_ctrl |= (io_sq->phase << ENA_ETH_IO_TX_DESC_PHASE_SHIFT) &\n+\tdesc->len_ctrl |= ((u32)io_sq->phase << ENA_ETH_IO_TX_DESC_PHASE_SHIFT) &\n \t\tENA_ETH_IO_TX_DESC_PHASE_MASK;\n \n \tdesc->len_ctrl |= ENA_ETH_IO_TX_DESC_COMP_REQ_MASK;\n \n \t/* Bits 0-9 */\n-\tdesc->meta_ctrl |= (ena_tx_ctx->req_id <<\n+\tdesc->meta_ctrl |= ((u32)ena_tx_ctx->req_id <<\n \t\tENA_ETH_IO_TX_DESC_REQ_ID_LO_SHIFT) &\n \t\tENA_ETH_IO_TX_DESC_REQ_ID_LO_MASK;\n \n@@ -491,7 +491,7 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,\n \n \t\t\tmemset(desc, 0x0, sizeof(struct ena_eth_io_tx_desc));\n \n-\t\t\tdesc->len_ctrl |= (io_sq->phase <<\n+\t\t\tdesc->len_ctrl |= ((u32)io_sq->phase <<\n \t\t\t\tENA_ETH_IO_TX_DESC_PHASE_SHIFT) &\n \t\t\t\tENA_ETH_IO_TX_DESC_PHASE_MASK;\n \t\t}\n", "prefixes": [ "16/20" ] }