Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77973,
    "url": "http://patches.dpdk.org/api/patches/77973/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-14-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200917053035.1889989-14-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-14-mk@semihalf.com",
    "date": "2020-09-17T05:30:28",
    "name": "[13/20] net/ena/base: add missing unlikely",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "09387d2ff5af7e3b56be115c33be38e462277f0e",
    "submitter": {
        "id": 786,
        "url": "http://patches.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-14-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 12298,
            "url": "http://patches.dpdk.org/api/series/12298/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12298",
            "date": "2020-09-17T05:30:15",
            "name": "Upgrade HAL and add ENI metrics support",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12298/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77973/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77973/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3C73A04B6;\n\tThu, 17 Sep 2020 07:32:52 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8BEC81D585;\n\tThu, 17 Sep 2020 07:31:14 +0200 (CEST)",
            "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id D014C1D56F\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:31:07 +0200 (CEST)",
            "by mail-lj1-f195.google.com with SMTP id r24so900647ljm.3\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:31:07 -0700 (PDT)",
            "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:31:06 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=NrNtQihIvJUKFUEgQMk6tw9kFNfQ9T8KGc+43DQP0Xk=;\n b=vrZ25P1zUEVpx3s0gtqcLYj9ciCjFnaZ0IGr9aGj7+Xf9JCtCOVD2pnRypLIkhytso\n VKH1azY+ZK80PdnTuhwLcW3sEU/dUBdRBx1yI+dbOHHnBBZ2tUjr5Yggdw7YD7nEPl8U\n DKfbgYYECesr0HQ10g8VP/lJXvNjYc0e/+GmxntjGavhspMWyy/Y0Cy0qRJDyDgOtIM0\n Hl5cgMCAd+Sf3Bbc/BKyXWN6Jc817URwbs+ncxKcPTp7wzmkuh7seD+FuOnMWVvqGHKs\n H1Nas4BX0WYzSC/hNI/L1rPZ8gSpcVa/Drew6l61DmBrc6C/+M3pSiJpbJO3VhaJ8G8F\n XTBA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=NrNtQihIvJUKFUEgQMk6tw9kFNfQ9T8KGc+43DQP0Xk=;\n b=lL2PALyuB9/JUEUdEyOKR7eFVmqlBWM47dxZVVlE9Nj5SoxhxhcPreVTaRnbwgk1qz\n XInAUXMX5uqZ0ggGNBhNAxo3/j8tcQ8LKuNV7D4dxThyHn7gU1/OxR2hpEPcoQ7zfnkk\n 8kv6JZmd/0RmOw/NC2VlVEVYaCU5cj2xpUEyp6ox1bPSXMPLo8eGGv/gSTeUxzuakop7\n foCxjqFCfu/0+G1B+rteLkKer7xJ1lEnZwbW/QuRmg4lCi075W4NS9rv1//4JXt/oYAd\n RmgBrcwFp6jDwy8Q2q9EDEEWDejPxxZE8I7jHpHVlJYzmywrWlaZaR1ySHqsdsUxyaD7\n WOiQ==",
        "X-Gm-Message-State": "AOAM532I0qq5ngDeiDJXkVpOJIWJC2hJ/npNTmAwKgXLrdZPygWO554y\n 1QAdugYO0MTplTbejyXoZ074LgT4NiKraVjt",
        "X-Google-Smtp-Source": "\n ABdhPJwqAJb5Zcwn3utzHLeTGF174rR0P0lZPmoIUzwDI7DSrFSAFhdVxBwGyk4HWdvmDrKusugTdw==",
        "X-Received": "by 2002:a2e:6f1c:: with SMTP id k28mr8809381ljc.297.1600320667103;\n Wed, 16 Sep 2020 22:31:07 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n Marcin Wojtas <mw@semihalf.com>, Evgeny Schemeilin <evgenys@amazon.com>",
        "Date": "Thu, 17 Sep 2020 07:30:28 +0200",
        "Message-Id": "<20200917053035.1889989-14-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>",
        "References": "<20200917053035.1889989-1-mk@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 13/20] net/ena/base: add missing unlikely",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "To align the error checking code with other parts of the ena_com,\nthe conditional check is being tested for the error was wrapped inside\nunlikely().\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex f2668f79c7..3686ae05c4 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -2973,7 +2973,7 @@ int ena_com_config_dev_mode(struct ena_com_dev *ena_dev,\n \tena_dev->tx_max_header_size = llq_info->desc_list_entry_size -\n \t\t(llq_info->descs_num_before_header * sizeof(struct ena_eth_io_tx_desc));\n \n-\tif (ena_dev->tx_max_header_size == 0) {\n+\tif (unlikely(ena_dev->tx_max_header_size == 0)) {\n \t\tena_trc_err(\"the size of the LLQ entry is smaller than needed\\n\");\n \t\treturn -EINVAL;\n \t}\n",
    "prefixes": [
        "13/20"
    ]
}