Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77970/?format=api
{ "id": 77970, "url": "http://patches.dpdk.org/api/patches/77970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-11-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200917053035.1889989-11-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-11-mk@semihalf.com", "date": "2020-09-17T05:30:25", "name": "[10/20] net/ena/base: do not use hardcoded RSS key buffer size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "be5eb9d45f07519c32b22482743d42783f16b174", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-11-mk@semihalf.com/mbox/", "series": [ { "id": 12298, "url": "http://patches.dpdk.org/api/series/12298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12298", "date": "2020-09-17T05:30:15", "name": "Upgrade HAL and add ENI metrics support", "version": 1, "mbox": "http://patches.dpdk.org/series/12298/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77970/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/77970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C083A04B6;\n\tThu, 17 Sep 2020 07:32:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7D951D56D;\n\tThu, 17 Sep 2020 07:31:08 +0200 (CEST)", "from mail-lf1-f44.google.com (mail-lf1-f44.google.com\n [209.85.167.44]) by dpdk.org (Postfix) with ESMTP id 2F1101D55C\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:31:03 +0200 (CEST)", "by mail-lf1-f44.google.com with SMTP id b12so755617lfp.9\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:31:03 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:31:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=zZlLyEbMXe5z9zzDgiUY8fqJ+y56WoZFwsGOkjcipH0=;\n b=njFCUP80WCRCy+Eyy9PKSPX+8XQsZFj7JJYkRTJ1TfKEIWyHvWj/2rlOSNxNF9IMLF\n vp18ELsQnqTij368OSkgilVdf0/pHOiIbiTme5yiHoUERHW9nXxmIE3ihZhe6FM6zSUt\n 5pZ588c1p7P1SiYPwtisFWv5DuhfAzl+7dXkhtNSG34UEjHBcPZFMaC5clMD6058IqIN\n 3wLZWESPNzxgOKq43lasQD5tEZq7zOLhkrDLOt1t5b4pL5zRfMrpq3Rp9hLvIuaXjMsU\n GVXHycEI6ByTYA17xefmZRM655CWN8bl6C5ZAU+rlRnxqbSVqypLAwWrcIhfo/wJTdaq\n 6ztw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=zZlLyEbMXe5z9zzDgiUY8fqJ+y56WoZFwsGOkjcipH0=;\n b=DrIhIuit5YhoYbbX+cZbpxLwV0m7zTMOarM+Ohlm9GmXgplvj8om4PoBVh5TpVntNE\n xuXOQ9ja032jQsuJbJ7vhlsGX7vw4ZrC0Wfu6LY3AUx3Ir90ditNtaQ2iw2+TmvBRlOP\n pl7+6PsLSk9Bhns2ubpqAcdtCCXcv8pabQileM9Gfok19shWzUyogxx2JW2teCZTnoIQ\n 3weFXq+kfDORUSELyvntcMyGes6dnMjo4EBllYVphU/qQzE9HMcgxyRtvnaYil6wDjnV\n qxJ3MnxFOQwLBRyPJoL3ON+QVQL2dW5+tHIzVB2C2KdTrepW6Bolohd/DjWqhjSZuZSd\n JzGg==", "X-Gm-Message-State": "AOAM531iEMWiWbJ2cyfL2BasqaH6VmgU0zH4/12j8wJSzhuNXLfS4E/l\n yfdbJs/x48Z6PZYnvDQ2r3zpr824tQ7oRT2u", "X-Google-Smtp-Source": "\n ABdhPJxHe2l2IoN5E2hauOtyRRBCdQ/um+uFN2rFcYAsLVHE/7be3euCVoOget2n9fewaDj539tMHA==", "X-Received": "by 2002:a19:e54:: with SMTP id 81mr10274149lfo.178.1600320662509;\n Wed, 16 Sep 2020 22:31:02 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n Marcin Wojtas <mw@semihalf.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Date": "Thu, 17 Sep 2020 07:30:25 +0200", "Message-Id": "<20200917053035.1889989-11-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>", "References": "<20200917053035.1889989-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/20] net/ena/base: do not use hardcoded RSS key\n\tbuffer size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It's well defined how the RSS key buffer looks from the device\nperspective, so the constant calue should be used instead of magic\nnumber. Also it doesn't has to be calculated dynamically.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 7 +++----\n drivers/net/ena/base/ena_defs/ena_admin_defs.h | 4 +++-\n 2 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex bf1de09c5c..ea7d6788c9 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -1073,11 +1073,10 @@ static void ena_com_hash_key_fill_default_key(struct ena_com_dev *ena_dev)\n \t\t(ena_dev->rss).hash_key;\n \n \tENA_RSS_FILL_KEY(&hash_key->key, sizeof(hash_key->key));\n-\t/* The key is stored in the device in uint32_t array\n-\t * as well as the API requires the key to be passed in this\n-\t * format. Thus the size of our array should be divided by 4\n+\t/* The key buffer is stored in the device in an array of\n+\t * uint32 elements.\n \t */\n-\thash_key->keys_num = sizeof(hash_key->key) / sizeof(uint32_t);\n+\thash_key->keys_num = ENA_ADMIN_RSS_KEY_PARTS;\n }\n \n static int ena_com_hash_key_allocate(struct ena_com_dev *ena_dev)\ndiff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h b/drivers/net/ena/base/ena_defs/ena_admin_defs.h\nindex be1747cd9f..9cea1c3905 100644\n--- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h\n+++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h\n@@ -9,6 +9,8 @@\n #define ENA_ADMIN_EXTRA_PROPERTIES_STRING_LEN 32\n #define ENA_ADMIN_EXTRA_PROPERTIES_COUNT 32\n \n+#define ENA_ADMIN_RSS_KEY_PARTS 10\n+\n enum ena_admin_aq_opcode {\n \tENA_ADMIN_CREATE_SQ = 1,\n \tENA_ADMIN_DESTROY_SQ = 2,\n@@ -732,7 +734,7 @@ struct ena_admin_feature_rss_flow_hash_control {\n \n \tuint32_t reserved;\n \n-\tuint32_t key[10];\n+\tuint32_t key[ENA_ADMIN_RSS_KEY_PARTS];\n };\n \n struct ena_admin_feature_rss_flow_hash_function {\n", "prefixes": [ "10/20" ] }