Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77965,
    "url": "http://patches.dpdk.org/api/patches/77965/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-6-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200917053035.1889989-6-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-6-mk@semihalf.com",
    "date": "2020-09-17T05:30:20",
    "name": "[05/20] net/ena/base: fix release of wait event",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c3ee404f5982000082e0b30f36b110e8b4cf692f",
    "submitter": {
        "id": 786,
        "url": "http://patches.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200917053035.1889989-6-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 12298,
            "url": "http://patches.dpdk.org/api/series/12298/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12298",
            "date": "2020-09-17T05:30:15",
            "name": "Upgrade HAL and add ENI metrics support",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12298/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77965/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77965/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F12EA04B6;\n\tThu, 17 Sep 2020 07:31:35 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B06E1D550;\n\tThu, 17 Sep 2020 07:31:00 +0200 (CEST)",
            "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 002941D540\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:30:55 +0200 (CEST)",
            "by mail-lj1-f196.google.com with SMTP id s205so887292lja.7\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:30:55 -0700 (PDT)",
            "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.30.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:30:54 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=griwyDxyrsBF3QzlrybU5mtXYmQNSdktR2bBNHCizzk=;\n b=oLdFFx8BEDvk4Uz0Lk1+N1mZcwjM+MEh/jsVM/7iUvdkThQP3eREjOjBfhvvMbmmNp\n /DN2an/GkqoHzFkyeb4BlULcistJzbiarIK0UjeIjPly+/42LqEX6ZJY55mwUXiKDDKK\n 9ZlaFOWrBFUXH0jDLuhknzuPclEed59hiR9XiantjVOG1RSWafD0+F1MQYCrRGhkfYIo\n lowTjFOAd8v7nLbGYfhKN1MDK7hsJsPYI1TfagR52A5cvtxT0AsVa6AlB9coZNw/NZ1m\n G+ruBdk0BjBd7jIgrOFrwjN3Vg1OWwenygxN5SyhvCsqB9F0r5SJFWSsko+ca6kt88/g\n hGXw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=griwyDxyrsBF3QzlrybU5mtXYmQNSdktR2bBNHCizzk=;\n b=ZwZKKZ8LT+BfqLpt3AZOXdpjYnHus/AVCKACqSQvcQQ05LffZ7Zjiy7c9hdqwKF5v9\n Nqjnrlz7e1d9JTWzozp0/mo/FmgS4PPJKMI/m9kiRStkaKMu8MOlMmoc9WKgGW/qtz97\n lAgWpKBwB4/GZHfRqQTvzTPqZTXliwb8jo035VmAJeZrmIINNIIqHBSo//w/HMZIZt8Y\n J0AsxtQKW+f/uWVsCt7FpF9KDeYTPfV+FULOKs4TkN2C72FZP1SUwL0Re3Q7dbwgeHVD\n mPX9uMOQbiCd+cpCCLb6tCJBWrQgDm4XaNO1jxuAv2M56b7nO8MWNYtEHmvpKjRw2+Vg\n 37Vw==",
        "X-Gm-Message-State": "AOAM530msXh1yRL+mZoYLCbK7bZ1/2O4KH73D4eawx5v8ooDXZ3cgaE0\n uo5umf1eeyTcr0K4cm0j3BCzCS56Xr5F4+m6",
        "X-Google-Smtp-Source": "\n ABdhPJxGw4yi+/x4rqqFmVVfgR1Psz7zG6y/w4t8JATqvyU2jX2fTAmqblMbaoqHVYI+c/gQ5yxUcw==",
        "X-Received": "by 2002:a2e:7119:: with SMTP id\n m25mr10407129ljc.365.1600320655412;\n Wed, 16 Sep 2020 22:30:55 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>,\n Evgeny Schemeilin <evgenys@amazon.com>",
        "Date": "Thu, 17 Sep 2020 07:30:20 +0200",
        "Message-Id": "<20200917053035.1889989-6-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>",
        "References": "<20200917053035.1889989-1-mk@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 05/20] net/ena/base: fix release of wait event",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The wait event is being accessed without making sure it the completion\ncontext exists. The check for that is just below, so it could be used\nfor releasing wait even safely.\n\nFixes: 3adcba9a8987 (\"net/ena: update HAL to the newer version\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex b4e54318c6..ce239ab164 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -1655,11 +1655,13 @@ void ena_com_admin_destroy(struct ena_com_dev *ena_dev)\n \tstruct ena_com_aenq *aenq = &ena_dev->aenq;\n \tu16 size;\n \n-\tENA_WAIT_EVENT_DESTROY(admin_queue->comp_ctx->wait_event);\n-\tif (admin_queue->comp_ctx)\n+\tif (admin_queue->comp_ctx) {\n+\t\tENA_WAIT_EVENT_DESTROY(admin_queue->comp_ctx->wait_event);\n \t\tENA_MEM_FREE(ena_dev->dmadev,\n \t\t\t     admin_queue->comp_ctx,\n \t\t\t     (admin_queue->q_depth * sizeof(struct ena_comp_ctx)));\n+\t}\n+\n \tadmin_queue->comp_ctx = NULL;\n \tsize = ADMIN_SQ_SIZE(admin_queue->q_depth);\n \tif (sq->entries)\n",
    "prefixes": [
        "05/20"
    ]
}