Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77914/?format=api
{ "id": 77914, "url": "http://patches.dpdk.org/api/patches/77914/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916164429.244847-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916164429.244847-5-bruce.richardson@intel.com", "date": "2020-09-16T16:44:28", "name": "[RFC,4/5] build: add defines for compatibility with make build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "73f241101104eb2fa3a0a1b3c0cb10af2bbbe12d", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12283, "url": "http://patches.dpdk.org/api/series/12283/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12283", "date": "2020-09-16T16:44:24", "name": "rework feature enabling macros for compatibility", "version": 1, "mbox": "http://patches.dpdk.org/series/12283/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77914/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27E43A04B5;\n\tWed, 16 Sep 2020 18:45:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3CF001D172;\n\tWed, 16 Sep 2020 18:44:47 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 01E231D172;\n Wed, 16 Sep 2020 18:44:43 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Sep 2020 09:44:43 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga005.jf.intel.com with ESMTP; 16 Sep 2020 09:44:42 -0700" ], "IronPort-SDR": [ "\n 7FUMubcHR+lXS+6okKLNiMgJo/8jj97E46uJ5LrfERQyhqASXT3uKRDBw0odneTc1gcWmm9cgF\n 9Vc4HX686KHQ==", "\n ndEA7sMyC4QxQKYIo/kqkVwXFHJAzGM2wTAOYSzgixgO3MsvkHcBtgKoplCgSPfGKX3gsfclUd\n I3UiojR8Jb5Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9746\"; a=\"160441958\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"160441958\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"483381432\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n stable@dpdk.org", "Date": "Wed, 16 Sep 2020 17:44:28 +0100", "Message-Id": "<20200916164429.244847-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200916164429.244847-1-bruce.richardson@intel.com>", "References": "<20200916164429.244847-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 4/5] build: add defines for compatibility\n\twith make build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While meson has standardized the names and macros used for the libraries\nand drivers in DPDK, the old macros used from the make system were not\npreviously announced as deprecated. Therefore to ensure compatibility of\napps being rebuilt, we add these defines back in when appropriate.\n\nFixes: 5b9656b157d3 (\"lib: build with meson\")\nFixes: 9314afb68a53 (\"drivers: add infrastructure for meson build\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 3 +-\n config/rte_compatibility_defines.h | 129 +++++++++++++++++++++++++++\n config/rte_config.h | 1 +\n doc/guides/rel_notes/deprecation.rst | 9 ++\n 4 files changed, 141 insertions(+), 1 deletion(-)\n create mode 100644 config/rte_compatibility_defines.h", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 6996e5cbea..ef74cebaaa 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -245,7 +245,8 @@ dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', ','.join(compile_time_cpuflags))\n # set the install path for the drivers\n dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)\n \n-install_headers('rte_config.h', subdir: get_option('include_subdir_arch'))\n+install_headers(['rte_config.h', 'rte_compatibility_defines.h'],\n+\t\tsubdir: get_option('include_subdir_arch'))\n \n # enable VFIO only if it is linux OS\n dpdk_conf.set('RTE_EAL_VFIO', is_linux)\ndiff --git a/config/rte_compatibility_defines.h b/config/rte_compatibility_defines.h\nnew file mode 100644\nindex 0000000000..47600052b6\n--- /dev/null\n+++ b/config/rte_compatibility_defines.h\n@@ -0,0 +1,129 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2017 Intel Corporation\n+ */\n+\n+#ifndef _RTE_CONFIG_H_\n+#error \"This file should only be included via rte_config.h\"\n+#endif\n+\n+/*\n+ * NOTE: these defines are for compatibility only and will be removed in a\n+ * future DPDK release.\n+ */\n+\n+#ifdef RTE_LIBRTE_BITRATESTATS\n+#define RTE_LIBRTE_BITRATE\n+#endif\n+\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n+#define RTE_LIBRTE_LATENCY_STATS\n+#endif\n+\n+#ifdef RTE_LIBRTE_DPAAX_COMMON\n+#define RTE_LIBRTE_COMMON_DPAAX\n+#endif\n+\n+#ifdef RTE_LIBRTE_VMBUS_BUS\n+#define RTE_LIBRTE_VMBUS\n+#endif\n+\n+#ifdef RTE_LIBRTE_BUCKET_MEMPOOL\n+#define RTE_DRIVER_MEMPOOL_BUCKET\n+#endif\n+\n+#ifdef RTE_LIBRTE_RING_MEMPOOL\n+#define RTE_DRIVER_MEMPOOL_RING\n+#endif\n+\n+#ifdef RTE_LIBRTE_STACK_MEMPOOL\n+#define RTE_DRIVER_MEMPOOL_STACK\n+#endif\n+\n+#ifdef RTE_LIBRTE_AF_PACKET_PMD\n+#define RTE_LIBRTE_PMD_AF_PACKET\n+#endif\n+\n+#ifdef RTE_LIBRTE_AF_XDP_PMD\n+#define RTE_LIBRTE_PMD_AF_XDP\n+#endif\n+\n+#ifdef RTE_LIBRTE_BOND_PMD\n+#define RTE_LIBRTE_PMD_BOND\n+#endif\n+\n+#ifdef RTE_LIBRTE_E1000_PMD\n+#define RTE_LIBRTE_EM_PMD\n+#endif\n+\n+#ifdef RTE_LIBRTE_E1000_PMD\n+#define RTE_LIBRTE_IGB_PMD\n+#endif\n+\n+#ifdef RTE_LIBRTE_FAILSAFE_PMD\n+#define RTE_LIBRTE_PMD_FAILSAFE\n+#endif\n+\n+#ifdef RTE_LIBRTE_KNI_PMD\n+#define RTE_LIBRTE_PMD_KNI\n+#endif\n+\n+#ifdef RTE_LIBRTE_LIQUIDIO_PMD\n+#define RTE_LIBRTE_LIO_PMD\n+#endif\n+\n+#ifdef RTE_LIBRTE_MEMIF_PMD\n+#define RTE_LIBRTE_PMD_MEMIF\n+#endif\n+\n+#ifdef RTE_LIBRTE_NULL_PMD\n+#define RTE_LIBRTE_PMD_NULL\n+#endif\n+\n+#ifdef RTE_LIBRTE_PCAP_PMD\n+#define RTE_LIBRTE_PMD_PCAP\n+#endif\n+\n+#ifdef RTE_LIBRTE_RING_PMD\n+#define RTE_LIBRTE_PMD_RING\n+#endif\n+\n+#ifdef RTE_LIBRTE_SFC_PMD\n+#define RTE_LIBRTE_SFC_EFX_PMD\n+#endif\n+\n+#ifdef RTE_LIBRTE_SOFTNIC_PMD\n+#define RTE_LIBRTE_PMD_SOFTNIC\n+#endif\n+\n+#ifdef RTE_LIBRTE_SZEDATA2_PMD\n+#define RTE_LIBRTE_PMD_SZEDATA2\n+#endif\n+\n+#ifdef RTE_LIBRTE_TAP_PMD\n+#define RTE_LIBRTE_PMD_TAP\n+#endif\n+\n+#ifdef RTE_LIBRTE_THUNDERX_PMD\n+#define RTE_LIBRTE_THUNDERX_NICVF_PMD\n+#endif\n+\n+#ifdef RTE_LIBRTE_VHOST_PMD\n+#define RTE_LIBRTE_PMD_VHOST\n+#endif\n+\n+#ifdef RTE_LIBRTE_PMD_ARMV8\n+#define RTE_LIBRTE_PMD_ARMV8_CRYPTO\n+#endif\n+\n+#ifdef RTE_LIBRTE_PMD_MVSAM\n+#define RTE_LIBRTE_PMD_MVSAM_CRYPTO\n+#endif\n+\n+#ifdef RTE_LIBRTE_PMD_OCTEONTX_COMPRESS\n+#define RTE_LIBRTE_PMD_OCTEONTX_ZIPVF\n+#endif\n+\n+#ifdef RTE_LIBRTE_PMD_OCTEONTX_EVENTDEV\n+#define RTE_LIBRTE_PMD_OCTEONTX_SSOVF\n+#endif\n+\ndiff --git a/config/rte_config.h b/config/rte_config.h\nindex 0bae630fd9..cacc1837cf 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -13,6 +13,7 @@\n #define _RTE_CONFIG_H_\n \n #include <rte_build_config.h>\n+#include <rte_compatibility_defines.h>\n \n /* legacy defines */\n #ifdef RTE_EXEC_ENV_LINUX\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 5b5a52fa65..fe1b988bb8 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -19,6 +19,15 @@ Deprecation Notices\n are present in this release, but those ending in ``_PMD`` will be removed\n in a future release, and should not be used.\n \n+* build: A number of macros, which defined what DPDK components were being\n+ built, are deprecated due to them not conforming to the standard naming\n+ scheme for the relevant library template or driver class template. These\n+ deprecated macros can be found in the file\n+ ``config/rte_compatibility_defines.h``, listed in the format ``#ifdef\n+ <NEW_DEFINE> \\ #define <OLD_DEFINE> \\ #endif``. When updating code,\n+ ``OLD_DEFINE`` should be replaced with the relevant ``NEW_DEFINE`` from\n+ that file.\n+\n * meson: The minimum supported version of meson for configuring and building\n DPDK will be increased to v0.47.1 (from 0.41) from DPDK 19.05 onwards. For\n those users with a version earlier than 0.47.1, an updated copy of meson\n", "prefixes": [ "RFC", "4/5" ] }