Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77678/?format=api
{ "id": 77678, "url": "http://patches.dpdk.org/api/patches/77678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200915062749.21374-6-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200915062749.21374-6-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200915062749.21374-6-feifei.wang2@arm.com", "date": "2020-09-15T06:27:47", "name": "[v5,5/7] test/ring: validate the return value of enq/deq elements", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "84c6beeb0c103dec5168bc77b735cc11b00d1248", "submitter": { "id": 1771, "url": "http://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200915062749.21374-6-feifei.wang2@arm.com/mbox/", "series": [ { "id": 12216, "url": "http://patches.dpdk.org/api/series/12216/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12216", "date": "2020-09-15T06:27:42", "name": "fix wrong passed pointer and add check", "version": 5, "mbox": "http://patches.dpdk.org/series/12216/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77678/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C972DA04C7;\n\tTue, 15 Sep 2020 08:28:50 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BAB7B1C115;\n\tTue, 15 Sep 2020 08:28:15 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id CD1931C115\n for <dev@dpdk.org>; Tue, 15 Sep 2020 08:28:14 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5262A113E;\n Mon, 14 Sep 2020 23:28:14 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.213])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7DBEA3F73B;\n Mon, 14 Sep 2020 23:28:12 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tFeifei Wang <feifei.wang2@arm.com>", "Date": "Tue, 15 Sep 2020 01:27:47 -0500", "Message-Id": "<20200915062749.21374-6-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200915062749.21374-1-feifei.wang2@arm.com>", "References": "<20200729063105.11299-1-feifei.wang2@arm.com>\n <20200915062749.21374-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [PATCH v5 5/7] test/ring: validate the return value of\n\tenq/deq elements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Validate the return value of single element enqueue/dequeue operation in\nthe test.\n\nSuggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n app/test/test_ring.c | 26 ++++++++++++++++++++++----\n 1 file changed, 22 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex c9017793a..da57032c7 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -834,8 +834,13 @@ test_ring_basic_ex(void)\n \t\t\trte_ring_free_count(rp));\n \n \t\tfor (j = 0; j < RING_SIZE - 1; j++) {\n-\t\t\ttest_ring_enqueue(rp, cur_src, esize[i], 1,\n+\t\t\tret = test_ring_enqueue(rp, cur_src, esize[i], 1,\n \t\t\t\tTEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tprintf(\"%s: rte_ring_enqueue fails\\n\",\n+\t\t\t\t\t__func__);\n+\t\t\t\tgoto fail_test;\n+\t\t\t}\n \t\t\tcur_src = test_ring_inc_ptr(cur_src, esize[i], 1);\n \t\t}\n \n@@ -846,8 +851,13 @@ test_ring_basic_ex(void)\n \t\t}\n \n \t\tfor (j = 0; j < RING_SIZE - 1; j++) {\n-\t\t\ttest_ring_dequeue(rp, cur_dst, esize[i], 1,\n+\t\t\tret = test_ring_dequeue(rp, cur_dst, esize[i], 1,\n \t\t\t\tTEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tprintf(\"%s: rte_ring_dequeue fails\\n\",\n+\t\t\t\t\t__func__);\n+\t\t\t\tgoto fail_test;\n+\t\t\t}\n \t\t\tcur_dst = test_ring_inc_ptr(cur_dst, esize[i], 1);\n \t\t}\n \n@@ -1001,10 +1011,18 @@ test_ring_with_exact_size(void)\n \t\t * than the standard ring. (16 vs 15 elements)\n \t\t */\n \t\tfor (j = 0; j < ring_sz - 1; j++) {\n-\t\t\ttest_ring_enqueue(std_r, cur_src, esize[i], 1,\n+\t\t\tret = test_ring_enqueue(std_r, cur_src, esize[i], 1,\n \t\t\t\tTEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);\n-\t\t\ttest_ring_enqueue(exact_sz_r, cur_src, esize[i], 1,\n+\t\t\tif (ret != 0) {\n+\t\t\t\tprintf(\"%s: error, enqueue failed\\n\", __func__);\n+\t\t\t\tgoto test_fail;\n+\t\t\t}\n+\t\t\tret = test_ring_enqueue(exact_sz_r, cur_src, esize[i], 1,\n \t\t\t\tTEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tprintf(\"%s: error, enqueue failed\\n\", __func__);\n+\t\t\t\tgoto test_fail;\n+\t\t\t}\n \t\t\tcur_src = test_ring_inc_ptr(cur_src, esize[i], 1);\n \t\t}\n \t\tret = test_ring_enqueue(std_r, cur_src, esize[i], 1,\n", "prefixes": [ "v5", "5/7" ] }