Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77627,
    "url": "http://patches.dpdk.org/api/patches/77627/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200914143350.18650-6-feifei.wang2@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200914143350.18650-6-feifei.wang2@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200914143350.18650-6-feifei.wang2@arm.com",
    "date": "2020-09-14T14:33:48",
    "name": "[v4,5/7] test/ring: fix wrong size used in memcmp",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d0cf63604c3da9a34ebfe386d35eaf7f8126aa36",
    "submitter": {
        "id": 1771,
        "url": "http://patches.dpdk.org/api/people/1771/?format=api",
        "name": "Feifei Wang",
        "email": "feifei.wang2@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200914143350.18650-6-feifei.wang2@arm.com/mbox/",
    "series": [
        {
            "id": 12200,
            "url": "http://patches.dpdk.org/api/series/12200/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12200",
            "date": "2020-09-14T14:33:43",
            "name": "fix wrong passed pointer and add check",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/12200/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77627/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77627/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54F88A04C7;\n\tMon, 14 Sep 2020 16:34:54 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BBC1B1C126;\n\tMon, 14 Sep 2020 16:34:26 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 206741C124;\n Mon, 14 Sep 2020 16:34:25 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A31D106F;\n Mon, 14 Sep 2020 07:34:24 -0700 (PDT)",
            "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.213])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0BC6E3F718;\n Mon, 14 Sep 2020 07:34:21 -0700 (PDT)"
        ],
        "From": "Feifei Wang <feifei.wang2@arm.com>",
        "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>, Gavin Hu <gavin.hu@arm.com>",
        "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n stable@dpdk.org",
        "Date": "Mon, 14 Sep 2020 09:33:48 -0500",
        "Message-Id": "<20200914143350.18650-6-feifei.wang2@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200914143350.18650-1-feifei.wang2@arm.com>",
        "References": "<20200729063105.11299-1-feifei.wang2@arm.com>\n <20200914143350.18650-1-feifei.wang2@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v4 5/7] test/ring: fix wrong size used in memcmp",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When using memcmp function to check data, the third param should be the\nsize of all elements, rather than the number of the elements.\n\nFixes: a9fe152363e2 (\"test/ring: add custom element size functional tests\")\nCc: honnappa.nagarahalli@arm.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n app/test/test_ring.c | 49 +++++++++++++++++++++++++++-----------------\n 1 file changed, 30 insertions(+), 19 deletions(-)",
    "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex 811adc523..06498c337 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -444,7 +444,12 @@ test_ring_burst_bulk_tests1(unsigned int test_idx)\n \t\t\tTEST_RING_VERIFY(rte_ring_empty(r));\n \n \t\t\t/* check data */\n-\t\t\tTEST_RING_VERIFY(memcmp(src, dst, rsz) == 0);\n+\t\t\tif (esize[i] == -1) {\n+\t\t\t\tTEST_RING_VERIFY(memcmp(src, dst,\n+\t\t\t\t\trsz * sizeof(void *)) == 0);\n+\t\t\t} else\n+\t\t\t\tTEST_RING_VERIFY(memcmp(src, dst,\n+\t\t\t\t\trsz * esize[i]) == 0);\n \t\t}\n \n \t\t/* Free memory before test completed */\n@@ -538,9 +543,11 @@ test_ring_burst_bulk_tests2(unsigned int test_idx)\n \t\tcur_dst = test_ring_inc_ptr(cur_dst, esize[i], MAX_BULK);\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {\n+\t\t\trte_hexdump(stdout, \"src\", src,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto fail;\n \t\t}\n@@ -614,9 +621,11 @@ test_ring_burst_bulk_tests3(unsigned int test_idx)\n \t\t}\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {\n+\t\t\trte_hexdump(stdout, \"src\", src,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto fail;\n \t\t}\n@@ -747,9 +756,11 @@ test_ring_burst_bulk_tests4(unsigned int test_idx)\n \t\t\tgoto fail;\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {\n+\t\t\trte_hexdump(stdout, \"src\", src,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst,\n+\t\t\t\t\tRTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto fail;\n \t\t}\n@@ -857,9 +868,9 @@ test_ring_basic_ex(void)\n \t\t}\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_src - src)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_src, src))) {\n+\t\t\trte_hexdump(stdout, \"src\", src, RTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst, RTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto fail_test;\n \t\t}\n@@ -909,9 +920,9 @@ test_ring_basic_ex(void)\n \t\tcur_dst = test_ring_inc_ptr(cur_dst, esize[i], 2);\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {\n+\t\t\trte_hexdump(stdout, \"src\", src, RTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst, RTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto fail_test;\n \t\t}\n@@ -1047,9 +1058,9 @@ test_ring_with_exact_size(void)\n \t\t}\n \n \t\t/* check data */\n-\t\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n+\t\tif (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {\n+\t\t\trte_hexdump(stdout, \"src\", src, RTE_PTR_DIFF(cur_src, src));\n+\t\t\trte_hexdump(stdout, \"dst\", dst, RTE_PTR_DIFF(cur_dst, dst));\n \t\t\tprintf(\"data after dequeue is not the same\\n\");\n \t\t\tgoto test_fail;\n \t\t}\n",
    "prefixes": [
        "v4",
        "5/7"
    ]
}