Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77589/?format=api
{ "id": 77589, "url": "http://patches.dpdk.org/api/patches/77589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200914082350.13279-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200914082350.13279-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200914082350.13279-2-david.marchand@redhat.com", "date": "2020-09-14T08:23:45", "name": "[v2,1/6] ethdev: remove unused kernel driver field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6724710489043940287ce585541ac6fa78224c04", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200914082350.13279-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 12178, "url": "http://patches.dpdk.org/api/series/12178/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12178", "date": "2020-09-14T08:23:44", "name": "20.11 announced cleanups", "version": 2, "mbox": "http://patches.dpdk.org/series/12178/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77589/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77589/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2ED94A04C9;\n\tMon, 14 Sep 2020 10:24:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BD1E31C0D9;\n\tMon, 14 Sep 2020 10:24:05 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 28F5D1C0D8\n for <dev@dpdk.org>; Mon, 14 Sep 2020 10:24:04 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-100-imcSxQj-PPubua2WFZ4_Gw-1; Mon, 14 Sep 2020 04:24:01 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B383818BFED0;\n Mon, 14 Sep 2020 08:23:59 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.82])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D9D3D1A268;\n Mon, 14 Sep 2020 08:23:54 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1600071843;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=2Ach6iSvxuOhER5LDmuFn1zC44Y0WfwkpK7TXWhMC6s=;\n b=VNS+RP2zKbSErop8JE/1J4W2CtsAozZOuy5fhyJs8nozeQhvZM/BVGvgBnbPSz2BbYEaKi\n U5nylugoO96Bg3UFSA1E+z0KDprHalxy5aXgCPTcsvCr/skH5CbP7YTJGu0C53fzxJYAZz\n fxc8e/h4p0cV5bTrgmLBTYv79mKc7yw=", "X-MC-Unique": "imcSxQj-PPubua2WFZ4_Gw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>, Zyta Szpak <zr@semihalf.com>,\n Liron Himi <lironh@marvell.com>, Harman Kalra <hkalra@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Mon, 14 Sep 2020 10:23:45 +0200", "Message-Id": "<20200914082350.13279-2-david.marchand@redhat.com>", "In-Reply-To": "<20200914082350.13279-1-david.marchand@redhat.com>", "References": "<20200914081727.12215-1-david.marchand@redhat.com>\n <20200914082350.13279-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0.003", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/6] ethdev: remove unused kernel driver field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This field was not generic as it was filled with PCI kernel drivers only.\nIt has no known in-tree user (and I could not find opensource projects\nusing it).\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n drivers/net/mvneta/mvneta_ethdev.c | 1 -\n drivers/net/mvpp2/mrvl_ethdev.c | 1 -\n drivers/net/octeontx/octeontx_ethdev.c | 1 -\n drivers/net/ring/rte_eth_ring.c | 1 -\n drivers/net/softnic/rte_eth_softnic.c | 1 -\n lib/librte_ethdev/rte_ethdev_core.h | 1 -\n lib/librte_ethdev/rte_ethdev_pci.h | 1 -\n lib/librte_ethdev/rte_ethdev_vdev.h | 1 -\n 10 files changed, 3 insertions(+), 11 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 64d588d7e0..f13248a0fe 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -127,9 +127,6 @@ Deprecation Notices\n * pci: The ``rte_kernel_driver`` enum defined in rte_dev.h will be made private\n to the PCI subsystem as it is used only by the PCI bus driver and PCI\n drivers.\n- The associated field ``kdrv`` in the ethdev ``rte_eth_dev_data`` structure\n- will be removed as it gave no useful abstracted information to the\n- applications and had no user (neither internal nor external).\n \n * mbuf: Some fields will be converted to dynamic API in DPDK 20.11\n in order to reserve more space for the dynamic fields, as explained in\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 5d5be0065a..442b201678 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -87,6 +87,9 @@ API Changes\n * eal: The ``rte_logs`` struct and global symbol was made private\n and is no longer part of the API.\n \n+* ethdev: Removed the ``kdrv`` field in the ethdev ``rte_eth_dev_data``\n+ structure as it gave no useful abstracted information to the applications.\n+\n * rawdev: Added a structure size parameter to the functions\n ``rte_rawdev_queue_setup()``, ``rte_rawdev_queue_conf_get()``,\n ``rte_rawdev_info_get()`` and ``rte_rawdev_configure()``,\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex 673a8e2b3a..5bf3ebc4bd 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -827,7 +827,6 @@ mvneta_eth_dev_create(struct rte_vdev_device *vdev, const char *name)\n \tmemcpy(eth_dev->data->mac_addrs[0].addr_bytes,\n \t req.ifr_addr.sa_data, RTE_ETHER_ADDR_LEN);\n \n-\teth_dev->data->kdrv = RTE_KDRV_NONE;\n \teth_dev->device = &vdev->device;\n \teth_dev->rx_pkt_burst = mvneta_rx_pkt_burst;\n \tmvneta_set_tx_function(eth_dev);\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 96b27dfd30..f5e77d07bf 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -2856,7 +2856,6 @@ mrvl_eth_dev_create(struct rte_vdev_device *vdev, const char *name)\n \tmemcpy(eth_dev->data->mac_addrs[0].addr_bytes,\n \t req.ifr_addr.sa_data, RTE_ETHER_ADDR_LEN);\n \n-\teth_dev->data->kdrv = RTE_KDRV_NONE;\n \teth_dev->device = &vdev->device;\n \teth_dev->rx_pkt_burst = mrvl_rx_pkt_burst;\n \tmrvl_set_tx_function(eth_dev);\ndiff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c\nindex 76c69294d0..653ab9b458 100644\n--- a/drivers/net/octeontx/octeontx_ethdev.c\n+++ b/drivers/net/octeontx/octeontx_ethdev.c\n@@ -1363,7 +1363,6 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,\n \n \teth_dev->device = &dev->device;\n \teth_dev->intr_handle = NULL;\n-\teth_dev->data->kdrv = RTE_KDRV_NONE;\n \teth_dev->data->numa_node = dev->device.numa_node;\n \n \tdata->port_id = eth_dev->data->port_id;\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 733c898259..40fe1ca4ba 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -326,7 +326,6 @@ do_eth_dev_ring_create(const char *name,\n \tdata->all_multicast = 1;\n \n \teth_dev->dev_ops = &ops;\n-\tdata->kdrv = RTE_KDRV_NONE;\n \tdata->numa_node = numa_node;\n \n \t/* finally assign rx and tx ops */\ndiff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex 866d17a93c..e453fd1486 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -391,7 +391,6 @@ pmd_ethdev_register(struct rte_vdev_device *vdev,\n \tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n \tdev->data->mac_addrs = ð_addr;\n \tdev->data->promiscuous = 1;\n-\tdev->data->kdrv = RTE_KDRV_NONE;\n \tdev->data->numa_node = params->cpu_id;\n \n \trte_eth_dev_probing_finish(dev);\ndiff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h\nindex 32407dd418..78c7902897 100644\n--- a/lib/librte_ethdev/rte_ethdev_core.h\n+++ b/lib/librte_ethdev/rte_ethdev_core.h\n@@ -866,7 +866,6 @@ struct rte_eth_dev_data {\n \tuint8_t tx_queue_state[RTE_MAX_QUEUES_PER_PORT];\n \t\t/**< Queues state: HAIRPIN(2) / STARTED(1) / STOPPED(0). */\n \tuint32_t dev_flags; /**< Capabilities. */\n-\tenum rte_kernel_driver kdrv; /**< Kernel driver passthrough. */\n \tint numa_node; /**< NUMA node connection. */\n \tstruct rte_vlan_filter_conf vlan_filter_conf;\n \t\t\t/**< VLAN filter configuration. */\ndiff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h\nindex a999602fdd..6ac6ea41f5 100644\n--- a/lib/librte_ethdev/rte_ethdev_pci.h\n+++ b/lib/librte_ethdev/rte_ethdev_pci.h\n@@ -67,7 +67,6 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,\n \t\tif (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_RMV)\n \t\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV;\n \n-\t\teth_dev->data->kdrv = pci_dev->kdrv;\n \t\teth_dev->data->numa_node = pci_dev->device.numa_node;\n \t}\n }\ndiff --git a/lib/librte_ethdev/rte_ethdev_vdev.h b/lib/librte_ethdev/rte_ethdev_vdev.h\nindex b3ef12398e..64fa689ed3 100644\n--- a/lib/librte_ethdev/rte_ethdev_vdev.h\n+++ b/lib/librte_ethdev/rte_ethdev_vdev.h\n@@ -74,7 +74,6 @@ rte_eth_vdev_allocate(struct rte_vdev_device *dev, size_t private_data_size)\n \teth_dev->device = &dev->device;\n \teth_dev->intr_handle = NULL;\n \n-\teth_dev->data->kdrv = RTE_KDRV_NONE;\n \teth_dev->data->numa_node = dev->device.numa_node;\n \treturn eth_dev;\n }\n", "prefixes": [ "v2", "1/6" ] }