Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77586/?format=api
{ "id": 77586, "url": "http://patches.dpdk.org/api/patches/77586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200914081727.12215-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200914081727.12215-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200914081727.12215-5-david.marchand@redhat.com", "date": "2020-09-14T08:17:26", "name": "[4/5] eal: hide internal device event structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c73cec96f8c97784f6efd710999cb386c78b9112", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200914081727.12215-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 12177, "url": "http://patches.dpdk.org/api/series/12177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12177", "date": "2020-09-14T08:17:22", "name": "20.11 announced cleanups", "version": 1, "mbox": "http://patches.dpdk.org/series/12177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77586/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9E999A04C9;\n\tMon, 14 Sep 2020 10:18:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B0F4C1C0D7;\n\tMon, 14 Sep 2020 10:18:15 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 5BB491C0D7\n for <dev@dpdk.org>; Mon, 14 Sep 2020 10:18:14 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-408-ycjEYEiUO5m4EARdH9sZBg-1; Mon, 14 Sep 2020 04:18:10 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9C021007B00;\n Mon, 14 Sep 2020 08:18:08 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.82])\n by smtp.corp.redhat.com (Postfix) with ESMTP id DD1BE75138;\n Mon, 14 Sep 2020 08:18:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1600071493;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QB43mvOIVZ4dqvl75WQZrX68LpBwqrwAzJXfX4CoVwM=;\n b=ILZTi8l3uRKXsLB6pWG3+Kr6LLEYdMdOK98TSSdnqObDmQl89+xnQ6JdOvaWLTIhZwU/DR\n HaSLmM58hodkqg6cifv4gQqKgR73WlkH9E/f8cZwzQZcbAoGAG78UXjbEHVV+dWRhRKqb6\n a3OJD2aOBBILLU6ID43mvk+wDmh+1NU=", "X-MC-Unique": "ycjEYEiUO5m4EARdH9sZBg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Jianfeng Tan <jianfeng.tan@intel.com>, Jeff Guo <jia.guo@intel.com>", "Date": "Mon, 14 Sep 2020 10:17:26 +0200", "Message-Id": "<20200914081727.12215-5-david.marchand@redhat.com>", "In-Reply-To": "<20200914081727.12215-1-david.marchand@redhat.com>", "References": "<20200914081727.12215-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0.002", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/5] eal: hide internal device event structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This structure is not used in the public API.\n\nFixes: a753e53d517b (\"eal: add device event monitor framework\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n lib/librte_eal/include/rte_dev.h | 6 ------\n lib/librte_eal/linux/eal_dev.c | 6 ++++++\n 4 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 2c7ae1f51e..3bd3abd7f8 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -70,9 +70,6 @@ Deprecation Notices\n * eal: The function ``rte_eal_remote_launch`` will return new error codes\n after read or write error on the pipe, instead of calling ``rte_panic``.\n \n-* eal: The ``rte_dev_event`` structure will be made private to the EAL as no\n- public API makes use of it.\n-\n * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does\n not allow for writing optimized code for all the CPU architectures supported\n in DPDK. DPDK will adopt C11 atomic operations semantics and provide wrappers\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 0f6a557501..8397046988 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -87,6 +87,9 @@ API Changes\n * eal: The ``rte_logs`` struct and global symbol was made private\n and is no longer part of the API.\n \n+* eal: Made the ``rte_dev_event`` structure private to the EAL as no public API\n+ used it.\n+\n * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and\n replaced with a private enum in the PCI subsystem.\n \ndiff --git a/lib/librte_eal/include/rte_dev.h b/lib/librte_eal/include/rte_dev.h\nindex 53c8bc6fab..81905b3ae3 100644\n--- a/lib/librte_eal/include/rte_dev.h\n+++ b/lib/librte_eal/include/rte_dev.h\n@@ -33,12 +33,6 @@ enum rte_dev_event_type {\n \tRTE_DEV_EVENT_MAX\t/**< max value of this enum */\n };\n \n-struct rte_dev_event {\n-\tenum rte_dev_event_type type;\t/**< device event type */\n-\tint subsystem;\t\t\t/**< subsystem id */\n-\tchar *devname;\t\t\t/**< device name */\n-};\n-\n typedef void (*rte_dev_event_cb_fn)(const char *device_name,\n \t\t\t\t\tenum rte_dev_event_type event,\n \t\t\t\t\tvoid *cb_arg);\ndiff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c\nindex 83c9cd6607..c8dd77c049 100644\n--- a/lib/librte_eal/linux/eal_dev.c\n+++ b/lib/librte_eal/linux/eal_dev.c\n@@ -133,6 +133,12 @@ dev_uev_socket_fd_create(void)\n \treturn ret;\n }\n \n+struct rte_dev_event {\n+\tenum rte_dev_event_type type;\t/**< device event type */\n+\tint subsystem;\t\t\t/**< subsystem id */\n+\tchar *devname;\t\t\t/**< device name */\n+};\n+\n static int\n dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)\n {\n", "prefixes": [ "4/5" ] }