Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77567/?format=api
{ "id": 77567, "url": "http://patches.dpdk.org/api/patches/77567/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-19-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-19-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-19-thomas@monjalon.net", "date": "2020-09-13T22:07:09", "name": "[18/20] drivers/net: remove redundant MAC addresses freeing", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "cdfc1b4417a3b1dd651fa0d546577375b071b6cc", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-19-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77567/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7C5CA04C9;\n\tMon, 14 Sep 2020 00:09:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7790F1C0CE;\n\tMon, 14 Sep 2020 00:09:04 +0200 (CEST)", "from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com\n [64.147.123.27]) by dpdk.org (Postfix) with ESMTP id 585921C0AC\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:09:02 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailnew.west.internal (Postfix) with ESMTP id 8D80D5E2;\n Sun, 13 Sep 2020 18:09:00 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:09:01 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id B39BD3064674;\n Sun, 13 Sep 2020 18:08:58 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=YINKezvtHFDfQ\n nkRA5+oczbrKUpiy938J0QTZR6JuEQ=; b=wuyHxJA60Vg96enZdDphKHWcccEez\n VK3seuRYshb9p+dXVcZrXygp3ErNPb67bXldgZ0z0DR1etCihBRSq+h6D2th8NRx\n hQndkIsUQWIRoO7rdizsa5+DmvO/4jnWp3yEpkQ2rBpoj/FrUmKfijyiu8j5h+Le\n wX8WaOLoNt0xV0BF9a4kQyWUV+jJGoQpEvU/QKXlv94MJzYGMbPHJqB07vydEGy6\n XlykbOQHlcvX04Wl7BvWebVP6UsVh4oqoPSuMLlEKz3cOKAfXQ769uqyVNw33DBd\n UUHyeIE0awEZ3gDwlx07PKsZCeC6oMV+ZB50kismvYo73JSlLymmoVDRw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=YINKezvtHFDfQnkRA5+oczbrKUpiy938J0QTZR6JuEQ=; b=QspRuZGN\n f+XefH89LWNPWC9ymYn/fYg5orzvX5j8UX0u+spE6lmdMPsQbu5EmRhVjuR0u121\n vtdkzHUDqdLaOp18+7s2ecPjCu9sw4qTnjxLg5NEt25OLCzuisjSSClDOHe2wfH0\n meEKSunrRYTgymDPk52o0gqUCo6udvBz6dXQ2Z5/Q/RtKgw/m2GzSnolaPs9Ba92\n hCLH+aN0yjrZ6vNQPvO+G5xfd3f0sgTferp9Cm9/1ErPSFwdDVcCkY7Qhk6xBY1i\n yVjKgdp1UHFFpS8rGH19Csi6dl08w5xR//+g5ObTbq/c2n6zRvZ8ljrjehigKaT6\n 3L6koHf3IytOLQ==" ], "X-ME-Sender": "<xms:e5heX3ENrZZrXzJZo98mQ6q-DjUJv5elFYfu1Pa7tnsvhfUbAETXsA>\n <xme:e5heX0Vb5Evltt1wYU_yov_BLd-0oC_DtfWOZz7skcQhEJhxtGYV4Yns4UFm22D79\n SrpsfcciEwgwiXZFg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedujeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:fJheX5IyN2sqmodl6OLofpxT9FfOpX8oZgHQVpW0l5d2BNp6KWm7Tg>\n <xmx:fJheX1Ega73oXA9v65Ry2il3tx7Z4IRk8ucif2WOFVQxBx4eEXtAAg>\n <xmx:fJheX9VMlSptx9nEHNuLqQaMPtNJyfTsyWxg8CHvoZfcMdWDnDhJIg>\n <xmx:fJheX1T3PBByeBMGCMngZc3eFgBM-WFdt6s0zfQZ1ZyG6nNgAD5guOvTsBA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Martin Spinler <spinler@cesnet.cz>", "Date": "Mon, 14 Sep 2020 00:07:09 +0200", "Message-Id": "<20200913220711.3768597-19-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 18/20] drivers/net: remove redundant MAC\n\taddresses freeing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The MAC addresses array is already freed by rte_eth_dev_release_port().\nThe redundant freeing can be removed from the PMD port closing functions.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/ark/ark_ethdev.c | 3 ---\n drivers/net/hinic/hinic_pmd_ethdev.c | 3 ---\n drivers/net/ice/ice_ethdev.c | 3 ---\n drivers/net/nfb/nfb_ethdev.c | 3 ---\n drivers/net/szedata2/rte_eth_szedata2.c | 3 ---\n 5 files changed, 15 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex 8012af75ee..641a694717 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -707,9 +707,6 @@ eth_ark_dev_close(struct rte_eth_dev *dev)\n \t\tdev->data->rx_queues[i] = 0;\n \t}\n \n-\trte_free(dev->data->mac_addrs);\n-\tdev->data->mac_addrs = 0;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 623534fda4..460093bf95 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -3225,9 +3225,6 @@ static int hinic_dev_uninit(struct rte_eth_dev *dev)\n \n \trte_free(nic_dev->mc_list);\n \n-\trte_free(dev->data->mac_addrs);\n-\tdev->data->mac_addrs = NULL;\n-\n \treturn HINIC_OK;\n }\n \ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex f0cb05cbc9..1a7896f0da 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2423,9 +2423,6 @@ ice_dev_close(struct rte_eth_dev *dev)\n \tdev->rx_pkt_burst = NULL;\n \tdev->tx_pkt_burst = NULL;\n \n-\trte_free(dev->data->mac_addrs);\n-\tdev->data->mac_addrs = NULL;\n-\n \t/* disable uio intr before callback unregister */\n \trte_intr_disable(intr_handle);\n \ndiff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c\nindex d937ac6922..6fe7500475 100644\n--- a/drivers/net/nfb/nfb_ethdev.c\n+++ b/drivers/net/nfb/nfb_ethdev.c\n@@ -233,9 +233,6 @@ nfb_eth_dev_close(struct rte_eth_dev *dev)\n \t}\n \tdev->data->nb_tx_queues = 0;\n \n-\trte_free(dev->data->mac_addrs);\n-\tdev->data->mac_addrs = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c\nindex 5f589dfa4c..9ae653e1bd 100644\n--- a/drivers/net/szedata2/rte_eth_szedata2.c\n+++ b/drivers/net/szedata2/rte_eth_szedata2.c\n@@ -1178,9 +1178,6 @@ eth_dev_close(struct rte_eth_dev *dev)\n \t}\n \tdev->data->nb_tx_queues = 0;\n \n-\trte_free(dev->data->mac_addrs);\n-\tdev->data->mac_addrs = NULL;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "18/20" ] }