Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77561/?format=api
{ "id": 77561, "url": "http://patches.dpdk.org/api/patches/77561/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-11-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-11-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-11-thomas@monjalon.net", "date": "2020-09-13T22:07:01", "name": "[10/20] net/null: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2558a2bc7a0d3e9b48c1a3a0a306a2c109cda46c", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-11-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77561/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77561/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79AB9A04C9;\n\tMon, 14 Sep 2020 00:08:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4EF21C116;\n\tMon, 14 Sep 2020 00:08:09 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id AB5BB1C11D\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:08:07 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 9D6185D2;\n Sun, 13 Sep 2020 18:08:06 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:07 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 6940E306467D;\n Sun, 13 Sep 2020 18:08:05 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=ngOvjHWl0cH2V\n l3dYbPTd3FqULeOyMbziGqJ6T5/fww=; b=JI4/GVkjkI6RmHJ2P4GhH9YJ3zH2/\n u3VPhpnnXL5y/+Jx257O+adJVCX+x8InQjEwzHpsz6zQm/4Xv7cWb9JTYQjAscn6\n pRrYtQUmS56YiZGXhr1rFMOD56qcJ5d+K093MGLg6H7ChSGgbjbhu9VmarsXMMk0\n HLd/HG14AcsTamKaAzuRrMNjuGiuUYHLlj7hq+YeTtwQatPRfQ7haS0YqRSXGVGN\n 2OHZeh60I8ofkCaZsrJx+3ZSXyjwELRsWSRaIBFghLV/lQCXmJiQm51gS4S4Ap9P\n RJ+uNdoklc9dWRuFfdv4/JBz/bMAjkIacMAyvaGVHemhmL2oz4a1G0shA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=ngOvjHWl0cH2Vl3dYbPTd3FqULeOyMbziGqJ6T5/fww=; b=OQpneZp3\n QIuQeerBcFQRqUv5HiWUfZIAzgWVrTaaPwcpmAXpzJNUDod8rGv7fp273D0jFXZi\n C38m1jha6VXWPvynloeGkHRON/WC6QS2+/oFrirOkXA3QN3TVp0CYYlNF5nKFFuj\n u9UXQMD04uQzkxFbdUDF9hZ1sG7s2Heuq8t7kzbKYSmIVLS3E6/ruU/6m+PlrzJE\n 8Vn0HUdCzeMf2hJd+SijIPwZ6dqkH4PH15DO3FiAFXFj4CztDvp+IHP3pCRXW0hN\n hiKH3Ib9vP/VamTfbda5c1ol0XnS18HGSpsynLDtWkgl+exDAIb4JzxBXYPRHDHV\n XdvT22osbaAu1g==" ], "X-ME-Sender": "<xms:RpheX4YEWkEjvhLxCBiKWK6n3qpUYAkSxF8TSLaMDEcBxPp8ZoQPxQ>\n <xme:RpheXzZt4loy79QkMLQSaAVU_v21gnSe4h9wPpTKGNJG8vzNH0p-O8d-XRRXxmdtv\n q_cTdjlvmSHcJOpcg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedutdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:RpheXy9cr5nbyUTtcBRZ8mnuaOuG_f8T6SJiNA78PlhclqhQSJaFBQ>\n <xmx:RpheXyrms_5lHIZ1rxufElZjhPPV1mvhcnDIX2VcuqW9DQ5Q5OiGZw>\n <xmx:RpheXzqAXupXuJJJNuEglUphtXeSsmwd-dfwilMFNL5PP4DeCodSaA>\n <xmx:RpheX62a_zLAzqUD9KPQlnkDHu5zuAMIqFXBVONp6XHVr-MGUOL05Q>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Tetsuya Mukawa <mtetsuyah@gmail.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 14 Sep 2020 00:07:01 +0200", "Message-Id": "<20200913220711.3768597-11-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/20] net/null: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/null/rte_eth_null.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 0ce073fa4b..33997013e4 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -458,7 +458,20 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static int\n+eth_dev_close(struct rte_eth_dev *dev)\n+{\n+\tPMD_LOG(INFO, \"Closing null ethdev on NUMA socket %u\",\n+\t\t\trte_socket_id());\n+\n+\t/* mac_addrs must not be freed alone because part of dev_private */\n+\tdev->data->mac_addrs = NULL;\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops ops = {\n+\t.dev_close = eth_dev_close,\n \t.dev_start = eth_dev_start,\n \t.dev_stop = eth_dev_stop,\n \t.dev_configure = eth_dev_configure,\n@@ -532,6 +545,7 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args)\n \tdata->mac_addrs = &internals->eth_addr;\n \tdata->promiscuous = 1;\n \tdata->all_multicast = 1;\n+\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \teth_dev->dev_ops = &ops;\n \n@@ -701,18 +715,12 @@ rte_pmd_null_remove(struct rte_vdev_device *dev)\n \tif (!dev)\n \t\treturn -EINVAL;\n \n-\tPMD_LOG(INFO, \"Closing null ethdev on numa socket %u\",\n-\t\t\trte_socket_id());\n-\n \t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));\n \tif (eth_dev == NULL)\n-\t\treturn -1;\n-\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\t/* mac_addrs must not be freed alone because part of dev_private */\n-\t\teth_dev->data->mac_addrs = NULL;\n+\t\treturn 0; /* port already released */\n \n+\teth_dev_close(eth_dev);\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn 0;\n", "prefixes": [ "10/20" ] }