Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77556/?format=api
{ "id": 77556, "url": "http://patches.dpdk.org/api/patches/77556/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-6-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-6-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-6-thomas@monjalon.net", "date": "2020-09-13T22:06:56", "name": "[05/20] net/axgbe: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "194ff2a45825f94aca4cd492e6a46781096be1ed", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-6-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77556/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3072AA04C9;\n\tMon, 14 Sep 2020 00:08:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 82AE81C0D5;\n\tMon, 14 Sep 2020 00:07:55 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 663541C0D1\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:07:53 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id 16A255C014E;\n Sun, 13 Sep 2020 18:07:53 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:07:53 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 46D0E306467E;\n Sun, 13 Sep 2020 18:07:52 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=bfhhSVySlPMJf\n EzfQ/I0W7cQbY7t8ZadgGbhmTmmmtw=; b=vX3gsUntIJrMuk++lt1PGWlD/b6h3\n ueXl6sZfLZsAVr6UyY4Dhhcq2zlSAi67zA5OcuzVml03JaX6Z7/Qja744hGFRmCw\n UUxJV3NVLYfnNngoatQInVAvcO6CIhg5kxA2RTlGWgntKb54rVyXFFfS1KxmbpzC\n OtZyFbi+q6dDaYkPwjqYpfnx949lvCCIfOdyc1QyKqPB+P/Lpgwr3FwCXZEns7v7\n h72cWVFM7g8tW8JO1pVLA7vCFIk/wX4+W5m72T+TK6j43feIp0nB3DsqTW/iE55t\n duwP0g1BJGiofFuB4DA/mNtXou+3amQd16cJcPIH3kYbQ6sh/a5sCNp5Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=bfhhSVySlPMJfEzfQ/I0W7cQbY7t8ZadgGbhmTmmmtw=; b=teC6LELg\n vrj3qvmtgPXu8u7ZycUmIMTcZiANr5bEVH9SZNGI7ad1sJbGztmLLxkPvGEaqEJr\n 7fCBiikODaQEdnT1bsGJ/rbxp6EFIi2PoiEOP3zQHx+Cet7i0PQ/hwAZpGsbZ2na\n 6BYfCfPq2kmlLwgEhO8St89k5AFzgYcGI7Q0xkwieDJyTY+bg/4kVIvQ4IvbOkdu\n VDs2M3cfEgkRehPCGydhHAPeSkUvfZcRORzuOpMV6qJwLsdcwpPnCZzbbx5JSHXq\n Ft+u/z0gcJJzuj1fwCitHbkemhqMiZhXcOSVxp4VDp4awTW9yDWWi/Sazxd7Ku/v\n 63g/uyRWS0egWQ==" ], "X-ME-Sender": "<xms:OJheX8JJq9Pofsw5u6v4jZP0MiT52oDs2dXOwg7Cs-11TTAIb0Z5FA>\n <xme:OJheX8LPAIfMiZKkJBx0sqfmTeSokfZVcqudniCxNU_PYrluLfEPXS7tPDXfraVmY\n EOWCvx13LutEcgOAA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:OJheX8sZOfBxlGkRLBAcWyGl6fYY19L5a3uu7ACVzmMPGpH8G4ueNA>\n <xmx:OJheX5bJg6s7HJfVECGyJ550dfU44yapyzjyItdtI2RQ0b5QGpNvig>\n <xmx:OJheXzZdxZQRNb40tYtjTnP4FkNQ9MEfjgZRwwHVhl5W8PScgieF3A>\n <xmx:OZheX6wxNl5l95Qpp5dxEnhObwf-aSv8g4nqzuABZJjL7KjrshfbQA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Somalapuram Amaranath <asomalap@amd.com>", "Date": "Mon, 14 Sep 2020 00:06:56 +0200", "Message-Id": "<20200913220711.3768597-6-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/20] net/axgbe: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\nThe \".dev_close\" callback is also called as part of the \".remove\" one.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 14 +++-----------\n 1 file changed, 3 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex be6f7cbda6..c5e70ea0a1 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -10,7 +10,6 @@\n #include \"axgbe_regs.h\"\n \n static int eth_axgbe_dev_init(struct rte_eth_dev *eth_dev);\n-static int eth_axgbe_dev_uninit(struct rte_eth_dev *eth_dev);\n static int axgbe_dev_configure(struct rte_eth_dev *dev);\n static int axgbe_dev_start(struct rte_eth_dev *dev);\n static void axgbe_dev_stop(struct rte_eth_dev *dev);\n@@ -378,14 +377,6 @@ axgbe_dev_stop(struct rte_eth_dev *dev)\n \trte_bit_relaxed_set32(AXGBE_DOWN, &pdata->dev_state);\n }\n \n-/* Clear all resources like TX/RX queues. */\n-static int\n-axgbe_dev_close(struct rte_eth_dev *dev)\n-{\n-\taxgbe_dev_clear_queues(dev);\n-\treturn 0;\n-}\n-\n static int\n axgbe_dev_promiscuous_enable(struct rte_eth_dev *dev)\n {\n@@ -1632,6 +1623,7 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tint ret;\n \n \teth_dev->dev_ops = &axgbe_eth_dev_ops;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/*\n \t * For secondary processes, we don't initialise any further as primary\n@@ -1794,7 +1786,7 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n }\n \n static int\n-eth_axgbe_dev_uninit(struct rte_eth_dev *eth_dev)\n+axgbe_dev_close(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev;\n \n@@ -1827,7 +1819,7 @@ static int eth_axgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n static int eth_axgbe_pci_remove(struct rte_pci_device *pci_dev)\n {\n-\treturn rte_eth_dev_pci_generic_remove(pci_dev, eth_axgbe_dev_uninit);\n+\treturn rte_eth_dev_pci_generic_remove(pci_dev, axgbe_dev_close);\n }\n \n static struct rte_pci_driver rte_axgbe_pmd = {\n", "prefixes": [ "05/20" ] }