Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77554/?format=api
{ "id": 77554, "url": "http://patches.dpdk.org/api/patches/77554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-4-thomas@monjalon.net", "date": "2020-09-13T22:06:54", "name": "[03/20] net/af_packet: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "99b8eb1632f5a6b2255e3963d9828ff53fdf3d68", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-4-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77554/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/77554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EB6E7A04C9;\n\tMon, 14 Sep 2020 00:07:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CDAF71C0B9;\n\tMon, 14 Sep 2020 00:07:49 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 412E0DE0\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:07:48 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 2977351E;\n Sun, 13 Sep 2020 18:07:47 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:07:47 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id DEFF03064674;\n Sun, 13 Sep 2020 18:07:45 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=H6YS1Gylvj3KG\n 4Az5kECcukKS7qBJATUhtPehzWMZGw=; b=tH24r4pqbD0+P7DpTZR/xDhTe/RRA\n aZd2Ykvjh/JbI0D6hsOltIadKLWOj4Qc3EoylvoR4MuwSjO77ij/KT4OGgbk/h8G\n XG0KiwaV9+faqsQIr1+jEC0L9rFES8fGBY8II0M1y06oNqoVK5R7pV7Llq597hpp\n wXPZvYrt4gOYkPFSIlO6K9t5MDenxbMUIOppGQAjTKc6oMu3++iC0Z3yds6i5e3s\n NJduqkQ+pssFAzQQn//iUe2JIo+wD7vsmnozAutO4V31Thufoka2SvT6X/EcG54f\n Gx3sCGWFZ33nH69YH8Ra8WjVFIrV2Uj+IveK2BN28vmr1IjCyQ1Nlk09w==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=H6YS1Gylvj3KG4Az5kECcukKS7qBJATUhtPehzWMZGw=; b=WY8h16y4\n pgAbQ9coyvSLDkQd7X6hfp/AuCxQkM8gUSCC05onlBAuR82DbnJsEkimNtktgFhh\n Kpe/+po9Jbd4fQsc8Y3P2FDbKDDBmVzY9VzFAIP0AT4+Pxrajy1EKmb/yN6jhLAH\n wPf5NpOKmGrzctP719HIxVq2/NGzVvgA4hUGWyd8PAvJCZJvMHGw2Am/npv8qAjT\n HzCnXdeHeLH2XE3FYuenOqA0PZ+OqPOxU8R63qSozVBqjh4GPpygDF43qznAVZzA\n xy7Bh0+yzONVeQ5el3i0hjGYa/mCFhiKRBfNdVERv9FtKhpUu2c3BrFBV96sdYx0\n 8YXvPiAVmDtzCw==" ], "X-ME-Sender": "<xms:MpheXwqYGbt2IuakMlWy37bnPc5F_CMFs2aeHlTyOZyLdMeGgHVJ4Q>\n <xme:MpheX2rUrMUv1Ne3AeTkv8c7Cl5lVd1x7EIVjWRe-ypVFIun23-dJMOJEwcWBYcU_\n hZ2ldwAgME_JhIxZA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:MpheX1MFhiZ6RNCWshZp3DlAKT4yma74MWMYyVCxJtMd5ON6oAaVsg>\n <xmx:MpheX35CQPeX22LMpxzWRqix9-rffj2_Ga25vmf-nafPu4m5EYZ5dg>\n <xmx:MpheX_5Hhc7gyESQ9_9q6NxzNDnvRnG8h11RgOGqxtHaK9lJoQ6xmA>\n <xmx:MpheX_EWZk2uYG3WZf5PsXI3aD0IQyRCefE-bzfNYYcXk7mNw4R27g>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n \"John W. Linville\" <linville@tuxdriver.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 14 Sep 2020 00:06:54 +0200", "Message-Id": "<20200913220711.3768597-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 03/20] net/af_packet: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 56 ++++++++++++-----------\n 1 file changed, 29 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 7d0ff1cbb3..3ab6f4d388 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -377,8 +377,32 @@ eth_stats_reset(struct rte_eth_dev *dev)\n }\n \n static int\n-eth_dev_close(struct rte_eth_dev *dev __rte_unused)\n+eth_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *internals;\n+\tstruct tpacket_req *req;\n+\tunsigned q;\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n+\tPMD_LOG(INFO, \"Closing AF_PACKET ethdev on NUMA socket %u\",\n+\t\trte_socket_id());\n+\n+\tinternals = dev->data->dev_private;\n+\treq = &internals->req;\n+\tfor (q = 0; q < internals->nb_queues; q++) {\n+\t\tmunmap(internals->rx_queue[q].map,\n+\t\t\t2 * req->tp_block_size * req->tp_block_nr);\n+\t\trte_free(internals->rx_queue[q].rd);\n+\t\trte_free(internals->tx_queue[q].rd);\n+\t}\n+\tfree(internals->if_name);\n+\trte_free(internals->rx_queue);\n+\trte_free(internals->tx_queue);\n+\n+\t/* mac_addrs must not be freed alone because part of dev_private */\n+\tdev->data->mac_addrs = NULL;\n \treturn 0;\n }\n \n@@ -835,6 +859,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,\n \tdata->nb_tx_queues = (uint16_t)nb_queues;\n \tdata->dev_link = pmd_link;\n \tdata->mac_addrs = &(*internals)->eth_addr;\n+\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t(*eth_dev)->dev_ops = &ops;\n \n@@ -1033,13 +1058,7 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)\n static int\n rte_pmd_af_packet_remove(struct rte_vdev_device *dev)\n {\n-\tstruct rte_eth_dev *eth_dev = NULL;\n-\tstruct pmd_internals *internals;\n-\tstruct tpacket_req *req;\n-\tunsigned q;\n-\n-\tPMD_LOG(INFO, \"Closing AF_PACKET ethdev on numa socket %u\",\n-\t\trte_socket_id());\n+\tstruct rte_eth_dev *eth_dev;\n \n \tif (dev == NULL)\n \t\treturn -1;\n@@ -1047,26 +1066,9 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)\n \t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));\n \tif (eth_dev == NULL)\n-\t\treturn -1;\n-\n-\t/* mac_addrs must not be freed alone because part of dev_private */\n-\teth_dev->data->mac_addrs = NULL;\n-\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn rte_eth_dev_release_port(eth_dev);\n-\n-\tinternals = eth_dev->data->dev_private;\n-\treq = &internals->req;\n-\tfor (q = 0; q < internals->nb_queues; q++) {\n-\t\tmunmap(internals->rx_queue[q].map,\n-\t\t\t2 * req->tp_block_size * req->tp_block_nr);\n-\t\trte_free(internals->rx_queue[q].rd);\n-\t\trte_free(internals->tx_queue[q].rd);\n-\t}\n-\tfree(internals->if_name);\n-\trte_free(internals->rx_queue);\n-\trte_free(internals->tx_queue);\n+\t\treturn 0; /* port already released */\n \n+\teth_dev_close(eth_dev);\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn 0;\n", "prefixes": [ "03/20" ] }