Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77553/?format=api
{ "id": 77553, "url": "http://patches.dpdk.org/api/patches/77553/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-2-thomas@monjalon.net", "date": "2020-09-13T22:06:52", "name": "[01/20] ethdev: reset device and interrupt pointers on release", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d691f033608bd8d4c332f503243b066052f985fb", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-2-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77553/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77553/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60356A04C9;\n\tMon, 14 Sep 2020 00:07:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E1C71C012;\n\tMon, 14 Sep 2020 00:07:36 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 3F9A81C012\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:07:34 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id CAB8B5D6;\n Sun, 13 Sep 2020 18:07:32 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:07:33 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id BB2673064688;\n Sun, 13 Sep 2020 18:07:30 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=K4Xnm/jBXKF0/\n w5Uj//drDEKxU3kbryJqjUUaoWApN8=; b=FczgwP5Vp0JxRe38Qqvu41RHFqG2w\n Eq9MkhpNfp/tgu9Nsv96+gc9dOM22g5CUcVyPoAolaYAsCrWWVWB1cE2tfwYEGi3\n AR/9DAh4YvKCROsoAe19RfqNOdvTw01n8SvqXQV0rTQNBXqp8jql5DKhNvu1fyhF\n aMshqOKPNUP1WUgjwHM5OwywzKFyopO8Yzwl9EXa55Oe9ThrzSR0dYynWpUyq8oj\n XuuxhEWgS/fXR5qT6Wi/ViaOot9SoRQusF1bDSlezCDCgCbH1uARuipuTy5eYSEk\n CAWe8TQ71PklnhbAUjcn0EGIFmfffDivxrO56lBCpmEFcMoBgxpRVjXuQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=K4Xnm/jBXKF0/w5Uj//drDEKxU3kbryJqjUUaoWApN8=; b=SKsqDF4p\n UL0IvupXdsTVzCW6WFMLn6QN7mCEPH17dMsUuwk55qyzl+wBA3qQ7OPN5leZn95Z\n ygL4Yg8zw9TObq+Ulcj88YgreBpOGZ0/OPR9JqyLW861Omk0y1nFbQq4Gm2v/Fza\n KYxDcOdKVzBCodIwdFitVhH5DO7tnSXmPFg+IBdZQsAqXXsebRBMI3fpcVnDQPYu\n xHMkyXddFmaHRokpukv9afiESO9vQ3nYANz77eBlLwIHB5yQMKE67hsODa/V3JME\n STyQKoMprc+vh32lbVngPv4kWk4Gi5mEm3nM+3K4AcB7EvmtXgeolWBJFrdXj+DQ\n Apv+HUioOXQOUA==" ], "X-ME-Sender": "<xms:I5heX7XW7gSoWCy8fKLVLiQAbfr4YxvmOFdy86a6dj9gAFgOKGXQSg>\n <xme:I5heXzklattQXWJ99fvR2U7aOf4tpZA8Djiua5maoLesfIj3pG6AomwwdbFNpntUw\n sOhNWVO6n_qOKsEBw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:I5heX3Znj38O6kRHAOOmq25lbHaoFmpJ8K3DuzJX3tr3tS5Dt7AlsQ>\n <xmx:I5heX2V9riCW4-7X1d6kn5AOJaerTlKq-V7WL0kzv5e9sNjQjohKIg>\n <xmx:I5heX1nmUxp0-OMSkGfrBaW5-i9h0ZfZ8p8UaemGQV-hQvxBi4Ws7A>\n <xmx:JJheX7Vve7r04W93nBCggoRUWaSYdntnbEs7oOn9YQOcv2_lL-e-QQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>, Martin Spinler <spinler@cesnet.cz>", "Date": "Mon, 14 Sep 2020 00:06:52 +0200", "Message-Id": "<20200913220711.3768597-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/20] ethdev: reset device and interrupt\n\tpointers on release", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The pointers .device and .intr_handle were already reset by the helper\nrte_eth_dev_pci_generic_remove().\nIt is now made part of rte_eth_dev_release_port().\n\nIt makes rte_eth_dev_pci_release() meaningless,\nso it is replaced with a call to rte_eth_dev_release_port().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/ark/ark_ethdev.c | 2 +-\n drivers/net/octeontx2/otx2_ethdev.c | 2 +-\n drivers/net/szedata2/rte_eth_szedata2.c | 6 +++---\n lib/librte_ethdev/rte_ethdev.c | 2 ++\n lib/librte_ethdev/rte_ethdev_pci.h | 14 ++------------\n 5 files changed, 9 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex b32ccd8677..0321ec1264 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -105,7 +105,7 @@ eth_ark_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n \tret = eth_ark_dev_init(eth_dev);\n \tif (ret)\n-\t\trte_eth_dev_pci_release(eth_dev);\n+\t\trte_eth_dev_release_port(eth_dev);\n \n \treturn ret;\n }\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex 33b72bd4db..7425ee55be 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -2668,7 +2668,7 @@ nix_remove(struct rte_pci_device *pci_dev)\n \t\tif (rc)\n \t\t\treturn rc;\n \n-\t\trte_eth_dev_pci_release(eth_dev);\n+\t\trte_eth_dev_release_port(eth_dev);\n \t}\n \n \t/* Nothing to be done for secondary processes */\ndiff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c\nindex 30c888cd96..a17c53577c 100644\n--- a/drivers/net/szedata2/rte_eth_szedata2.c\n+++ b/drivers/net/szedata2/rte_eth_szedata2.c\n@@ -1802,7 +1802,7 @@ szedata2_eth_dev_release_interval(struct rte_eth_dev **eth_devs,\n \n \tfor (i = from; i < to; i++) {\n \t\trte_szedata2_eth_dev_uninit(eth_devs[i]);\n-\t\trte_eth_dev_pci_release(eth_devs[i]);\n+\t\trte_eth_dev_release_port(eth_devs[i]);\n \t}\n }\n \n@@ -1853,7 +1853,7 @@ static int szedata2_eth_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tif (ret != 0) {\n \t\t\tPMD_INIT_LOG(ERR, \"Failed to init eth_dev for port %u\",\n \t\t\t\t\ti);\n-\t\t\trte_eth_dev_pci_release(eth_devs[i]);\n+\t\t\trte_eth_dev_release_port(eth_devs[i]);\n \t\t\tszedata2_eth_dev_release_interval(eth_devs, 0, i);\n \t\t\trte_free(list_entry);\n \t\t\treturn ret;\n@@ -1922,7 +1922,7 @@ static int szedata2_eth_pci_remove(struct rte_pci_device *pci_dev)\n \t\t\tretval = retval ? retval : ret;\n \t\t}\n \n-\t\trte_eth_dev_pci_release(eth_dev);\n+\t\trte_eth_dev_release_port(eth_dev);\n \t}\n \n \treturn retval;\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 7858ad5f11..3617f39ca0 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -555,6 +555,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n \teth_dev->state = RTE_ETH_DEV_UNUSED;\n+\teth_dev->device = NULL;\n+\teth_dev->intr_handle = NULL;\n \n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\trte_free(eth_dev->data->rx_queues);\ndiff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h\nindex a999602fdd..114da807ff 100644\n--- a/lib/librte_ethdev/rte_ethdev_pci.h\n+++ b/lib/librte_ethdev/rte_ethdev_pci.h\n@@ -134,16 +134,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)\n \treturn eth_dev;\n }\n \n-static inline void\n-rte_eth_dev_pci_release(struct rte_eth_dev *eth_dev)\n-{\n-\teth_dev->device = NULL;\n-\teth_dev->intr_handle = NULL;\n-\n-\t/* free ether device */\n-\trte_eth_dev_release_port(eth_dev);\n-}\n-\n typedef int (*eth_dev_pci_callback_t)(struct rte_eth_dev *eth_dev);\n \n /**\n@@ -165,7 +155,7 @@ rte_eth_dev_pci_generic_probe(struct rte_pci_device *pci_dev,\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev_init, -EINVAL);\n \tret = dev_init(eth_dev);\n \tif (ret)\n-\t\trte_eth_dev_pci_release(eth_dev);\n+\t\trte_eth_dev_release_port(eth_dev);\n \telse\n \t\trte_eth_dev_probing_finish(eth_dev);\n \n@@ -194,7 +184,7 @@ rte_eth_dev_pci_generic_remove(struct rte_pci_device *pci_dev,\n \t\t\treturn ret;\n \t}\n \n-\trte_eth_dev_pci_release(eth_dev);\n+\trte_eth_dev_release_port(eth_dev);\n \treturn 0;\n }\n \n", "prefixes": [ "01/20" ] }