Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77432/?format=api
{ "id": 77432, "url": "http://patches.dpdk.org/api/patches/77432/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911150805.79901-5-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911150805.79901-5-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911150805.79901-5-maxime.coquelin@redhat.com", "date": "2020-09-11T15:08:02", "name": "[4/7] net/virtio: adapt Virtio-user status size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dee41d990586ee0999f18e133d5ed0bf365f66bc", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911150805.79901-5-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12149, "url": "http://patches.dpdk.org/api/series/12149/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12149", "date": "2020-09-11T15:07:58", "name": "virtio-user: introduce vhost-vdpa backend", "version": 1, "mbox": "http://patches.dpdk.org/series/12149/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77432/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77432/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AFD0EA04BB;\n\tFri, 11 Sep 2020 17:09:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D37C1C10C;\n\tFri, 11 Sep 2020 17:08:27 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8A3891C10C\n for <dev@dpdk.org>; Fri, 11 Sep 2020 17:08:25 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-421-tEm9sx08NLG7VvjH2g6HCQ-1; Fri, 11 Sep 2020 11:08:21 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C66A8018AB;\n Fri, 11 Sep 2020 15:08:20 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.16])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CA9BA1A887;\n Fri, 11 Sep 2020 15:08:18 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1599836905;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=42xg75LdvwfB4xp3yjZImXeStmWYsVaahWrv7Sa1M+M=;\n b=NWh5cGak7clIMFMEm6SCGrxDCmxr4yjF4e4d4O/jdYo61jmC67QRNewov6VJZN+jjnKWcJ\n /0Y9OhM6b3RnO84PdIL9oirL4+xFwZ4pZtrx+rPtd8IphjnlbrLqToGM2vdcYXlKIuaGkm\n pMuWz6R12kmA3TKFlgM+bhMLQmpoNtQ=", "X-MC-Unique": "tEm9sx08NLG7VvjH2g6HCQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tpatrick.fu@intel.com,\n\tamorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 11 Sep 2020 17:08:02 +0200", "Message-Id": "<20200911150805.79901-5-maxime.coquelin@redhat.com>", "In-Reply-To": "<20200911150805.79901-1-maxime.coquelin@redhat.com>", "References": "<20200911150805.79901-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0.001", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/7] net/virtio: adapt Virtio-user status size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set proper payload size for set/get status message. The payload\nsize varies according to backend types.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nSigned-off-by: Patrick Fu <patrick.fu@intel.com>\n---\n .../net/virtio/virtio_user/virtio_user_dev.c | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 93274b2a94..753611ef42 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -838,14 +838,18 @@ virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status)\n \tenum virtio_user_backend_type backend_type =\n \t\t\t\tvirtio_user_backend_type(dev->path);\n \n-\t/* Vhost-user only for now */\n-\tif (backend_type != VIRTIO_USER_BACKEND_VHOST_USER)\n+\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n \t\treturn 0;\n \n-\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\tif (backend_type == VIRTIO_USER_BACKEND_VHOST_USER)\n+\t\tret = dev->ops->send_request(dev,\n+\t\t\t\tVHOST_USER_SET_STATUS, &arg);\n+\telse if (backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA)\n+\t\tret = dev->ops->send_request(dev,\n+\t\t\t\tVHOST_USER_SET_STATUS, &status);\n+\telse\n \t\treturn 0;\n \n-\tret = dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg);\n \tif (ret) {\n \t\tPMD_INIT_LOG(ERR, \"VHOST_USER_SET_STATUS failed (%d): %s\", ret,\n \t\t\t strerror(errno));\n@@ -858,7 +862,7 @@ virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status)\n int\n virtio_user_update_status(struct virtio_user_dev *dev)\n {\n-\tuint64_t ret;\n+\tuint8_t ret;\n \tint err;\n \tenum virtio_user_backend_type backend_type =\n \t\t\t\tvirtio_user_backend_type(dev->path);\n@@ -876,11 +880,6 @@ virtio_user_update_status(struct virtio_user_dev *dev)\n \t\t\t strerror(errno));\n \t\treturn -1;\n \t}\n-\tif (ret > UINT8_MAX) {\n-\t\tPMD_INIT_LOG(ERR, \"Invalid VHOST_USER_GET_STATUS \"\n-\t\t\t\t\"response 0x%\" PRIx64 \"\\n\", ret);\n-\t\treturn -1;\n-\t}\n \n \tdev->status = ret;\n \tPMD_INIT_LOG(DEBUG, \"Updated Device Status(0x%08x):\\n\"\n", "prefixes": [ "4/7" ] }