Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77425/?format=api
{ "id": 77425, "url": "http://patches.dpdk.org/api/patches/77425/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-39-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911131954.15999-39-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911131954.15999-39-qi.z.zhang@intel.com", "date": "2020-09-11T13:19:52", "name": "[v2,38/40] net/ice/base: remove unnecessary conditional", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3384dfc880625e240b896eb90e888028a3628385", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-39-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 12148, "url": "http://patches.dpdk.org/api/series/12148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12148", "date": "2020-09-11T13:19:15", "name": "ice base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/12148/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77425/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77425/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2E36CA04B6;\n\tFri, 11 Sep 2020 15:23:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 02FF51C2BB;\n\tFri, 11 Sep 2020 15:17:11 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 100EA1C21F\n for <dev@dpdk.org>; Fri, 11 Sep 2020 15:16:55 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Sep 2020 06:16:55 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2020 06:16:54 -0700" ], "IronPort-SDR": [ "\n k+NTaQ/2iwrGkv4ryvMohbXJ36s62+9tmVclI8OkdEJA4/DhbFnGYpm6BOEpNijY3MVhfIYNhE\n i+NiQY/w+N8A==", "\n ECALfnrgjdhp0OtQkxmwNA5Dw40Iz7p+mRd41OsLESVC5Y98nxbdEa0TNWkK10ZStLV1A08cE8\n ggKdvVT8K4aA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"146482426\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"146482426\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"342296780\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Bruce Allan <bruce.w.allan@intel.com>", "Date": "Fri, 11 Sep 2020 21:19:52 +0800", "Message-Id": "<20200911131954.15999-39-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200911131954.15999-1-qi.z.zhang@intel.com>", "References": "<20200907112826.48493-1-qi.z.zhang@intel.com>\n <20200911131954.15999-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 38/40] net/ice/base: remove unnecessary\n\tconditional", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These two conditional statements are unnecessary because the condition\nis always true based on existing code flow. Remove them to resolve\npotential errors from some static analysis tools.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 1f621ca88..cd3ce8231 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -1089,7 +1089,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t */\n \t\tif (fld == ICE_FLOW_FIELD_IDX_IPV4_TTL)\n \t\t\tsib = ICE_FLOW_FIELD_IDX_IPV4_PROT;\n-\t\telse if (fld == ICE_FLOW_FIELD_IDX_IPV4_PROT)\n+\t\telse\n \t\t\tsib = ICE_FLOW_FIELD_IDX_IPV4_TTL;\n \n \t\t/* If the sibling field is also included, that field's\n@@ -1108,7 +1108,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t */\n \t\tif (fld == ICE_FLOW_FIELD_IDX_IPV6_TTL)\n \t\t\tsib = ICE_FLOW_FIELD_IDX_IPV6_PROT;\n-\t\telse if (fld == ICE_FLOW_FIELD_IDX_IPV6_PROT)\n+\t\telse\n \t\t\tsib = ICE_FLOW_FIELD_IDX_IPV6_TTL;\n \n \t\t/* If the sibling field is also included, that field's\n", "prefixes": [ "v2", "38/40" ] }