Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77387/?format=api
{ "id": 77387, "url": "http://patches.dpdk.org/api/patches/77387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911131954.15999-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911131954.15999-2-qi.z.zhang@intel.com", "date": "2020-09-11T13:19:15", "name": "[v2,01/40] net/ice/base: handle error gracefully in HW table calloc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6c04a5dac5836e8f13513d1e9100558195fc9489", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-2-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 12148, "url": "http://patches.dpdk.org/api/series/12148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12148", "date": "2020-09-11T13:19:15", "name": "ice base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/12148/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77387/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4FD3DA04B7;\n\tFri, 11 Sep 2020 15:16:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8F4A1BF90;\n\tFri, 11 Sep 2020 15:16:02 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id EC7221B75C\n for <dev@dpdk.org>; Fri, 11 Sep 2020 15:16:00 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Sep 2020 06:15:59 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2020 06:15:58 -0700" ], "IronPort-SDR": [ "\n RdDblRgUI7AwJkH37lsx89hbuKPiK5tHLm3mviDxYjTo8TiIhgAc2BKECn+piHy5km4iMVow81\n sYGd32Pj6Knw==", "\n zx5AxOPJX0SZUXEuVkiCEOiEi6QYX0m0UJ5RVJWGSk6wTkFW6D5B4DkhQ2Wtp/Rl7B1/Xg/KY7\n Re3FmQ6c1Fzg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"146482081\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"146482081\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"342296383\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Surabhi Boob <surabhi.boob@intel.com>", "Date": "Fri, 11 Sep 2020 21:19:15 +0800", "Message-Id": "<20200911131954.15999-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200911131954.15999-1-qi.z.zhang@intel.com>", "References": "<20200907112826.48493-1-qi.z.zhang@intel.com>\n <20200911131954.15999-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 01/40] net/ice/base: handle error gracefully\n\tin HW table calloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the ice_init_hw_tbls API, if the ice_calloc for es->written\nfails, catch that error and bail out gracefully, instead of\ncontinuing with a NULL pointer.\n\nSigned-off-by: Surabhi Boob <surabhi.boob@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 999ad6be3..bf8530e89 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -3908,11 +3908,19 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)\n \t\tes->ref_count = (u16 *)\n \t\t\tice_calloc(hw, es->count, sizeof(*es->ref_count));\n \n+\t\tif (!es->ref_count)\n+\t\t\tgoto err;\n+\n \t\tes->written = (u8 *)\n \t\t\tice_calloc(hw, es->count, sizeof(*es->written));\n+\n+\t\tif (!es->written)\n+\t\t\tgoto err;\n+\n \t\tes->mask_ena = (u32 *)\n \t\t\tice_calloc(hw, es->count, sizeof(*es->mask_ena));\n-\t\tif (!es->ref_count)\n+\n+\t\tif (!es->mask_ena)\n \t\t\tgoto err;\n \t}\n \treturn ICE_SUCCESS;\n", "prefixes": [ "v2", "01/40" ] }